[pull] master from chromium:master #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96e601c0..e1cd685a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibcb6b22434708f159c824cd84ce554bd9c7bb110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115766 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752566}
We are almost ready to fully turn off ContextGL on the Shared main thread context as part of the OOPR Canvas project. This CL replaces instances of ContextGL with the equivalent RasterInterface APIs in AcceleratedStaticBitmapImage. Bug: 1018898 Change-Id: Idf289c02273564ee987066e08421ac4b15384c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116532 Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752567}
Bug: 1064009 Change-Id: I6be262615deaeb9b237345540888ec57ac0fdcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114401 Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752568}
Currently we make a histogram log for each match position that changed asynchronously. This is a valuable metric, because it's proportional to the number of pixels that are changed that the user can see. But it also has the weakness of allowing a single match to displace multiple matches and generate multiple log counts. In other words, more bins are logged if more matches exist. This CL adds a analogous boolean histogram that logs True if ANY match positions change, and False if NONE of the match positions change: Omnibox.MatchStability.AsyncMatchChangedInAnyPosition I suspect both types of logging with be complementary. This new one should also be normalized by: Omnibox.Start.WantAsyncMatches::True Bug: 1062706 Change-Id: Ia325c15f3dfe67631613a136ede7bde51363ad39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108531 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#752569}
Map displaystyle attribute using math-style [1] as defined here [2]. Use the mapped internal math-style value for laying out fractions, i.e. pick the relevant metrics based on the math-style. [1] https://mathml-refresh.github.io/mathml-core/#the-math-style-property [2] https://mathml-refresh.github.io/mathml-core/#dfn-displaystyle Bug: 1023296 Change-Id: Ie12eb43275c5ca773c8f824e1f4c1a0f9f232b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105317 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#752570}
And rely on device_dependencies.py to prevent .stamp from being pushed to devices rather than a shim group() Change-Id: I4b0f50657d81b366ec1f81af9cc32e58e62380e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112815 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752571}
The existing kU2FCryptotoken{Register,Sign} UseCounters are currently
counted by Blink after the cryptotoken extension issues a WebAuthn
request. Blink counts them to the ExecutionContext from which the
WebAuthn request originates, which belongs to the cryptotoken Chrome
extension.
Instead, increment those UseCounters on the cryptotoken side, using the
MainFrame of the tab associated with the U2F request, so that the
recorded events are attributed to the site that actually made the U2F
request.
Change-Id: I672df8d2abdd0a32af887f2cb37fdb3e11c3338e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107708
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752572}
This change allows the preview tab to tell PermissionRequestManager to drop any permission requests it receives for the associated WebContents. TBR=andypaicu@chromium.org Bug: 1057951 Change-Id: I65ee35fbaf2081cc99d8384a5b0818fc9f026ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112812 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#752573}
The iOS generate wrapper template sets xctest and xcode parallelization to true (in ios/third_party/earl_grey/ios_eg_test.gni. Some EG tests don't utilize xctest, so we want to explicitly turn those off. Setting xctest = false for those tests in .gn files. Adding the test-arg for ios_chrome_settings_egtest in the manner that run.py expects it in. Change-Id: Id5ee79f08a34c4e9e3db84769287ee51b735bd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112750 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#752574}
…factory_owner.h The file contains one class and should represent the name of that class. R=nasko@chromium.org Bug: 866140 Change-Id: I7fe53fd31c593ac5053883480e2a274527d97542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113437 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#752575}
This removes logic in the MessagePort mojo handler that prevents MessagePorts from starving the message loop. This logic is redundant since https://chromium-review.googlesource.com/c/chromium/src/+/1145692. Change-Id: I379a8429675844837b5e51390cb803a288c2fe81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112954 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#752576}
chrome/browser/browser_process.h imports chrome/common/buildflags.h but doesn't include the target in BUILD.gn. chrome/test/base/testing_profile.h ditto. As the result, the files above maybe compiled before the buildflags.h is generated, which caused multiple flaky build failure. This CL added necessary target to deflake the build. TBR=sky@chromium.org Bug: 1063513 Change-Id: Ic3a74260351937382a9eabd32b9251d8d6057cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116591 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752577}
No-Try: True Bug: 1062984 Change-Id: I26141a5bb5c53765c6cabbc30e09cd2de4b92f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115767 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#752578}
For c/b/ui/ash/network OWNERS (will update in a followup): TBR=khorimoto@chromium.org Bug: 1054951 Change-Id: Ic24e51c04ca75a62a65bcdbfdba276580878dc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079131 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: James Vecore <vecore@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752579}
https://imgur.com/a/d54f4Ql Fixed: 1063811 Change-Id: I2cf58c15bbd9b5fe005c94e29e582acc3a32c829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116012 Reviewed-by: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752580}
No behavior change. Bug: 346399 Change-Id: Ia658bb2a3ba42f7da364688691bd926bb0c0bbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115783 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#752581}
TBR=govind@chromium.org Change-Id: I6e4869ebbb0c3cfbac28a29994c000601e6b8bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115797 Reviewed-by: Ben Mason <benmason@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#752582}
Refactoring work to make the process_perf_results cleaner. Bug: chromium:1045256 Change-Id: I8f5304364a111d5d7319cca7a297650af0ab721d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115698 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752583}
Bug: 1026426 Change-Id: I909df5d209fa574def562b572d5dcf4ad8c774e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113817 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#752584}
When the user goes through a reauth flow to retrieve trusted vault keys, the page should be closed upon completion. In order to achieve this, NavigateParams.created_with_opener is set to true, which allows Javascript on the page to close itself. In addition, the reuse of the NTP is disallowed because, in many relevant scenarios such as FRE, the NTP is the only existing tab and cannot be closed. As a fallback mechanism, a URL parameter is added to the reauth URL, in case the page decides to redirect instead of closing (or if closing the tab was rejected). Change-Id: I124ddd299c47a7c5705b410829a38130ea78e208 Bug: 1062977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108731 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#752585}
This reverts commit aa1faf8, i.e. it relands fccf3a8. (After thinking about structure padding and writing a comment, I forgot to actually handle it! Probably too complex anyway; do something dumber.) > Revert "Give the desktop a public key in QR handshakes." > > This reverts commit fccf3a8. > > Reason for revert: > This CL breaks on Linux MSan bot > FidoCableDiscoveryTest.TestDiscoveryFindsNewAppleDevice > FidoCableDiscoveryTest.TestDiscoveryFindsIncorrectDevice > > First failure: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22909 > > Original change's description: > > Give the desktop a public key in QR handshakes. > > > > This change switches the QR-based handshake from NNpsk0 to KNpsk0. I.e. > > it gives the desktop a public-key. That key is included in the QR code > > and means that an attacker who sees the QR code cannot impersonate the > > desktop and pair with the phone. (The other direction is still possible, > > however, and seems fundamental without the user entering a confirmation > > code on the desktop.) > > > > BUG=1002262 > > > > Change-Id: I7254a8aa17df71d2bcabb4371a1c18914ed20641 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109032 > > Commit-Queue: Adam Langley <agl@chromium.org> > > Auto-Submit: Adam Langley <agl@chromium.org> > > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > > Cr-Commit-Position: refs/heads/master@{#752196} > > TBR=agl@chromium.org,martinkr@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1002262 > Change-Id: Id75ad0bab2862b3dafe73d20cf762883cc24faf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113771 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752403} BUG=10022628 Change-Id: I993eab544edd2eca6bc5c5923f9dab9b2d07c393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115799 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#752586}
Bug: 968222 Change-Id: I5c9a711686f6af8d550b33e18e7b9419e016d09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114406 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Tien Mai <tienmai@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752587}
…imation ... originally regressed by https://chromium-review.googlesource.com/c/chromium/src/+/2107302 Bug: 1063506, 1059968 Change-Id: Id7fd285c9e5cf9a70981e34c4645f778fbf2899f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113801 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#752588}
Passing command line arguments now works with, for example: $ autoninja -C out/Release run_weblayer_shell $ out/Release/bin/run_weblayer_shell https://google.com \ --args='--weblayer-user-data-dir=/data/data/org.chromium.weblayer.shell/some_dir' Bug: 1063945 Change-Id: Iffdda53a56950f74dd58df63faa5cb8604988ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116598 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#752589}
https://pdfium.googlesource.com/pdfium.git/+log/dcbd802564ed..3e74fb81116b git log dcbd802564ed..3e74fb81116b --date=short --first-parent --format='%ad %ae %s' 2020-03-23 thestig@chromium.org Disambiguate CFX_PathData::IsRect(). 2020-03-23 thestig@chromium.org Use more spans in CGdiplusExt::DrawPath(). 2020-03-23 thestig@chromium.org Remove manual memory allocation in CGdiplusExt::DrawPath(). 2020-03-23 thestig@chromium.org Remove some unneeded includes. 2020-03-21 nigi@chromium.org Fix rendering issue for PDFs with incorrect first-page hint data. Created with: gclient setdep -r src/third_party/pdfium@3e74fb81116b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1012237 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1876b21d517db9ba967b1a3e6ff1d8d8f52cff02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116693 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752590}
…ted sheet. See WICG/construct-stylesheets#62 for the rejected promise bit. On top of that we were not returning so we were incorrectly applying the styles. Bug: 1063809 Change-Id: I63aa937f66871e3b8eee577a7f2ddd873f45d2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116092 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752591}
Bug: 1064059 Change-Id: Id8362f5f70f82a5732b32746a71e4131223923a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116593 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752592}
https://chromium.googlesource.com/catapult.git/+log/1dea10da0ae8..85201b613e63 git log 1dea10da0ae8..85201b613e63 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 rmhasan@google.com [Telemetry] Add SUPPORTED_PLATFORM_TAGS list to Benchmark class Created with: gclient setdep -r src/third_party/catapult@85201b613e63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:992603 Tbr: sadrul@google.com Change-Id: Iea388a40bbef3d402713836c0581640db9ef6ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116692 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752593}
Multiple ProfileDestroyers destroying a single Profile is sorted out in ProfileDestroyer::DestroyOffTheRecordProfileNow by the first destroyer nulling out the pointer to the Profile in the others so they won't destroy the same Profile again. It has a bug breaking out the loop after handling the first one. The right way is finding and nulling out all the Destroyers. This CL fixes it. Bug: 1029677 Change-Id: I7d8efe60a28613040e0a2afd9db0640ea3602c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113391 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#752594}
Bug: 1025609 Change-Id: Ie4aca6a905a1f6818faf09be00499e1986d16880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065413 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752595}
Change-Id: I03ebd6b77c58f614191afa71c1ab477e9b4d180d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051771 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#752617}
Bug: 1063529,346399 Change-Id: I313ebf4cc16885d1f9bdc5a2ed8db524467735f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116590 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#752618}
…nts/.." This reverts commit 352154b. Reason for revert: Causing build failure in android-internal-chromium-tot https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/54793? Original change's description: > [Payments][Android] Move PayerData.java into components/payments/.. > > This cl moves PayerData.java class into components/payments so that > the WebPaymentIntentHelper.java class can use it without depending on > chrome/browser. It also introduces a new Address class and its > converter utility class so that PayerData.java does not depend on > mojom.PaymentAddress. > > Change-Id: Idb737bc2697212af7542d3abbd1488461a7d3074 > Bug: 1026667 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110678 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752597} TBR=kenrb@chromium.org,rouslan@chromium.org,sahel@chromium.org Change-Id: I07531956a23479f4f7118b89b7b33b50c0114c65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116584 Reviewed-by: Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#752619}
To simplify the use of the scroll function, we can use the smoothScroll function in gesture-util.js instead of chrome.gpuBenchmarking.smoothScrollBy in all the layout tests. Bug: 1047176 Change-Id: I6764bd72e42d54a2623b453a808061f96d045687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115798 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#752620}
Also cleans up the fieldtrial_testing_config entry for the SyncButterWallet launch now that it's enabled ToT (and 100% launched). Per request, not going to clean up the code usage of the flag quite yet because Butter for Mobile may be coming in the near future. Bug: 983940 Change-Id: Icfb628cb509c77960d7686c3ad8c5a6161ca7547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092064 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#752621}
…b_view/public Change-Id: I4cb1539a93be286bdaaef436d94da036d5aa86d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011629 Commit-Queue: Jiajun Ou <garzonou@google.com> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752622}
Make sure all TabToGTSAnimation annotations in StartSurfaceLayoutTest are correct. Bug: 964406 Change-Id: I437040b668b1e9a397c90863d9142dadc2c0eabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114209 Reviewed-by: Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752623}
NetworkStateHandler has never been meant to honor calls to its RequestUpdateForNetwork() method for Tether networks (as per its documentation) but never explicitly enforced that. A recent CL, crrev.com/c/2078372, exposed this oversight by calling RequestUpdateForNetwork() on a Tether network, causing a crash. This CL corrects that oversight by early-returning within RequestUpdateForNetwork() if a Tether network is provided. Bug: 1061780 Change-Id: Iea2ab7d73c4417408ccb1b5e7622dd87a7dcd71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111352 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752624}
Initial user feedback is still being gathered for ARC printing. Extend the flag's expiry milestone to M84 to allow the feature to be toggled on and off in M83. Bug: b:152244509 Change-Id: I90c36a596220d47adae4e512dde32899f905160c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116933 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#752625}
Verify that a colon exists before attempting to substring based on the position of the colon. Bug: chromedriver:3234 Change-Id: Iafb4ed1bf928fcebf28e0a430bc0bc1f7ceb7185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111051 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#752626}
This follows the guidance given in the comments of the bug to eliminate the use of hardcoded SkColorSet* in ui/. Part 1 cleans colors in combobox, bubble_frame_view, canvas_paint_mac, touch_selection_menu_views, message_view, image_skia_operations, clipboard_win, tween, dialog_example. Bug: 1056950 Change-Id: Iceb8e431b0b6346136eaa6b57537e3f6000c0ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108573 Commit-Queue: Maria Villarreal <mavill@microsoft.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752627}
pull bot
pushed a commit
that referenced
this pull request
Mar 31, 2020
Fixed by adding a WeakPtrFactory to SpeechMonitor so all posted task callbacks don't run if we destroy SpeechMonitor previously.
Failure in asan:
READ of size 8 at 0x7f8dc614c068 thread T0 (browser_tests)
#0 0x559e511d3be4 in time_since_epoch ./../../buildtools/third_party/libc++/trunk/include/chrono:1383:103
#1 0x559e511d3be4 in operator-<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> >, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> > > ./../../buildtools/third_party/libc++/trunk/include/chrono:1564:45
#2 0x559e511d3be4 in CalculateUtteranceDelayMS ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:93:15
#3 0x559e511d3be4 in chromeos::SpeechMonitor::MaybePrintExpectations() ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:230:7
#4 0x559e5edf6c45 in Run ./../../base/callback.h:98:12
#5 0x559e5edf6c45 in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:142:33
#6 0x559e5ee2dfe8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:324:23
#7 0x559e5ee2d93a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:248:7
#8 0x559e5ef7c9d6 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:208:55
#9 0x559e5ee2f188 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:429:12
#10 0x559e5eda978d in base::RunLoop::Run() ./../../base/run_loop.cc:124:14
#11 0x559e5ecac5eb in RunUntilBrowserProcessQuits ./../../chrome/test/base/in_process_browser_test.cc:362:38
#12 0x559e5ecac5eb in InProcessBrowserTest::QuitBrowsers() ./../../chrome/test/base/in_process_browser_test.cc:584:3
#13 0x559e5ecac2f7 in InProcessBrowserTest::PostRunTestOnMainThread() ./../../chrome/test/base/in_process_browser_test.cc:559:3
#14 0x559e601dc870 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:699:3
#15 0x559e5f0c5e8f in Run ./../../base/callback.h:98:12
#16 0x559e5f0c5e8f in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1640:38
#17 0x559e5f0c3bdb in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#18 0x559e5324fc2f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:597:32
#19 0x559e57b9c078 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1020:13
#20 0x559e58ab7d34 in Run ./../../base/callback.h:98:12
#21 0x559e58ab7d34 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
#22 0x559e57b993a4 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:929:25
#23 0x559e57ba10ce in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15
#24 0x559e57b94ae5 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
#25 0x559e5d885212 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10
#26 0x559e5d885212 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10
#27 0x559e5d8844d8 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12
#28 0x559e667f3da4 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:457:29
#29 0x559e5ab9eec2 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
#30 0x559e601da293 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3
#31 0x559e5eca7ca9 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:303:20
#32 0x559e5220cb97 in HotseatShelfAppBrowserTest::SetUp() ./../../chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:2274:26
#33 0x559e540b8f08 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#34 0x559e540b8f08 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3
#35 0x559e540bb736 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11
#36 0x559e540bcc76 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28
#37 0x559e540e3716 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44
#38 0x559e540e23f3 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#39 0x559e540e23f3 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10
#40 0x559e5efb6539 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46
#41 0x559e5efb6539 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16
#42 0x559e5ec63f38 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23
#43 0x559e6029ce29 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31
#44 0x559e5ec651cb in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:247:10
#45 0x559e5ec63d69 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10
#46 0x7f8dc93aabba in __libc_start_main /build/glibc-QG9qOO/glibc-2.29/csu/../csu/libc-start.c:308:16
Address 0x7f8dc614c068 is located in stack of thread T0 (browser_tests) at offset 104 in frame
#0 0x559e625d8a0f in base::circular_deque<mojo::Message>::DestructRange(unsigned long, unsigned long) ./../../base/containers/circular_deque.h:998:0
Original change
https://chromium-review.googlesource.com/c/chromium/src/+/2124701
TBR=nancylingwang@chromium.org, dmazzoni@chromium.org
Fixed: 1065746
Test: ran tests against asan, debug, and release
Change-Id: Ie3b245933969ffe182962e017515e4cf656ef05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128027
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754701}
pull bot
pushed a commit
that referenced
this pull request
May 23, 2020
This reverts commit 9cca480. Reason for revert: <INSERT REASONING HERE> See flakey failures https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENocm9tZVZveEJyYWlsbGVUYWJsZVRlc3QudGVzdEdldFVuY29udHJhY3RlZAw [7369:7369:0522/203957.919406:FATAL:chrome_extensions_browser_client.cc(148)] Check failed: context. #0 0x55cfe9dfc549 base::debug::CollectStackTrace() #1 0x55cfe9d09be3 base::debug::StackTrace::StackTrace() #2 0x55cfe9d20d7f logging::LogMessage::~LogMessage() #3 0x55cfe9d2156e logging::LogMessage::~LogMessage() #4 0x55cfed7b0e42 extensions::ChromeExtensionsBrowserClient::GetOriginalContext() #5 0x55cfed58f4c3 BrowserContextKeyedServiceFactory::GetContextToUse() #6 0x55cfebd733c3 KeyedServiceFactory::GetServiceForContext() #7 0x55cfea38f279 extensions::TtsExtensionEventHandler::OnTtsEvent() #8 0x55cfe73698c8 content::TtsUtteranceImpl::OnTtsEvent() #9 0x55cfe7365120 content::TtsControllerImpl::ClearUtteranceQueue() #10 0x55cfe7365f03 content::TtsControllerImpl::StopInternal() #11 0x55cfe7367071 content::TtsControllerImpl::OnBrowserContextDestroyed() #12 0x55cfe6d1d18c content::BrowserContext::~BrowserContext() #13 0x55cfea0f813f ProfileImpl::~ProfileImpl() #14 0x55cfea0f816e ProfileImpl::~ProfileImpl() #15 0x55cfea0f1f72 ProfileDestroyer::DestroyRegularProfileNow() #16 0x55cfea0f1d00 ProfileDestroyer::DestroyProfileWhenAppropriate() #17 0x55cfea1137e8 std::__1::unique_ptr<>::~unique_ptr() #18 0x55cfea114ee3 std::__1::__tree<>::destroy() #19 0x55cfea11473b ProfileManager::~ProfileManager() #20 0x55cfea10bfae ProfileManager::~ProfileManager() #21 0x55cfe9eac15a BrowserProcessImpl::StartTearDown() #22 0x55cfe9eaab2a ChromeBrowserMainParts::PostMainMessageLoopRun() #23 0x55cfe51c9e74 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #24 0x55cfe6d41ccf content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #25 0x55cfe6d43b6d content::BrowserMainRunnerImpl::Shutdown() #26 0x55cfe6d3eb02 content::BrowserMain() #27 0x55cfe97ac717 content::ContentMainRunnerImpl::RunServiceManager() #28 0x55cfe97ac2cf content::ContentMainRunnerImpl::Run() #29 0x55cfec99806a service_manager::Main() #30 0x55cfe7f60444 content::ContentMain() #31 0x55cfea5622a4 content::BrowserTestBase::SetUp() #32 0x55cfe9cf633b InProcessBrowserTest::SetUp() #33 0x55cfe579858e testing::Test::Run() #34 0x55cfe5799948 testing::TestInfo::Run() #35 0x55cfe579a5e7 testing::TestSuite::Run() #36 0x55cfe57aa747 testing::internal::UnitTestImpl::RunAllTests() #37 0x55cfe57aa179 testing::UnitTest::Run() #38 0x55cfe9e477e2 base::TestSuite::Run() #39 0x55cfe9cdf0e7 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #40 0x55cfea5a72f4 content::LaunchTests() #41 0x55cfe9cdf494 LaunchChromeTests() #42 0x55cfe9cdf032 main #43 0x7f421a16f830 __libc_start_main #44 0x55cfe29b442a _start Fixed: Fixed: 1085878, 1085877 Fixed: 1085878, 1085877 Original change's description: > Fix UAF in TtsPlatformImpl if a BrowserContext is deleted. > > Bug: 1081350 > Change-Id: I2b1824abefbd7fc3e8ce1c0cb433896161bab4e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211123 > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771222} TBR=dmazzoni@chromium.org,dtseng@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1081350 Change-Id: I88ec7e523fbe56845b8480b112535b2f8e18a520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213553 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771379}
pull bot
pushed a commit
that referenced
this pull request
Jul 30, 2020
The change https://chromium-review.googlesource.com/c/chromium/src/+/1980612 explicitly unloads various component extensions deemed to be risky. Unfortunately, the hash for ChromeVox (which was supposed to not be risky) was *wrong*, so it was being unloaded mysteriously. Test: obtain the hash for ChromeVox (extension id mdn....), via logging and print the hex hash. Verify after correcting the hash in profile_helper.cc, on-device, doing things like clicking the "Add Person" button doesn't unloads ChromeVox. Fixed: 1094031 Issue details: On the login screen, invoke the "Add Person" button. result: ChromeVox is unloaded i.e. #2 0x57e72acd8634 content::RenderFrameHostImpl::~RenderFrameHostImpl() #3 0x57e72acd8520 content::RenderFrameHostImpl::~RenderFrameHostImpl() #4 0x57e72b0bb120 content::RenderFrameHostManager::~RenderFrameHostManager() #5 0x57e72acd2449 content::FrameTreeNode::~FrameTreeNode() #6 0x57e72bffe68d content::FrameTree::~FrameTree() #7 0x57e72c20defa content::WebContentsImpl::~WebContentsImpl() #8 0x57e72c20e928 content::WebContentsImpl::~WebContentsImpl() #9 0x57e72c3d2490 extensions::ExtensionHost::~ExtensionHost() #10 0x57e72c3d253c extensions::ExtensionHost::~ExtensionHost() #11 0x57e72c40f857 extensions::ProcessManager::CloseBackgroundHost() #12 0x57e72c40fabe extensions::ProcessManager::OnExtensionUnloaded() #13 0x57e72c3ea211 extensions::ExtensionRegistry::TriggerOnUnloaded() #14 0x57e72c3e8f3a extensions::ExtensionRegistrar::DeactivateExtension() #15 0x57e72c3e8be7 extensions::ExtensionRegistrar::RemoveExtension() #16 0x57e72f781d0b extensions::ExtensionService::RemoveComponentExtension() #17 0x57e72f761c47 extensions::ComponentLoader::Remove() #18 0x57e72cb46908 chromeos::ProfileHelperImpl::ClearSigninProfile() #19 0x57e7304c57c1 chromeos::GaiaScreenHandler::StartClearingCookies() #20 0x57e7304c58dc chromeos::GaiaScreenHandler::ShowGaiaAsync() #21 0x57e72ca0362b chromeos::LoginDisplayHostCommon::ShowGaiaDialogCommon() #22 0x57e72ca04686 chromeos::LoginDisplayHostMojo::ShowGaiaDialog() #23 0x57e72fbfd2ef ash::LoginShelfView::ButtonPressed() #24 0x57e72f27480c views::ButtonController::OnKeyPressed() #25 0x57e72f2c2624 views::View::OnKeyEvent() #26 0x57e72f266a3b ui::ScopedTargetHandler::OnEvent() #27 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #28 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #29 0x57e72e80fd89 ui::EventSource::SendEventToSinkFromRewriter() #30 0x57e72f2cf9e0 views::Widget::OnKeyEvent() #31 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #32 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #33 0x57e72ebb9387 aura::WindowTreeHost::DispatchKeyEventPostIME() #34 0x57e72e8381c3 ui::InputMethodBase::DispatchKeyEventPostIME() #35 0x57e72e85f4fd ui::InputMethodChromeOS::ProcessUnfilteredKeyPressEvent() #36 0x57e72e85f24c ui::InputMethodChromeOS::DispatchKeyEvent() #37 0x57e72ebb217f aura::WindowEventDispatcher::PreDispatchKeyEvent() #38 0x57e72ebb1a28 aura::WindowEventDispatcher::PreDispatchEvent() #39 0x57e72e80eedd ui::EventDispatcherDelegate::DispatchEvent() #40 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #41 0x57e72e80fece ui::EventSource::EventRewriterContinuationImpl::SendEvent() #42 0x57e72c649a27 ui::EventRewriterChromeOS::RewriteKeyEventInContext() #43 0x57e72c6492fe ui::EventRewriterChromeOS::RewriteEvent() #44 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #45 0x57e72fb88588 ash::KeyboardDrivenEventRewriter::RewriteEvent() #46 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #47 0x57e72fb88e9b ash::SpokenFeedbackEventRewriter::RewriteEvent() #48 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #49 0x57e72fbec429 ash::TouchExplorationController::RewriteEvent() #50 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #51 0x57e72fb5e078 ash::AutoclickDragEventRewriter::RewriteEvent() #52 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #53 0x57e72fbdf76b ash::MagnificationController::RewriteEvent() #54 0x57e72e80fd68 ui::EventSource::SendEventToSinkFromRewriter() #55 0x57e72fb9bb93 aura::WindowTreeHostPlatform::DispatchEvent() #56 0x57e72fb9d8dc ash::AshWindowTreeHostPlatform::DispatchEvent() Change-Id: Ibead7896cecddcb3da8bb4a553137f65700248f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324108 Reviewed-by: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792662}
pull bot
pushed a commit
that referenced
this pull request
Sep 11, 2020
As per recommendation in Comment #30 of crbug.com/1114876. This is the same grey used in Network Settings secondary text. Bug: b:167556640 Change-Id: I5a669cae3e43fc7cfe3d57eb276a4f6584a322e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404141 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: James Vecore <vecore@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805877}
pull bot
pushed a commit
that referenced
this pull request
Sep 18, 2020
As per recommendation in Comment #30 of crbug.com/1114876. BUG=b:167556640 Change-Id: I57bc4ff360d05d1d6a0b03f58d4f24e23492b858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410746 Reviewed-by: Tim Song <tengs@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#808073}
pull bot
pushed a commit
that referenced
this pull request
Sep 25, 2020
…status." This reverts commit 54974f6. Reason for revert: After evaluation, staying with green is decided. BUG=b:167556640 Original change's description: > [Bluetooth] Use secondary text color for device connectivity status. > > As per recommendation in Comment #30 of crbug.com/1114876. This > is the same grey used in Network Settings secondary text. > > Bug: b:167556640 > Change-Id: I5a669cae3e43fc7cfe3d57eb276a4f6584a322e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404141 > Auto-Submit: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805877} TBR=khorimoto@chromium.org,hansberry@chromium.org,vecore@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:167556640 Change-Id: Ie4780eb924787986a80cf1dff00a0e48c5fd8207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429971 Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#810431}
pull bot
pushed a commit
that referenced
this pull request
Sep 29, 2020
This reverts commit eb59216. Reason for revert: After evaluation, staying with green is decided. BUG=b:167556640 Original change's description: > [Bluetooth] Change Bluetooth subtext to gray > > As per recommendation in Comment #30 of crbug.com/1114876. > > BUG=b:167556640 > > Change-Id: I57bc4ff360d05d1d6a0b03f58d4f24e23492b858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410746 > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808073} TBR=xiyuan@chromium.org,tengs@chromium.org,sonnysasaka@chromium.org,hansberry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:167556640 Change-Id: I6dd86bf9e10c8c06bb2fec96561da7715d14ccee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430105 Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#811354}
pull bot
pushed a commit
that referenced
this pull request
Nov 17, 2020
This reverts commit f771327. Reason for revert: The added browser tests appear to be (flakily) crashing on various builders: For example https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95504 with https://chromium-swarm.appspot.com/task?id=4fef1ab263264c10 [1303/1306] StartupBrowserWithWebAppTest.PRE_PRE_LastUsedProfilesWithWebApp (1571 ms) [ RUN ] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp [11419:11462:1117/050706.931735:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [11419:11462:1117/050706.931814:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed. [11419:11462:1117/050706.932083:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [11419:11462:1117/050706.932300:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x558aecd46cd9 base::debug::CollectStackTrace() #1 0x558aeccb6753 base::debug::StackTrace::StackTrace() #2 0x558aed26b5f6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f26cd1224c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x558ae929f9a0 StartupBrowserWithWebAppTest_PRE_LastUsedProfilesWithWebApp_Test::RunTestOnMainThread() #5 0x558aed26a407 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x558aecde10ef ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #7 0x558aecddfed5 ChromeBrowserMainParts::PreMainMessageLoopRun() #8 0x558aeb16da36 content::BrowserMainLoop::PreMainMessageLoopRun() #9 0x558aeb5c3b13 content::StartupTaskRunner::RunAllTasksNow() #10 0x558aeb16ca17 content::BrowserMainLoop::CreateStartupTasks() #11 0x558aeb16f638 content::BrowserMainRunnerImpl::Initialize() #12 0x558aeb16af68 content::BrowserMain() #13 0x558aebc439c3 content::ContentMainRunnerImpl::RunServiceManager() #14 0x558aebc435b6 content::ContentMainRunnerImpl::Run() #15 0x558aebc40a64 content::RunContentProcess() #16 0x558aebc413ec content::ContentMain() #17 0x558aed269f34 content::BrowserTestBase::SetUp() #18 0x558aecca3c51 InProcessBrowserTest::SetUp() #19 0x558aea228198 testing::Test::Run() #20 0x558aea22902f testing::TestInfo::Run() #21 0x558aea229a07 testing::TestSuite::Run() #22 0x558aea237207 testing::internal::UnitTestImpl::RunAllTests() #23 0x558aea236b6f testing::UnitTest::Run() #24 0x558aecd97f74 base::TestSuite::Run() #25 0x558aecc8d252 ChromeTestSuiteRunner::RunTestSuite() #26 0x558aed299357 content::LaunchTests() #27 0x558aecc8d522 LaunchChromeTests() #28 0x558aecc8ac54 main #29 0x7f26cd10d840 __libc_start_main #30 0x558ae864e0aa _start [1304/1306] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp (CRASHED) Similar crash also on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110376 (https://chromium-swarm.appspot.com/task?id=4feff52dc4172910) Original change's description: > Fix session restore after launching with PWA. > > The underlying issue is that the kProfilesLastActive pref gets > cleared when Chrome is launched with a specific profile, which > prevents Chrome from iterating over the last active profiles > and calling session restore on each of them. This CL stops > clearing the pref when launched with --app-id, and avoids > restoring sessions for the last active profiles > if launched with --app-id. Also, ignore browser opens and > closes if the browser window is for a web app, in order to prevent > kProfilesLastActive pref from getting overwritten. > > Bug: 1022795 > Change-Id: I350a54eaaf167dabb297b9bda9061fe965f0750e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984710 > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827876} TBR=droger@chromium.org,grt@chromium.org,davidbienvenu@chromium.org Change-Id: Ib48b40d1c39911d9c5b1072fda35703a70be1f5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544744 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828247}
pull bot
pushed a commit
that referenced
this pull request
Dec 12, 2020
This reverts commit 3da5569. Reason for revert: Suspected to be causing widespread failures in PPAPI/Pepper tests on Win and Linux dbg bots: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/87226 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93584 Sample failure output: [ RUN ] OutOfProcessPPAPITest.Instance_ExecuteScript [18698:18698:1211/141847.386588:INFO:content_main_runner_impl.cc(1027)] Chrome is running in full browser mode. DevTools listening on ws://127.0.0.1:37739/devtools/browser/565ba965-de40-4715-8905-11c22e1cfcca [18698:18811:1211/141848.175888:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18811:1211/141848.265958:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18698:1211/141848.839793:INFO:CONSOLE(1)] "Uncaught Error: plugin exception", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.844552:INFO:CONSOLE(1)] "Uncaught TypeError: document.doesntExist is not a function", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.855716:INFO:CONSOLE(176)] "ExecuteScript finished in 0.073 seconds.", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (176) Received signal 11 <unknown> 000000000000 #0 0x7f89c0dca89f base::debug::CollectStackTrace() #1 0x7f89c0b5409a base::debug::StackTrace::StackTrace() #2 0x7f89c0b54055 base::debug::StackTrace::StackTrace() #3 0x7f89c0dca36b base::debug::(anonymous namespace)::StackDumpSignalHandler() #4 0x7f8993ea2390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #5 0x7f89b142c419 std::__Cr::default_delete<>::operator()() #6 0x7f89b142c3ea std::__Cr::unique_ptr<>::reset() #7 0x7f89b142c379 std::__Cr::unique_ptr<>::~unique_ptr() #8 0x7f89b142c16d mojo::internal::AssociatedInterfacePtrState<>::~AssociatedInterfacePtrState() #9 0x7f89b142cb95 mojo::AssociatedRemote<>::~AssociatedRemote() #10 0x7f89b142afab content::PepperPluginInstance::~PepperPluginInstance() #11 0x7f89b2587d8e content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #12 0x7f89b2587e69 content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #13 0x7f89b25350f8 base::RefCounted<>::DeleteInternal<>() #14 0x7f89b25350c5 base::DefaultRefCountedTraits<>::Destruct() #15 0x7f89b25350a3 base::RefCounted<>::Release() #16 0x7f89b2535069 scoped_refptr<>::Release() #17 0x7f89b253020a scoped_refptr<>::~scoped_refptr() #18 0x7f89b25ce3f3 scoped_refptr<>::reset() #19 0x7f89b25cd8dd _ZN13scoped_refptrIN7content24PepperPluginInstanceImplEEaSEDn #20 0x7f89b25cbe83 content::PepperWebPluginImpl::Destroy() #21 0x7f89a7414e41 blink::WebPluginContainerImpl::Dispose() #22 0x7f89a593f32d blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::PerformDeferredPluginDispose() #23 0x7f89a4f5d292 blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::~PluginDisposeSuspendScope() #24 0x7f89a4f58862 blink::ContainerNode::RemoveChild() #25 0x7f89a5111cbb blink::Node::removeChild() #26 0x7f89a70daabe blink::(anonymous namespace)::RemoveChildOperationCallback() #27 0x7f899e0c0780 v8::internal::FunctionCallbackArguments::Call() #28 0x7f899e0bedcd v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #29 0x7f899e0bcfe5 v8::internal::Builtin_Impl_HandleApiCall() #30 0x7f899e0bcaa9 v8::internal::Builtin_HandleApiCall() #31 0x7f899dae513f Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit r8: 00000f84ee181f88 r9: 0000000000000000 r10: 0000000000000259 r11: 00007f8996194690 r12: 00007f89a70da600 r13: 0000132400000000 r14: 00007ffc8c8eef10 r15: 00007ffc8c8eef10 di: 00007f89b3e98918 si: 00007f89b3e98918 bp: 00007ffc8c8ee710 bx: 00007f89c0f52440 dx: 00000f84ee181f90 ax: 00007f89b2587db0 cx: 0000000000000000 sp: 00007ffc8c8ee6f0 ip: 00007f89b142c419 efl: 0000000000010206 cgf: 002b000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. ../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure Failed Unexpected termination of a renderer process; status: 1, exit_code: 256 Stack trace: #0 0x55ec1877d394 content::NoRendererCrashesAssertion::Observe() #1 0x7f3d4cf1ead6 content::NotificationServiceImpl::Notify() #2 0x7f3d4d3a3986 content::RenderProcessHostImpl::ProcessDied() #3 0x7f3d4d3a46be content::RenderProcessHostImpl::OnChannelError() #4 0x7f3d60fa392d IPC::ChannelProxy::Context::OnDispatchError() #5 0x7f3d60fa987f base::internal::FunctorTraits<>::Invoke<>() #6 0x7f3d60fa97c1 base::internal::InvokeHelper<>::MakeItSo<>() #7 0x7f3d60fa9742 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunImplIS7_NSt4__Cr5tupleIJS9_EEEJLm0EEEEvOT_OT0_NSE_16integer_sequenceImJXspT1_EEEE #8 0x7f3d60fa96ec base::internal::Invoker<>::RunOnce() #9 0x7f3d5ca3c0d1 _ZNO4base12OnceCallbackIFvvEE3RunEv #10 0x7f3d5cc03df2 base::TaskAnnotator::RunTask() #11 0x7f3d5cc49eba base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #12 0x7f3d5cc49685 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x7f3d5cc4a119 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #14 0x7f3d5caf69f1 base::MessagePumpGlib::HandleDispatch() #15 0x7f3d5caf7141 base::(anonymous namespace)::WorkSourceDispatch() #16 0x7f3d2f683197 g_main_context_dispatch #17 0x7f3d2f6833f0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2+0x4a3ef) #18 0x7f3d2f68349c g_main_context_iteration #19 0x7f3d5caf6b00 base::MessagePumpGlib::Run() #20 0x7f3d5cc4a740 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #21 0x7f3d5cb95d75 base::RunLoop::Run() #22 0x55ec187b836a content::RunThisRunLoop() #23 0x55ec187b831f content::RunMessageLoop() #24 0x55ec18760320 content::JavascriptTestObserver::Run() #25 0x55ec16a8b567 content::PPAPITestBase::RunTestURL() #26 0x55ec16a8b48e content::PPAPITestBase::RunTest() #27 0x55ec16a84f2a content::(anonymous namespace)::OutOfProcessPPAPITest_Instance_ExecuteScript_Test::RunTestOnMainThread() #28 0x55ec18719264 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #29 0x55ec1871cf2a base::internal::FunctorTraits<>::Invoke<>() #30 0x55ec1871cea1 base::internal::InvokeHelper<>::MakeItSo<>() #31 0x55ec1871ce37 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #32 0x55ec1871cddc base::internal::Invoker<>::RunOnce() #33 0x55ec157bbac1 _ZNO4base12OnceCallbackIFvvEE3RunEv #34 0x55ec18a331cc content::ShellBrowserMainParts::PreMainMessageLoopRun() #35 0x7f3d4c5f5282 content::BrowserMainLoop::PreMainMessageLoopRun() #36 0x7f3d4c5ff18a base::internal::FunctorTraits<>::Invoke<>() #37 0x7f3d4c5ff0a1 base::internal::InvokeHelper<>::MakeItSo<>() #38 0x7f3d4c5ff027 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #39 0x7f3d4c5fefcc base::internal::Invoker<>::RunOnce() #40 0x7f3d4c9d5b31 _ZNO4base12OnceCallbackIFivEE3RunEv #41 0x7f3d4d812b16 content::StartupTaskRunner::RunAllTasksNow() #42 0x7f3d4c5f3b8a content::BrowserMainLoop::CreateStartupTasks() #43 0x7f3d4c602df0 content::BrowserMainRunnerImpl::Initialize() #44 0x7f3d4c5f0d64 content::BrowserMain() #45 0x7f3d4e7bcbc6 content::RunBrowserProcessMain() #46 0x7f3d4e7be1e9 content::ContentMainRunnerImpl::RunBrowser() #47 0x7f3d4e7bdad7 content::ContentMainRunnerImpl::Run() #48 0x7f3d4e7bae05 content::RunContentProcess() #49 0x7f3d4e7bb79d content::ContentMain() #50 0x55ec18718d5a content::BrowserTestBase::SetUp() #51 0x55ec1865a9ac content::ContentBrowserTest::SetUp() #52 0x55ec16a8ba95 content::OutOfProcessPPAPITest::SetUp() #53 0x55ec17363a6b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #54 0x55ec173547f7 testing::internal::HandleExceptionsInMethodIfSupported<>() Note the ~AssociatedRemote from ~PepperPluginInstanceImpl, which I think was introduced in this CL. This also seems to be the only plugin-related change in the blamelist (https://chromium.googlesource.com/chromium/src/+log/6828ef78f2200e4bac3280186c7520ab65b2d7f8%5E..21468f4304510a432e3376d9d72ec67962f39723?pretty=fuller&n=) Original change's description: > Add mojo interfaces for pepper plugins. > > This adds some base plumbing for pepper plugin instance handling. The > pepper renderer code allocates and manages the PepperPluginInstanceImpl, > this creates the correct encapsulation moving code out of RenderFrameImpl. > > On the browser side a PepperPluginInstance is created to handle the > messages and relay them to the WebContentsImpl which use to handle > the processing of Pepper messages. > > BUG=1157519 > > Change-Id: I24941bb7eecef56a90bbf961e6396101c8d3c785 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585627 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836239} TBR=dcheng@chromium.org,bbudge@chromium.org,dtapuska@chromium.org,arthursonzogni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iddd93694ebe0611abef6c74b57667554b51e26fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587769 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836330}
pull bot
pushed a commit
that referenced
this pull request
Jan 13, 2021
This reverts commit 8aca3b4. Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview [ RUN ] WindowOpenApiTest.PopupBlockingExtension 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure Expected equality of these values: num_browsers Which is: 4 chrome::GetBrowserCount(browser->profile()) Which is: 2 Google Test trace: ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 Stack trace: #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #6 0x563646f2068c base::internal::Invoker<>::RunOnce() #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() #20 0x7fb5dc82a804 content::BrowserMain() #21 0x7fb5de9aae56 content::RunBrowserProcessMain() #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() #24 0x7fb5de9a9106 content::RunContentProcess() #25 0x7fb5de9a9a3d content::ContentMain() #26 0x563646f1cb13 content::BrowserTestBase::SetUp() #27 0x563645acb283 InProcessBrowserTest::SetUp() #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() Original change's description: > Support multiple receivers for Cros APIs. > > With this CL, most of Cros API starts to support multiple receivers. > AshChromeService and LacrosChromeService are exceptions. > > Bug: 1148448 > Test: Build and run Lacros on a DUT. > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842869} TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842943}
pull bot
pushed a commit
that referenced
this pull request
Jan 13, 2021
…vice" This reverts commit 85753b0. Reason for revert: I suspect this CL caused failures SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/6414/overview Fontconfig error: Cannot load default config file: No such file: (null) BrowserTestBase received signal: Terminated. Backtrace: #0 0x5596f4879789 base::debug::CollectStackTrace() #1 0x5596f47e4163 base::debug::StackTrace::StackTrace() #2 0x5596f4dcc0c6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f128ca544c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f12902ec9ff __libc_send #5 0x5596f2a8598f mojo::core::ChannelPosix::WriteNoLock() #6 0x5596f2a854b2 mojo::core::ChannelPosix::Write() #7 0x5596f2a7370e mojo::core::NodeChannel::SendChannelMessage() #8 0x5596f2a7808a mojo::core::NodeController::SendPeerEvent() #9 0x5596f2a78707 mojo::core::NodeController::ForwardEvent() #10 0x5596f6c728d2 mojo::core::ports::Node::SendUserMessageInternal() #11 0x5596f6c72720 mojo::core::ports::Node::SendUserMessage() #12 0x5596f2a768e1 mojo::core::NodeController::SendUserMessage() #13 0x5596f2a71afe mojo::core::MessagePipeDispatcher::WriteMessage() #14 0x5596f2a6744c mojo::core::Core::WriteMessage() #15 0x5596f579b850 mojo::Connector::Accept() #16 0x5596f579d9db mojo::InterfaceEndpointClient::SendMessageWithResponder() #17 0x5596f579dd5f mojo::InterfaceEndpointClient::AcceptWithResponder() #18 0x5596f26f4662 content::mojom::ChildHistogramFetcherProxy::GetChildNonPersistentHistogramData() #19 0x5596f2d9b2aa content::HistogramController::GetHistogramData() #20 0x5596f2d9c905 content::HistogramSynchronizer::RegisterAndNotifyAllProcesses() #21 0x5596f2d9ca56 content::FetchHistogramsAsynchronously() #22 0x5596f4dd4781 content::FetchHistogramsFromChildProcesses() #23 0x5596f52f70fa subresource_redirect::RetryForHistogramUntilCountReached() #24 0x5596f0f9d3d1 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest_TestCancelBeforeImageLoadForLoggedInSite_Test::RunTestOnMainThread() #25 0x5596f4dcb6e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x5596f491e0aa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x5596f491cea5 ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x5596f2c33516 content::BrowserMainLoop::PreMainMessageLoopRun() #29 0x5596f30a1833 content::StartupTaskRunner::RunAllTasksNow() #30 0x5596f2c324f9 content::BrowserMainLoop::CreateStartupTasks() #31 0x5596f2c34e78 content::BrowserMainRunnerImpl::Initialize() #32 0x5596f2c30c28 content::BrowserMain() #33 0x5596f373dc93 content::ContentMainRunnerImpl::RunBrowser() #34 0x5596f373d886 content::ContentMainRunnerImpl::Run() #35 0x5596f373ad84 content::RunContentProcess() #36 0x5596f373b70c content::ContentMain() #37 0x5596f4dcac68 content::BrowserTestBase::SetUp() #38 0x5596f47d0edb InProcessBrowserTest::SetUp() #39 0x5596f0f9e065 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest::SetUp() #40 0x5596f1cf66e8 testing::Test::Run() #41 0x5596f1cf757f testing::TestInfo::Run() #42 0x5596f1cf7f57 testing::TestSuite::Run() #43 0x5596f1d05777 testing::internal::UnitTestImpl::RunAllTests() #44 0x5596f1d050df testing::UnitTest::Run() #45 0x5596f48d0724 base::TestSuite::Run() #46 0x5596f47b935f ChromeTestSuiteRunner::RunTestSuite() #47 0x5596f4dfaab7 content::LaunchTests() #48 0x5596f47b9632 LaunchChromeTests() #49 0x5596f47b6df4 main #50 0x7f128ca3f840 __libc_start_main #51 0x5596f008526a _start [ RUN ] SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite Original change's description: > [Safe Browsing] Abstract signin dep from RealTimeUrlLookupService > > This CL continues with the abstraction of dependencies on signin and > sync from //components/safe_browsing's access token fetching flow in > order to enable reuse by WebLayer. The concrete step taken here is to > abstract the dependencies on > //components/safe_browsing/core/browser/sync from > RealTimeUrlLookupService, passing these dependencies in via the > constructor. There are no behavioral changes in this CL: > - //chrome and //ios/chrome's factories glue the relevant parameters > from //components/safe_browsing/core/browser/sync > - //weblayer's factory passes in values for the parameters such that > access token fetching for URL lookups continues to be disabled in > WebLayer > > Followup work will bring up support for access token fetching in > WebLayer. > > Bug: 1080748 > Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842942} TBR=blundell@chromium.org,sdefresne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,xinghuilu@chromium.org Change-Id: I9aa193871848c7e07353bb2bb428a2a39ba5cb00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627391 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842980}
pull bot
pushed a commit
that referenced
this pull request
Jan 19, 2021
This reverts commit 640009e. Reason for revert: The original CL looks wrongly identified as a cause of test breakage. Even without this CL, the test is flaky. Original change's description: > Revert "Support multiple receivers for Cros APIs." > > This reverts commit 8aca3b4. > > Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview > > [ RUN ] WindowOpenApiTest.PopupBlockingExtension > 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. > 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag > 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. > 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user > 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. > 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. > 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry > 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. > 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found > 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files > 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als > 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. > 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files > 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure > Expected equality of these values: > num_browsers > Which is: 4 > chrome::GetBrowserCount(browser->profile()) > Which is: 2 > Google Test trace: > ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 > Stack trace: > #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() > #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() > #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() > #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() > #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #6 0x563646f2068c base::internal::Invoker<>::RunOnce() > #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv > #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() > #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() > #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() > #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() > #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() > #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv > #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() > #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() > #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() > #20 0x7fb5dc82a804 content::BrowserMain() > #21 0x7fb5de9aae56 content::RunBrowserProcessMain() > #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() > #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() > #24 0x7fb5de9a9106 content::RunContentProcess() > #25 0x7fb5de9a9a3d content::ContentMain() > #26 0x563646f1cb13 content::BrowserTestBase::SetUp() > #27 0x563645acb283 InProcessBrowserTest::SetUp() > #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() > #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() > #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() > > > > Original change's description: > > Support multiple receivers for Cros APIs. > > > > With this CL, most of Cros API starts to support multiple receivers. > > AshChromeService and LacrosChromeService are exceptions. > > > > Bug: 1148448 > > Test: Build and run Lacros on a DUT. > > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#842869} > > TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1148448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842943} TBR=jamescook@chromium.org,hidehiko@chromium.org,kolos@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148448 Change-Id: Ic2ec65fa476b9b67a705497aad1cf3f1bffa0da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633482 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844778}
pull bot
pushed a commit
that referenced
this pull request
Apr 19, 2021
This reverts commit 7ae3611. Reason for revert: cast_shell+browsertests failing on Cast [Audio] Linux First failure https://ci.chromium.org/ui/p/chromium/builders/ci/Cast%20Audio%20Linux/103652/overview Example crash stack BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x55bcce76b6a9 base::debug::CollectStackTrace() #1 0x55bcce6dfda3 base::debug::StackTrace::StackTrace() #2 0x55bcd0fb5cac content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fd872d664c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x55bcccba88b0 _ZNSt3__17find_ifINS_11__wrap_iterIPKN4base8internal24UncheckedObserverAdapterEEEZNS3_23ProjectedUnaryPredicateIZNKS2_12ObserverListIN3net16MDnsListenerImplELb0ELb1ES4_E11HasObserverEPKSB_EUlRKT_E_NS2_8identityEEEDaRSF_RT0_EUlOSF_E_EESF_SF_SF_SL_ #5 0x55bcccba889e _ZN4base6ranges7find_ifINSt3__111__wrap_iterIPKNS_8internal24UncheckedObserverAdapterEEEZNKS_12ObserverListIN3net16MDnsListenerImplELb0ELb1ES5_E11HasObserverEPKSB_EUlRKT_E_NS_8identityENS2_26random_access_iterator_tagEEEDaSF_SF_T0_T1_ #6 0x55bcccba6dca base::ObserverList<>::RemoveObserver() #7 0x55bccd28a44e chromecast::DisplayConfiguratorObserver::~DisplayConfiguratorObserver() #8 0x55bccd26fbcd chromecast::shell::CastBrowserMainParts::~CastBrowserMainParts() #9 0x55bccd26fc7c chromecast::shell::CastBrowserMainParts::~CastBrowserMainParts() #10 0x55bccd3a6836 content::BrowserMainLoop::~BrowserMainLoop() #11 0x55bccd3a6920 content::BrowserMainLoop::~BrowserMainLoop() #12 0x55bccd3a9c06 content::BrowserMainRunnerImpl::Shutdown() #13 0x55bccd3a65aa content::BrowserMain() #14 0x55bcce68bc80 content::RunBrowserProcessMain() #15 0x55bcce68c9a6 content::ContentMainRunnerImpl::RunBrowser() #16 0x55bcce68c62c content::ContentMainRunnerImpl::Run() #17 0x55bcce68ad93 content::RunContentProcess() #18 0x55bcce68b49a content::ContentMain() #19 0x55bcd0fb50e1 content::BrowserTestBase::SetUp() #20 0x55bccc9fdf90 chromecast::WebviewTest::SetUp() #21 0x55bcce69a89c testing::Test::Run() #22 0x55bcce69adb8 testing::TestInfo::Run() #23 0x55bcce69b27d testing::TestSuite::Run() #24 0x55bcce6a2233 testing::internal::UnitTestImpl::RunAllTests() #25 0x55bcce6a1f87 testing::UnitTest::Run() #26 0x55bcd0fa57ef base::TestSuite::Run() #27 0x55bccc9de2a4 chromecast::shell::CastTestLauncherDelegate::RunTestSuite() #28 0x55bcd0fb930e content::LaunchTests() #29 0x55bccc9de23c main #30 0x7fd872d51840 __libc_start_main #31 0x55bccc9de12a _start Original change's description: > Add display change observer. > > Centralize the logic to force a repaint post display changes in an > observer. This way the complexity of refreshing the display is > handled in the observer rather than in every piece of code that > needs to update the display state. > > Bug: b/180040068 > Test: Ran cast_shell on the desktop to verify there are no crashes > Change-Id: I022850322c8b9177463bdc0526121016ebf0f330 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727577 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Shiv Sakhuja <shivsak@google.com> > Cr-Commit-Position: refs/heads/master@{#873512} Bug: b/180040068 Change-Id: Id01a6e537f2285a9c35ce90acc9eba81b0ea6c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2835019 Owners-Override: Olga Sharonova <olka@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#873746}
pull bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
This reverts commit 59bae41. Reason for revert: Broken on Linux Chromium OS ASan LSan Tests (1) https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/39927/ <div><pre>[ RUN ] PrerenderBrowserTest.PrerenderBlankIframe 2021-04-26T19:40:32.221868Z INFO content_browsertests[5132:5132]: [content_main_runner_impl.cc(1077)] Chrome is running in full browser mode. DevTools listening on ws://127.0.0.1:36659/devtools/browser/21b92715-e642-49fe-98ef-4b69eea3f8b2 2021-04-26T19:40:32.847975Z ERROR content_browsertests[5132:5132]: [browser_test_utils.cc(837)] No committed entry. 2021-04-26T19:40:34.078783Z WARNING content_browsertests[5132:5132]: [render_frame_host_impl.cc(977)] InterfaceRequest was dropped, the document is no longer active: blink.mojom.AppCacheBackend 2021-04-26T19:40:34.281683Z FATAL content_browsertests[5285:1]: [document.cc(8103)] Check failed: is_prerendering_. #0 0x55b148a133cb in backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4205:13 #1 0x55b1586bd249 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x55b1583f3f03 in StackTrace ./../../base/debug/stack_trace.cc:198:12 #3 0x55b1583f3f03 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:195:28 #4 0x55b158448eb2 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:589:29 #5 0x55b15844adde in logging::LogMessage::~LogMessage() ./../../base/logging.cc:583:27 #6 0x55b15e0d8fa6 in blink::Document::ActivateForPrerendering() ./../../third_party/blink/renderer/core/dom/document.cc:8103:3 #7 0x55b15392c60c in Run ./../../base/callback.h:101:12 #8 0x55b15392c60c in RunInternal ./../../third_party/blink/renderer/platform/wtf/functional.h:221:33 #9 0x55b15392c60c in WTF::ThreadCheckingCallbackWrapper<base::OnceCallback<void ()>, void ()>::Run() ./../../third_party/blink/renderer/platform/wtf/functional.h:206:12 #10 0x55b1585795fa in Run ./../../base/callback.h:101:12 #11 0x55b1585795fa in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:173:33 #12 0x55b1585e197a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:351:25 #13 0x55b1585e071f in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:264:36 #14 0x55b158468934 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:39:55 #15 0x55b1585e36d9 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:460:12 #16 0x55b158503839 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #17 0x55b1671389dc in content::RendererMain(content::MainFunctionParams const&) ./../../content/renderer/renderer_main.cc:261:16 #18 0x55b15003c45a in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:572:14 #19 0x55b15003f244 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:958:10 #20 0x55b150039a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #21 0x55b150039f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #22 0x55b157438e9c in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:372:12 #23 0x55b1572a1d21 in main ./../../content/test/content_test_launcher.cc:91:10 #24 0x7f772d1ad840 in __libc_start_main ??:0:0 #25 0x55b1489dcaaa in _start ??:0:0 Task trace: #0 0x55b15ea7ff11 in blink::LocalFrame::ActivateForPrerendering() ./../../third_party/blink/renderer/core/frame/local_frame.cc:3766:18 #1 0x55b15780d116 in IPC::(anonymous namespace)::ChannelAssociatedGroupController::Accept(mojo::Message*) ./../../ipc/ipc_mojo_bootstrap.cc:904:13 IPC message handler context: 0xA60C9B35 Received signal 6 #0 0x55b148a133cb in backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4205:13 #1 0x55b1586bd249 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x55b1583f3f03 in StackTrace ./../../base/debug/stack_trace.cc:198:12 #3 0x55b1583f3f03 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:195:28 #4 0x55b1586bbd47 in base::debug::(anonymous namespace)::StackDumpSignalHandler(int, siginfo_t*, void*) ./../../base/debug/stack_trace_posix.cc:345:3 #5 0x7f7730097390 in __funlockfile ??:? #6 0x7f7730097390 in ?? ??:0 #7 0x7f772d1c2438 in raise ??:0:0 #8 0x7f772d1c403a in abort ??:0:0 #9 0x55b1586b9f6a in base::debug::BreakDebugger() ./../../base/debug/debugger_posix.cc:326:3 #10 0x55b158449863 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:891:7 #11 0x55b15844adde in logging::LogMessage::~LogMessage() ./../../base/logging.cc:583:27 #12 0x55b15e0d8fa6 in blink::Document::ActivateForPrerendering() ./../../third_party/blink/renderer/core/dom/document.cc:8103:3 #13 0x55b15392c60c in Run ./../../base/callback.h:101:12 #14 0x55b15392c60c in RunInternal ./../../third_party/blink/renderer/platform/wtf/functional.h:221:33 #15 0x55b15392c60c in WTF::ThreadCheckingCallbackWrapper<base::OnceCallback<void ()>, void ()>::Run() ./../../third_party/blink/renderer/platform/wtf/functional.h:206:12 #16 0x55b1585795fa in Run ./../../base/callback.h:101:12 #17 0x55b1585795fa in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:173:33 #18 0x55b1585e197a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:351:25 #19 0x55b1585e071f in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:264:36 #20 0x55b158468934 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:39:55 #21 0x55b1585e36d9 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:460:12 #22 0x55b158503839 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #23 0x55b1671389dc in content::RendererMain(content::MainFunctionParams const&) ./../../content/renderer/renderer_main.cc:261:16 #24 0x55b15003c45a in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:572:14 #25 0x55b15003f244 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:958:10 #26 0x55b150039a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #27 0x55b150039f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #28 0x55b157438e9c in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:372:12 #29 0x55b1572a1d21 in main ./../../content/test/content_test_launcher.cc:91:10 #30 0x7f772d1ad840 in __libc_start_main ??:0:0 #31 0x55b1489dcaaa in _start ??:0:0 r8: 0000000000003000 r9: 00000feee51a2840 r10: 0000000000000008 r11: 0000000000000202 r12: 00000fef65260c00 r13: 00000feee5268e48 r14: 00007f7729347230 r15: 00007f77293472b0 di: 0000000000000001 si: 0000000000000001 bp: 00007ffcf0a97110 bx: 00007ffcf0a97120 dx: 0000000000000006 ax: 0000000000000000 cx: 00007f772d1c2438 sp: 00007ffcf0a96fd8 ip: 00007f772d1c2438 efl: 0000000000000202 cgf: 002b000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(EXIT_FAILURE). Core file will not be generated. ../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure Failed Unexpected termination of a renderer process; status: 1, exit_code: 256 Stack trace: #0 0x556300884c70 in content::NoRendererCrashesAssertion::Observe(int, content::NotificationSource const&, content::NotificationDetails const&) ./../../content/public/test/no_renderer_crashes_assertion.cc:101:5 #1 0x5562fe8a511c in content::NotificationServiceImpl::Notify(int, content::NotificationSource const&, content::NotificationDetails const&) ./../../content/browser/notification_service_impl.cc:123:16 #2 0x5562fed854dc in content::RenderProcessHostImpl::ProcessDied(bool, content::ChildProcessTerminationInfo*) ./../../content/browser/renderer_host/render_process_host_impl.cc:4468:35 #3 0x5562fed84d46 in content::RenderProcessHostImpl::FastShutdownIfPossible(unsigned long, bool) ./../../content/browser/renderer_host/render_process_host_impl.cc:3480:3 #4 0x5563007096fd in content::ContentBrowserTest::PostRunTestOnMainThread() ./../../content/public/test/content_browser_test.cc:159:26 #5 0x55630081ddfd in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:833:3 #6 0x5562f23f595a in base::OnceCallback<void ()>::Run() && ./../../base/callback.h:101:12 #7 0x556300a86450 in content::ShellBrowserMainParts::PreMainMessageLoopRun() ./../../content/shell/browser/shell_browser_main_parts.cc:200:37 #8 0x5562fe06aed1 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:961:28 #9 0x5562f78e60d9 in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:101:12 #10 0x5562ff118ca5 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 #11 0x5562fe06a59d in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:869:25 #12 0x5562fe0715f3 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:131:15 #13 0x5562fe066342 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #14 0x5562f94bb63d in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:598:10 #15 0x5562f94bded9 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1081:10 #16 0x5562f94bd258 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:956:12 #17 0x5562f94b7a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #18 0x5562f94b7f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #19 0x55630081c4bd in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:696:3 2021-04-26T19:40:34.692356Z WARNING content_browsertests[5132:5174]: [discardable_shared_memory_manager.cc(432)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [ FAILED ] PrerenderBrowserTest.PrerenderBlankIframe, where TypeParam = and GetParam() = (2830 ms) Original change's description: > Prerender: Enable PrerenderBrowserTest.PrerenderBlankIframe > > To sheriffs: Feel free to revert this CL if the test is flaky. > > The CL author tried to reproduce this on local environments but > failed. For further investigation, this CL enables the test again to see > how it works on the try bots. > > Bug: 1185965 > Change-Id: Ie7f65ef094a815e72b93091c8b3d0ab9b361e593 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2850329 > Reviewed-by: Lingqi Chi <lingqi@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#876111} Bug: 1185965 Change-Id: I245d5e5f2715c75ead3a50389cbd0e9a4ad49aed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2853351 Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Owners-Override: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#876535}
pull bot
pushed a commit
that referenced
this pull request
Sep 25, 2021
This reverts commit 77e9679. Reason for revert: Likely cause of failure Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" The failure is a crash in browser_tests. This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. Here is the first failure as an example: Retrying 1 test (retry #0) [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x556151f72449 base::debug::CollectStackTrace() #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() #9 0x5561502b8919 content::Navigator::DidNavigate() #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x5561530201e0 mojo::MessageDispatcher::Accept() #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x55615301e323 base::internal::Invoker<>::RunOnce() #20 0x556151f35f23 base::TaskAnnotator::RunTask() #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x556151fa9c4b base::MessagePumpLibevent::Run() #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x556151f18c1b base::RunLoop::Run() #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() #38 0x556150036912 content::BrowserMain() #39 0x556150bf6aed content::RunBrowserProcessMain() #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() #41 0x556150bf752e content::ContentMainRunnerImpl::Run() #42 0x556150bf5b38 content::RunContentProcess() #43 0x556150bf5c08 content::ContentMain() #44 0x5561525e3543 content::BrowserTestBase::SetUp() #45 0x556151ec12c1 InProcessBrowserTest::SetUp() #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x55614f308e8f testing::Test::Run() #48 0x55614f3097c5 testing::TestInfo::Run() #49 0x55614f309f21 testing::TestSuite::Run() #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() #51 0x55614f31338b testing::UnitTest::Run() #52 0x556151fd7ff2 base::TestSuite::Run() #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x556152613c1f content::LaunchTests() #55 0x556151e98224 LaunchChromeTests() #56 0x556151e9638b main #57 0x7f7dd56c4bf7 __libc_start_main #58 0x55614cca11ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 Here is the fourth: (different test in the same suite, different stack trace): [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x564f24b8af29 base::debug::CollectStackTrace() #1 0x564f24af2843 base::debug::StackTrace::StackTrace() #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() #9 0x564f22ed15f9 content::Navigator::DidNavigate() #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x564f24bc28cb base::MessagePumpLibevent::Run() #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x564f24b316fb base::RunLoop::Run() #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() #28 0x564f2522df45 content::RunAllPendingInMessageLoop() #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() #38 0x564f22c4f832 content::BrowserMain() #39 0x564f2380f5bd content::RunBrowserProcessMain() #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() #42 0x564f2380e608 content::RunContentProcess() #43 0x564f2380e6d8 content::ContentMain() #44 0x564f251fc233 content::BrowserTestBase::SetUp() #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x564f21f21e4f testing::Test::Run() #48 0x564f21f22785 testing::TestInfo::Run() #49 0x564f21f22ee1 testing::TestSuite::Run() #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() #51 0x564f21f2c34b testing::UnitTest::Run() #52 0x564f24bf0c72 base::TestSuite::Run() #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x564f2522c62f content::LaunchTests() #55 0x564f24ab0cf4 LaunchChromeTests() #56 0x564f24aaee5b main #57 0x7f03d336fbf7 __libc_start_main #58 0x564f1f8b94ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 Original change's description: > Privatise unnecessarily public current_input_method in > InputMethodManagerImpl::StateImpl. > > This involves replacing some direct pokes of current_input_method > with public GetCurrentInputMethod() that employs a fallback onto > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > blank. This should be more reasonable and consistent. > > Bug: 1134465 > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924702} Bug: 1134465 Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 Auto-Submit: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#924810}
pull bot
pushed a commit
that referenced
this pull request
Sep 28, 2021
This reverts commit 37ea471. Reason for revert: Reverted CL is unrelated to the cited "reason for revert". Original change's description: > Revert "Privatise unnecessarily public current_input_method in" > > This reverts commit 77e9679. > > Reason for revert: > Likely cause of failure > Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" > > The failure is a crash in browser_tests. > > This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. > > Here is the first failure as an example: > Retrying 1 test (retry #0) > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed > 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als > 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x556151f72449 base::debug::CollectStackTrace() > #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() > #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() > #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() > #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() > #9 0x5561502b8919 content::Navigator::DidNavigate() > #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() > #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() > #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x5561530201e0 mojo::MessageDispatcher::Accept() > #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x55615301e323 base::internal::Invoker<>::RunOnce() > #20 0x556151f35f23 base::TaskAnnotator::RunTask() > #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x556151fa9c4b base::MessagePumpLibevent::Run() > #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x556151f18c1b base::RunLoop::Run() > #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() > #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() > #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() > #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() > #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() > #38 0x556150036912 content::BrowserMain() > #39 0x556150bf6aed content::RunBrowserProcessMain() > #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() > #41 0x556150bf752e content::ContentMainRunnerImpl::Run() > #42 0x556150bf5b38 content::RunContentProcess() > #43 0x556150bf5c08 content::ContentMain() > #44 0x5561525e3543 content::BrowserTestBase::SetUp() > #45 0x556151ec12c1 InProcessBrowserTest::SetUp() > #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x55614f308e8f testing::Test::Run() > #48 0x55614f3097c5 testing::TestInfo::Run() > #49 0x55614f309f21 testing::TestSuite::Run() > #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() > #51 0x55614f31338b testing::UnitTest::Run() > #52 0x556151fd7ff2 base::TestSuite::Run() > #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x556152613c1f content::LaunchTests() > #55 0x556151e98224 LaunchChromeTests() > #56 0x556151e9638b main > #57 0x7f7dd56c4bf7 __libc_start_main > #58 0x55614cca11ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 > > Here is the fourth: (different test in the same suite, different stack trace): > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff > 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB > 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als > 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x564f24b8af29 base::debug::CollectStackTrace() > #1 0x564f24af2843 base::debug::StackTrace::StackTrace() > #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() > #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() > #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() > #9 0x564f22ed15f9 content::Navigator::DidNavigate() > #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() > #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() > #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() > #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() > #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() > #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x564f24bc28cb base::MessagePumpLibevent::Run() > #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x564f24b316fb base::RunLoop::Run() > #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() > #28 0x564f2522df45 content::RunAllPendingInMessageLoop() > #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() > #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() > #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() > #38 0x564f22c4f832 content::BrowserMain() > #39 0x564f2380f5bd content::RunBrowserProcessMain() > #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() > #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() > #42 0x564f2380e608 content::RunContentProcess() > #43 0x564f2380e6d8 content::ContentMain() > #44 0x564f251fc233 content::BrowserTestBase::SetUp() > #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() > #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x564f21f21e4f testing::Test::Run() > #48 0x564f21f22785 testing::TestInfo::Run() > #49 0x564f21f22ee1 testing::TestSuite::Run() > #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() > #51 0x564f21f2c34b testing::UnitTest::Run() > #52 0x564f24bf0c72 base::TestSuite::Run() > #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x564f2522c62f content::LaunchTests() > #55 0x564f24ab0cf4 LaunchChromeTests() > #56 0x564f24aaee5b main > #57 0x7f03d336fbf7 __libc_start_main > #58 0x564f1f8b94ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 > > Original change's description: > > Privatise unnecessarily public current_input_method in > > InputMethodManagerImpl::StateImpl. > > > > This involves replacing some direct pokes of current_input_method > > with public GetCurrentInputMethod() that employs a fallback onto > > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > > blank. This should be more reasonable and consistent. > > > > Bug: 1134465 > > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > > Reviewed-by: Keith Lee <keithlee@chromium.org> > > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#924702} > > Bug: 1134465 > Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Owners-Override: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924810} Bug: 1134465 Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#925158}
pull bot
pushed a commit
that referenced
this pull request
Oct 18, 2021
This reverts commit 842626c. Reason for revert: [sheriff] suspected to cause multiple failures in SafetyTipPageInfoBubbleViewBrowserTests on linux-ubsan-vptr: https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr/6970 Sample failure: [ RUN ] All/SafetyTipPageInfoBubbleViewBrowserTest.BubbleWaitsForVisible/1 [...] ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23: runtime error: downcast of address 0x180601885e00 which does not point to an object of type 'PageInfoBubbleView' 0x180601885e00: note: object is of type 'PageInfoNewBubbleView' 00 00 00 00 18 70 11 10 50 56 00 00 80 68 50 01 06 18 00 00 b8 00 00 00 30 00 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'PageInfoNewBubbleView' #0 0x564ffa77d440 in SafetyTipPageInfoBubbleViewBrowserTest::CheckPageInfoShowsSafetyTipInfo(Browser*, security_state::SafetyTipStatus, GURL const&) chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 #1 0x564ffa788397 in SafetyTipPageInfoBubbleViewBrowserTest_BubbleWaitsForVisible_Test::RunTestOnMainThread() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:837:3 #2 0x565002ae1026 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:868:7 #3 0x565001aae15a in Run base/callback.h:142:12 #4 0x565001aae15a in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1745:38 #5 0x565001aaba50 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1083:18 #6 0x564ffd8e2f00 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:957:28 #7 0x564ffe307f82 in Run base/callback.h:142:12 #8 0x564ffe307f82 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:41:29 #9 0x564ffd8e2368 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:865:25 #10 0x564ffd8e889c in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:131:15 #11 0x564ffd8dec1e in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:45:32 #12 0x564fff2a06e8 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:641:10 #13 0x564fff2a2e90 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) content/app/content_main_runner_impl.cc:1137:10 #14 0x564fff2a1f18 in content::ContentMainRunnerImpl::Run(bool) content_main_runner_impl.cc #15 0x564fff29dde0 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) content_main.cc #16 0x564fff29e7dd in content::ContentMain(content::ContentMainParams const&) content_main.cc #17 0x565002adfcff in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:712:3 #18 0x5650018271c4 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:401:20 #19 0x564ffa79d759 in SafetyTipPageInfoBubbleViewBrowserTest::SetUp() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:306:27 #20 0x564ffb8f8c7d in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2701:3 #21 0x564ffb8fa600 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2885:11 #22 0x564ffb8fc1bb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3044:30 #23 0x564ffb9115ca in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5903:44 #24 0x564ffb90fd8c in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5470:10 #25 0x565001a12e28 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #26 0x565001a12e28 in base::TestSuite::Run() base/test/test_suite.cc:445:16 #27 0x5650017d0bac in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:88:22 #28 0x5650017d0c1b in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome_test_launcher.cc #29 0x565002b8529b in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:409:31 #30 0x5650017d11b1 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:284:10 #31 0x5650017c9dcc in main chrome/test/base/browser_tests_main.cc:61:10 #32 0x7fc242b01bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6) #33 0x564ff76da7e9 in _start (/b/s/w/ir/out/Release/browser_tests+0xe8af7e9) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 in Original change's description: > Enable PageInfoV2Desktop by default > > Enable flag and remove testing config. > > Bug: 1188101 > Change-Id: Ifd839436f3d4c0127d15b449bbca84855ccd858f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217207 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Cr-Commit-Position: refs/heads/main@{#931972} Bug: 1188101 Change-Id: Ic51b9fdc730b7046e24b4d394248218b86eef09d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226638 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932067}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )