Update latest master #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/mojo/device_struct_traits_unittest.cc MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=meacer@chromium.org Change-Id: I56dcf5a81b19ec45040fba583bd38112eef247c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649511 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#667234}
This CL is fixing a cause of flaky tests when re-ordering tests execution.
SystemFont is keeping two static callbacks that modify metrics of the
system fonts. Typically, these callbacks are set up before the SystemFont
class is instantiated. A DCHECK was ensuring this.
We are able to repro flaky test by changing tests order or
by specifying test filters (see below).
A DCHECK fails because it is possible in unittests to set the
callbacks after the SystemFont is instantiated. The problem is
that callbacks are static variables that keep states
between two tests.
I believe other fancy bugs may be hidden by this bug since system fonts
may be scaled based on the callback left by a previous test.
This CL is adding the required logic to reset the system fonts.
R=robliao@chromium.org,asvitkine@chromium.org
CC=benck@google.com
Bug: 944227
C:\src\chromium\src>out\build\gfx_unittests --gtest_filter=FontListTest.Fonts_DeriveWithHeightUpperBound:RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs:SystemFontsWinTest.AdjustFontSize
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = FontListTest.Fonts_DeriveWithHeightUpperBound:RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs:SystemFontsWinTest.AdjustFontSize
[==========] Running 3 tests from 3 test suites.
[----------] Global test environment set-up.
[----------] 1 test from FontListTest
[ RUN ] FontListTest.Fonts_DeriveWithHeightUpperBound
[ OK ] FontListTest.Fonts_DeriveWithHeightUpperBound (13 ms)
[----------] 1 test from FontListTest (14 ms total)
[----------] 1 test from RenderTextTest
[ RUN ] RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs
[ OK ] RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs (32 ms)
[----------] 1 test from RenderTextTest (34 ms total)
[----------] 1 test from SystemFontsWinTest
[ RUN ] SystemFontsWinTest.AdjustFontSize
[26180:21012:0605/182005.067:1151493921:FATAL:system_fonts_win.cc(100)] Check failed: !SystemFonts::IsInitialized().
base::debug::CollectStackTrace [0x00007FFB78F6D7E0+48] (C:\src\chromium\src\base\debug\stack_trace_win.cc:284)
base::debug::StackTrace::StackTrace [0x00007FFB78F6C950+80] (C:\src\chromium\src\base\debug\stack_trace.cc:206)
base::debug::StackTrace::StackTrace [0x00007FFB78F6C8D8+40] (C:\src\chromium\src\base\debug\stack_trace.cc:203)
logging::LogMessage::~LogMessage [0x00007FFB78FBC78F+143] (C:\src\chromium\src\base\logging.cc:613)
gfx::win::`anonymous namespace'::SystemFonts::SetGetMinimumFontSizeCallback [0x00007FFB834E3E41+161] (C:\src\chromium\src\ui\gfx\system_fonts_win.cc:101)
gfx::win::SetGetMinimumFontSizeCallback [0x00007FFB834E3D93+19] (C:\src\chromium\src\ui\gfx\system_fonts_win.cc:222)
gfx::win::SystemFontsWinTest_AdjustFontSize_Test::TestBody [0x00007FF7F312886E+46] (C:\src\chromium\src\ui\gfx\system_fonts_win_unittest.cc:30)
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00007FF7F31A50DF+79] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2507)
testing::Test::Run [0x00007FF7F31A5049+185] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2529)
testing::TestInfo::Run [0x00007FF7F31A5D11+225] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2701)
testing::TestSuite::Run [0x00007FF7F31A69D6+278] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2827)
testing::internal::UnitTestImpl::RunAllTests [0x00007FF7F31B0EE9+1113] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:5284)
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00007FF7F31B0A75+85] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2505)
testing::UnitTest::Run [0x00007FF7F31B08BC+300] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:4873)
RUN_ALL_TESTS [0x00007FF7F32463F1+17] (C:\src\chromium\src\third_party\googletest\src\googletest\include\gtest\gtest.h:2453)
base::TestSuite::Run [0x00007FF7F32459D4+164] (C:\src\chromium\src\base\test\test_suite.cc:316)
base::internal::FunctorTraits<int (base::TestSuite::*)(),void>::Invoke<int (base::TestSuite::*)(),(anonymous namespace)::GfxTestSuite *> [0x00007FF7F2E1516D+29] (C:\src\chromium\src\base\bind_internal.h:499)
base::internal::InvokeHelper<0,int>::MakeItSo<int (base::TestSuite::*)(),(anonymous namespace)::GfxTestSuite *> [0x00007FF7F2E150E4+52] (C:\src\chromium\src\base\bind_internal.h:599)
base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(),base::internal::UnretainedWrapper<(anonymous namespace)::GfxTestSuite> >,int ()>::RunImpl<int (base::TestSuite::*)(),std::__1::tuple<base::internal::UnretainedWrapper<(anonymous [0x00007FF7F2E15068+88] (C:\src\chromium\src\base\bind_internal.h:672)
base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(),base::internal::UnretainedWrapper<(anonymous namespace)::GfxTestSuite> >,int ()>::RunOnce [0x00007FF7F2E14F3E+78] (C:\src\chromium\src\base\bind_internal.h:641)
base::OnceCallback<int ()>::Run [0x00007FF7F324E611+97] (C:\src\chromium\src\base\callback.h:98)
base::`anonymous namespace'::LaunchUnitTestsInternal [0x00007FF7F324BCE2+418] (C:\src\chromium\src\base\test\launcher\unit_test_launcher.cc:158)
base::LaunchUnitTests [0x00007FF7F324BAFD+253] (C:\src\chromium\src\base\test\launcher\unit_test_launcher.cc:492)
main [0x00007FF7F2E14AAA+138] (C:\src\chromium\src\ui\gfx\test\run_all_unittests.cc:81)
invoke_main [0x00007FF7F33739E4+52] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79)
__scrt_common_main_seh [0x00007FF7F3373B1E+302] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
__scrt_common_main [0x00007FF7F3373B9E+14] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331)
mainCRTStartup [0x00007FF7F3373BB9+9] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17)
BaseThreadInitThunk [0x00007FFBB44837E4+20]
Backtrace:
Change-Id: I23109356db89c48c89c51b1db78cbb0c04367e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647192
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667235}
IWYU after commit b8fdf46 ("Consolidate code to set device::Gamepad id field"), which also fixes the libstdc++ build: ../../device/gamepad/public/cpp/gamepad.cc:28:3: error: use of undeclared identifier 'memset'; did you mean 'wmemset'? memset(id, 0, sizeof(id)); Bug: 957519 Change-Id: I5b5a8d9d7bc0de6e5b32ddd29ce0c5c17c883ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649496 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#667236}
The suggestion to powerwash only shows up when there's a firmware update, which is relatively rare. Default to hide this line item. BUG=925279 Change-Id: I690010a7b68bd6cc108e6c2ad420d2b69d7f3dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646649 Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#667237}
CString is being removed. Also, this was sort of relying on an implementation detail of CString, and this fixes that. Bug: 950077 Change-Id: I4fab8de0ef8f3202c0144dcea8eeedf89e90ce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648712 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#667238}
Currently, changes by setRootId() in Tab are not reflected in TabState and will be lost when tabs are restored. This CL fixes this issue. Bug: 971327 Change-Id: Ia7daf36d4feb23f79b9c364d1232090671a7b9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647134 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667239}
… re-added unittests (only for Linux)" This is a reland of 4e636d5 Original change's description: > Changed the way the Query URL is matched in the JSON file and re-added unittests > (only for Linux) > > Bug: 954379 > Change-Id: I0fa6d80dd56cc239ed2eaa554c89b0700950acf6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574899 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656495} Bug: 954379 Change-Id: Ie4f82545a4828f757461f81c1296497105d60547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641987 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667240}
Add CloudTokenData to WalletMaskedCreditCard. This is a part of b/133228158. Change-Id: I18a8d58d0ef42921fa47158c0fc519de8e88c60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647377 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#667241}
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=bialpio@chromium.org Change-Id: I39077687bd9eadfa2b1ce2c05b00b3687d2b8aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648268 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#667242}
SCREEN_OOBE_WELCOME was (mostly) removed in https://chromium-review.googlesource.com/c/chromium/src/+/1520310/8/ui/login/display_manager.js except for one occurrence. This occurrence prevents the ctrl+alt+E key combination to work on network and eula screen and also produces error log output. This CL removes the remaining occurrence. This change is safe since its old behavior was already replaced by attributes.postponeEnrollmentAllowed, which is true for the welcome screen. Bug: 965391 Change-Id: Ie8d80c25b8c240f1f5d36ab7c28d15143e48474d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640407 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#667243}
Change-Id: I29fce7fafe5ab0923eed465fb58fcf5def079689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1355195 Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#667244}
while on chrome:// URLs This allows us to use this mechanism in CSS: @media (prefers-color-scheme: dark) { } to vary styles for Chrome web UI in dark mode while also disabling via feature on certain platforms. This unblocks us from migrating to the @media query (from the existing [dark] attribute syntax) and later removing a bit of JS/C++ custom code in favor of simply using the web platform. R=futhark@chromium.org BUG=965811 Change-Id: I79f4582ce21661d7ba2f6a33f3f054f5ff62d0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626024 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#667245}
…API.""" This is a reland of a2d78e6 Original change's description: > Reland "Reland "Added handling of large requests to Autofill API."" > > This is a reland of 4149e2e > > Original change's description: > > Reland "Added handling of large requests to Autofill API." > > > > This is a reland of c6677df > > > > Original change's description: > > > Added handling of large requests to Autofill API. > > > > > > Increased the limit of Query GET requests, added a POST Query fallback, and > > > added UMA metrics to keep track of URL length and associated events. > > > > > > This change might be needed when metadata is enabled. > > > > > > Bug: 948862 > > > Change-Id: If0934a685758ab8999ceea6ce22a27499e4f772f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549615 > > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#656080} > > > > Bug: 948862 > > Change-Id: I29eee8f16ae6c3775eb31e8e95d4a289c31f1485 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594618 > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > Cr-Commit-Position: refs/heads/master@{#656452} > > Bug: 948862 > Change-Id: I8fdc33c0e496862232dfed6e13349e55fbd36e07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594190 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Commit-Queue: Vincent Boisselle <vincb@google.com> > Cr-Commit-Position: refs/heads/master@{#662780} Bug: 948862 Change-Id: Ie27a8325eaba03a2158e3a441436fcebcab1a56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642815 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#667246}
Bug: 883163 Change-Id: I49b5c18601bb53f3f199aff9363d84a0ae1f7dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644597 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#667247}
This makes the generated build files deterministic with respect to build path. Bug: 871574 Change-Id: Icf30415f6505710d45743d3921b0ae73b83c6a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649301 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667248}
We already had a fix for inline, misssed fixing it for block. Bug: 967977 Change-Id: Iad883eca7761f0db203fc6e01d48466d7b09dfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648299 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#667249}
…fscreencanvas Change-Id: I7ca3f8d00a48b0f61872363a36b565d68258dfad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646077 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#667250}
The new BVC command to show the send tab to self UI will be handled by this new coordinator. Bug: 970284 Change-Id: Ib57e91d8beee9f99ffa9de2b1ab57e07a25e6dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645209 Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#667251}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13f3e6190c83..cf4f55b6edc4 Created with: gclient setdep -r src-internal@cf4f55b6edc4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: Ic9913a274dc25f4d09ec517ae1d6f8c7a4cff522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650061 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667252}
This CL is the first CL to remove the per-UnifiedConsent code from the sync confirmation dialog. The pre-UnifiedConsent sync confirmation HTML and JS are still for the case when sync is disabled by policy. Follow-up CLs will attempt to do the clean-up for these cases. Bug: 971183 Change-Id: I9b24b5b23fad9a0658ebea0ab0c80f3157e530ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645358 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#667253}
Bug: pdfium:1320 Change-Id: I766c1207b42822b58ba1c142d5ae34017880fd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648777 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Andrew Weintraub <asweintraub@google.com> Cr-Commit-Position: refs/heads/master@{#667254}
1. Remove surface_synchronization. It's on everywhere at this point so it's not neessary to list it. 2. Make metal and surface control platform specific. They aren't relevant outside of MacOS and Android respectively. 3. Make features that are experimental or ongoing finch controlled roll out not show up in problems detected list when disabled. 4. Remove |needs_gpu_access| attribute since it's not used. Bug: none Change-Id: I9e9909d33d849e2025a550e0bd0d42eb90c00d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648650 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#667255}
Fix a race condition when notifying observers that a session was abandoned. BUG=971827 Change-Id: Ib0ec8188e7936cee2cd6676709dde408bc3ab3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648951 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#667256}
Bug: 951969 Change-Id: If21acded7077b018a15c61dd2b30a9b3d161bef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650029 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#667257}
See bug for screenshots. Bug: 971960 Change-Id: I1c85419251460630de612dd465773d80bfd6010a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649189 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#667258}
This CL adds the classes to support showing JS alerts via OverlayPresenter, and adds the alert coordinator to the OverlayModality::kWebContentArea supported classes list. Bug: 941745 Change-Id: I8fe4986cadedf80cb673d9b5f311f1320318af02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639517 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#667259}
…t be noexcept They depend on LockRequest, that depends on WeakPtr, none of them noexcept. Bug: 819294 Change-Id: I04ec15901ca627358df727540597f21f135c129b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646252 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#667260}
Bug: 972153 Change-Id: I7f2edf4621af6007d548214fdffbf4af4c4a0e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650082 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#667261}
Also change to use mixin for existing bots. Bug: 967011,961808 Change-Id: I68334b0c223a12ee0e0db48a86256ff20fbe0058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649057 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#667262}
Bug: 971840 Change-Id: I8e105401276130c3d690c24e37228d80d18eddfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648939 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667263}
pull bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
This reverts commit 59bae41. Reason for revert: Broken on Linux Chromium OS ASan LSan Tests (1) https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/39927/ <div><pre>[ RUN ] PrerenderBrowserTest.PrerenderBlankIframe 2021-04-26T19:40:32.221868Z INFO content_browsertests[5132:5132]: [content_main_runner_impl.cc(1077)] Chrome is running in full browser mode. DevTools listening on ws://127.0.0.1:36659/devtools/browser/21b92715-e642-49fe-98ef-4b69eea3f8b2 2021-04-26T19:40:32.847975Z ERROR content_browsertests[5132:5132]: [browser_test_utils.cc(837)] No committed entry. 2021-04-26T19:40:34.078783Z WARNING content_browsertests[5132:5132]: [render_frame_host_impl.cc(977)] InterfaceRequest was dropped, the document is no longer active: blink.mojom.AppCacheBackend 2021-04-26T19:40:34.281683Z FATAL content_browsertests[5285:1]: [document.cc(8103)] Check failed: is_prerendering_. #0 0x55b148a133cb in backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4205:13 #1 0x55b1586bd249 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x55b1583f3f03 in StackTrace ./../../base/debug/stack_trace.cc:198:12 #3 0x55b1583f3f03 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:195:28 #4 0x55b158448eb2 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:589:29 #5 0x55b15844adde in logging::LogMessage::~LogMessage() ./../../base/logging.cc:583:27 #6 0x55b15e0d8fa6 in blink::Document::ActivateForPrerendering() ./../../third_party/blink/renderer/core/dom/document.cc:8103:3 #7 0x55b15392c60c in Run ./../../base/callback.h:101:12 #8 0x55b15392c60c in RunInternal ./../../third_party/blink/renderer/platform/wtf/functional.h:221:33 #9 0x55b15392c60c in WTF::ThreadCheckingCallbackWrapper<base::OnceCallback<void ()>, void ()>::Run() ./../../third_party/blink/renderer/platform/wtf/functional.h:206:12 #10 0x55b1585795fa in Run ./../../base/callback.h:101:12 #11 0x55b1585795fa in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:173:33 #12 0x55b1585e197a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:351:25 #13 0x55b1585e071f in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:264:36 #14 0x55b158468934 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:39:55 #15 0x55b1585e36d9 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:460:12 #16 0x55b158503839 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #17 0x55b1671389dc in content::RendererMain(content::MainFunctionParams const&) ./../../content/renderer/renderer_main.cc:261:16 #18 0x55b15003c45a in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:572:14 #19 0x55b15003f244 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:958:10 #20 0x55b150039a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #21 0x55b150039f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #22 0x55b157438e9c in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:372:12 #23 0x55b1572a1d21 in main ./../../content/test/content_test_launcher.cc:91:10 #24 0x7f772d1ad840 in __libc_start_main ??:0:0 #25 0x55b1489dcaaa in _start ??:0:0 Task trace: #0 0x55b15ea7ff11 in blink::LocalFrame::ActivateForPrerendering() ./../../third_party/blink/renderer/core/frame/local_frame.cc:3766:18 #1 0x55b15780d116 in IPC::(anonymous namespace)::ChannelAssociatedGroupController::Accept(mojo::Message*) ./../../ipc/ipc_mojo_bootstrap.cc:904:13 IPC message handler context: 0xA60C9B35 Received signal 6 #0 0x55b148a133cb in backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4205:13 #1 0x55b1586bd249 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x55b1583f3f03 in StackTrace ./../../base/debug/stack_trace.cc:198:12 #3 0x55b1583f3f03 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:195:28 #4 0x55b1586bbd47 in base::debug::(anonymous namespace)::StackDumpSignalHandler(int, siginfo_t*, void*) ./../../base/debug/stack_trace_posix.cc:345:3 #5 0x7f7730097390 in __funlockfile ??:? #6 0x7f7730097390 in ?? ??:0 #7 0x7f772d1c2438 in raise ??:0:0 #8 0x7f772d1c403a in abort ??:0:0 #9 0x55b1586b9f6a in base::debug::BreakDebugger() ./../../base/debug/debugger_posix.cc:326:3 #10 0x55b158449863 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:891:7 #11 0x55b15844adde in logging::LogMessage::~LogMessage() ./../../base/logging.cc:583:27 #12 0x55b15e0d8fa6 in blink::Document::ActivateForPrerendering() ./../../third_party/blink/renderer/core/dom/document.cc:8103:3 #13 0x55b15392c60c in Run ./../../base/callback.h:101:12 #14 0x55b15392c60c in RunInternal ./../../third_party/blink/renderer/platform/wtf/functional.h:221:33 #15 0x55b15392c60c in WTF::ThreadCheckingCallbackWrapper<base::OnceCallback<void ()>, void ()>::Run() ./../../third_party/blink/renderer/platform/wtf/functional.h:206:12 #16 0x55b1585795fa in Run ./../../base/callback.h:101:12 #17 0x55b1585795fa in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:173:33 #18 0x55b1585e197a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:351:25 #19 0x55b1585e071f in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:264:36 #20 0x55b158468934 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:39:55 #21 0x55b1585e36d9 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:460:12 #22 0x55b158503839 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #23 0x55b1671389dc in content::RendererMain(content::MainFunctionParams const&) ./../../content/renderer/renderer_main.cc:261:16 #24 0x55b15003c45a in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:572:14 #25 0x55b15003f244 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:958:10 #26 0x55b150039a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #27 0x55b150039f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #28 0x55b157438e9c in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:372:12 #29 0x55b1572a1d21 in main ./../../content/test/content_test_launcher.cc:91:10 #30 0x7f772d1ad840 in __libc_start_main ??:0:0 #31 0x55b1489dcaaa in _start ??:0:0 r8: 0000000000003000 r9: 00000feee51a2840 r10: 0000000000000008 r11: 0000000000000202 r12: 00000fef65260c00 r13: 00000feee5268e48 r14: 00007f7729347230 r15: 00007f77293472b0 di: 0000000000000001 si: 0000000000000001 bp: 00007ffcf0a97110 bx: 00007ffcf0a97120 dx: 0000000000000006 ax: 0000000000000000 cx: 00007f772d1c2438 sp: 00007ffcf0a96fd8 ip: 00007f772d1c2438 efl: 0000000000000202 cgf: 002b000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(EXIT_FAILURE). Core file will not be generated. ../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure Failed Unexpected termination of a renderer process; status: 1, exit_code: 256 Stack trace: #0 0x556300884c70 in content::NoRendererCrashesAssertion::Observe(int, content::NotificationSource const&, content::NotificationDetails const&) ./../../content/public/test/no_renderer_crashes_assertion.cc:101:5 #1 0x5562fe8a511c in content::NotificationServiceImpl::Notify(int, content::NotificationSource const&, content::NotificationDetails const&) ./../../content/browser/notification_service_impl.cc:123:16 #2 0x5562fed854dc in content::RenderProcessHostImpl::ProcessDied(bool, content::ChildProcessTerminationInfo*) ./../../content/browser/renderer_host/render_process_host_impl.cc:4468:35 #3 0x5562fed84d46 in content::RenderProcessHostImpl::FastShutdownIfPossible(unsigned long, bool) ./../../content/browser/renderer_host/render_process_host_impl.cc:3480:3 #4 0x5563007096fd in content::ContentBrowserTest::PostRunTestOnMainThread() ./../../content/public/test/content_browser_test.cc:159:26 #5 0x55630081ddfd in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:833:3 #6 0x5562f23f595a in base::OnceCallback<void ()>::Run() && ./../../base/callback.h:101:12 #7 0x556300a86450 in content::ShellBrowserMainParts::PreMainMessageLoopRun() ./../../content/shell/browser/shell_browser_main_parts.cc:200:37 #8 0x5562fe06aed1 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:961:28 #9 0x5562f78e60d9 in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:101:12 #10 0x5562ff118ca5 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 #11 0x5562fe06a59d in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:869:25 #12 0x5562fe0715f3 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:131:15 #13 0x5562fe066342 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #14 0x5562f94bb63d in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:598:10 #15 0x5562f94bded9 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1081:10 #16 0x5562f94bd258 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:956:12 #17 0x5562f94b7a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #18 0x5562f94b7f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #19 0x55630081c4bd in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:696:3 2021-04-26T19:40:34.692356Z WARNING content_browsertests[5132:5174]: [discardable_shared_memory_manager.cc(432)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [ FAILED ] PrerenderBrowserTest.PrerenderBlankIframe, where TypeParam = and GetParam() = (2830 ms) Original change's description: > Prerender: Enable PrerenderBrowserTest.PrerenderBlankIframe > > To sheriffs: Feel free to revert this CL if the test is flaky. > > The CL author tried to reproduce this on local environments but > failed. For further investigation, this CL enables the test again to see > how it works on the try bots. > > Bug: 1185965 > Change-Id: Ie7f65ef094a815e72b93091c8b3d0ab9b361e593 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2850329 > Reviewed-by: Lingqi Chi <lingqi@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#876111} Bug: 1185965 Change-Id: I245d5e5f2715c75ead3a50389cbd0e9a4ad49aed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2853351 Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Owners-Override: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#876535}
pull bot
pushed a commit
that referenced
this pull request
May 4, 2021
This reverts commit cb50483. Reason for revert: fails on UBSAN bot https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/3981/overview Log is: [ RUN ] ReportClientTestSuite/ReportClientTest.CreatesReportQueue/1 ../../base/bind_internal.h:509:12: runtime error: member call on address 0x1eb2009c7e00 which does not point to an object of type 'StorageInitContext' 0x1eb2009c7e00: note: object has invalid vptr 00 00 00 00 00 00 1e b2 00 9c 7d 40 ff ff e1 4d ff 63 82 bf 20 0f 9b 01 b2 1e 00 00 80 e2 32 00 ^~~~~~~~~~~~~~~~~~~~~~~ invalid vptr #0 0x556cc82b0ebc in Invoke<void (StorageInitContext::*)(reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> >), StorageInitContext *, reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> > > base/bind_internal.h:509:12 #1 0x556cc82b0ebc in MakeItSo<void (StorageInitContext::*)(reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> >), StorageInitContext *, reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> > > base/bind_internal.h:648:12 #2 0x556cc82b0ebc in RunImpl<void (StorageInitContext::*)(reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> >), std::tuple<base::internal::UnretainedWrapper<StorageInitContext> >, 0> base/bind_internal.h:721:12 #3 0x556cc82b0ebc in base::internal::Invoker<base::internal::BindState<void (reporting::Storage::Create(reporting::StorageOptions const&, base::RepeatingCallback<void (reporting::Priority, bool, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>)>, scoped_refptr<reporting::EncryptionModuleInterface>, base::OnceCallback<void (reporting::StatusOr<scoped_refptr<reporting::Storage> >)>)::StorageInitContext::*)(reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >), base::internal::UnretainedWrapper<reporting::Storage::Create(reporting::StorageOptions const&, base::RepeatingCallback<void (reporting::Priority, bool, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>)>, scoped_refptr<reporting::EncryptionModuleInterface>, base::OnceCallback<void (reporting::StatusOr<scoped_refptr<reporting::Storage> >)>)::StorageInitContext> >, void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>::RunOnce(base::internal::BindStateBase*, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >&&) base/bind_internal.h:690:12 #4 0x556cc82b087a in Run base/callback.h:101:12 #5 0x556cc82b087a in reporting::Storage::Create(reporting::StorageOptions const&, base::RepeatingCallback<void (reporting::Priority, bool, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>)>, scoped_refptr<reporting::EncryptionModuleInterface>, base::OnceCallback<void (reporting::StatusOr<scoped_refptr<reporting::Storage> >)>)::StorageInitContext::WrapInstantiatedKeyUploader(reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >) components/reporting/storage/storage.cc:543:12 #6 0x556cc82b0f8b in void base::internal::FunctorTraits<void (*)(reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >), void>::Invoke<void (*)(reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >), reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > > >(void (*&&)(reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >), reporting::Priority&&, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>&&, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >&&) base/bind_internal.h:404:12 #7 0x556cc3c9dbaf in Run base/callback.h:101:12 #8 0x556cc3c9dbaf in reporting::ReportingClient::FlushAsyncStartUploaderQueue() chrome/browser/policy/messaging_layer/public/report_client.cc:407:44 Original change's description: > Fixed ReportClient > > Made encryption key delivery work. > Extended unit test to handle encrypted case. > Also modified the test to accept unique directory instead of "reporting" > > Bug: b:186460976 > Change-Id: Ibe0c4caad64b4e77c0d984138ce0a9ae027253a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2866305 > Commit-Queue: Leonid Baraz <lbaraz@chromium.org> > Reviewed-by: Zach Trudo <zatrudo@google.com> > Cr-Commit-Position: refs/heads/master@{#878713} Bug: b:186460976 Change-Id: I059d13e662679816d63b219269b6f25c7acfb23f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2871825 Auto-Submit: David Roger <droger@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: David Roger <droger@chromium.org> Owners-Override: David Roger <droger@google.com> Cr-Commit-Position: refs/heads/master@{#878809}
pull bot
pushed a commit
that referenced
this pull request
May 7, 2021
…ger per-frame." This reverts commit 7f03b3b. Reason for revert: This change caused some ClusterFuzz issues, as well as failed DCHECKs. Reverting while I work on addressing those. Original change's description: > Instantiate PeerConnectionDependencyFactory and P2PSocketManager per-frame. > > This is attempt #4 to land this CL, attempting to address > leaks found by "WebKit Linux Leak" and a number of ClusterFuzz bugs. > > Changes from previous attempt: > ClusterFuzz issues crbug.com/1195372, crbug.com/1195801 > - Cache PeerConnectionDependencyFactory on ProcessedLocalAudioSource > (see crrev.com/c/2804937 for more details). > WebKit Linux Leak layout tests: > - Change the CrossThreadPersistent on WebRtcMediaStreamTrackAdapter to > CrossThreadWeakPersistent, so the adapter doesn't prevent the factory > from being GC'd. > - Cache the WebRTC signaling thread task runner in the track adapter, > for use when disposing of remote audio track. > - Remove thread check in WebRtcAudioDeviceImpl dtor - since the audio > device is ref-counted, and some of the references are held (and > released) by WebRTC, it is no longer guaranteed that it will be > destroyed on the main thread. On the other hand, it does not appear to > be doing anything that requires the main thread either. > Additional "anti-leak" changes (PS9-10): > - IpcNetworkManager and P2PSocketClientImpl's references to > P2PSocketDispatcher were changed to CrossThreadWeakPersistent. > - P2PAsyncAddressResolver resets its P2PSocketDispatcher after it is > used in Start(). > > > Original description: (crrev.com/c/2706367) > =========================================== > We are currently in the process of attributing as many interfaces as > possible to specific frames/execution contexts, and as part of the work > on WebRTC-related interfaces, this CL binds P2PSocketManager per-EC. > > Also in this CL: > - Make PeerConnectionDependencyFactory and P2PSocketDispatcher garbage > collected. > - Make MojoBindingContext Supplementable. > - Make P2PSocketDispatcher supplement MojoBindingContext. > - P2PSocketDispatcherHost is still instantiated per RenderProcessHost, > but now it manages sets of Receivers and Remotes. > - Plumb the appropriate NetworkIsolationKey when binding the socket > manager. > - RTP dump now "broadcasts" start/stop dump messages to all interfaces > associated with the RenderProcessHost. > =========================================== > > Attempt #2 description: (crrev.com/c/2789266) > =========================================== > The original CL broke the build (together with crrev.com/c/2784218), so > this CL fixes that by explicitly initializing the Supplement with null > in the PeerConnectionDependencyFactory default ctor. > =========================================== > > Attempt #3 description: (crrev.com/c/2793204) > =========================================== > Changes from the previous attempt include: > - P2PSocketDispatcher uses weak references to itself to post tasks. > - IpcPacketSocketFactory keeps a weak reference to the > P2PSocketDispatcher, and DCHECKs it before use. > - WebRtcMediaStreamTrackAdapterMap keeps a weak reference to the > PeerConnectionDependencyFactory. The pointer's validity is already > DCHECKed. > - RTCPeerConnectionHandler resets its PeerConnectionDependencyFactory > pointer when it is StopAndUnregister()-ed, and DCHECKs the pointer > before use. > =========================================== > > > Bug: 1126758 > Bug: 1178670 > Bug: 1085022 > Bug: 1193446 > Bug: 1195372 > Bug: 1195801 > Change-Id: I18f429bc19f0799dd751e22e863570b96c254e03 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2805110 > Commit-Queue: Tal Pressman <talp@google.com> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#874136} Bug: 1126758 Bug: 1178670 Change-Id: I280fea7a81734f4c76a9ec5f171e1d07d7cd7b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878256 Commit-Queue: Tal Pressman <talp@google.com> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Owners-Override: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#880237}
pull bot
pushed a commit
that referenced
this pull request
May 13, 2021
…frame. This is attempt #5 to land this CL. The previous attempt caused some instability (in the form of ClusterFuzz reports and crashes) that appear to be caused by PCDF's cleanup being called on ContextDestroyed - since many of the dependencies it owns are accessed by other threads, they may be used after the context is destroyed on the main thread. Changes from previous attempt: PS1 is the result of `git revert` on crrev.com/c/2878256. PS2: - Move PeerConnectionDependencyFactory cleanup from ContextDestroyed to pre-finalizer. Since WebRTC uses some of the dependencies from other threads, some of those uses may occur after the context is detached, so those dependencies must be kept alive longer. - Change IpcNetworkManager's NetworkListManager reference from weak to strong. Since the NetworkListManager is accessed in the dtor, which is invoked as part of a task posted from the PCDF pre-finalizer, using a CrossThreadWeakPersistent there causes a null dereference (weak references are invalidated before pre-finalizers are invoked). PS9: - The change to a strong reference in PS2 caused leaks, so this PS splits the PCDF cleanup to two parts: ContextDestroyed performs the IpcNetworkManager cleanup (without destroying it) and clears the CTP, while the pre-finalizer does the rest of the cleanup and destruction. Original description: (crrev.com/c/2706367) =========================================== We are currently in the process of attributing as many interfaces as possible to specific frames/execution contexts, and as part of the work on WebRTC-related interfaces, this CL binds P2PSocketManager per-EC. Also in this CL: - Make PeerConnectionDependencyFactory and P2PSocketDispatcher garbage collected. - Make MojoBindingContext Supplementable. - Make P2PSocketDispatcher supplement MojoBindingContext. - P2PSocketDispatcherHost is still instantiated per RenderProcessHost, but now it manages sets of Receivers and Remotes. - Plumb the appropriate NetworkIsolationKey when binding the socket manager. - RTP dump now "broadcasts" start/stop dump messages to all interfaces associated with the RenderProcessHost. =========================================== Attempt #2 description: (crrev.com/c/2789266) =========================================== The original CL broke the build (together with crrev.com/c/2784218), so this CL fixes that by explicitly initializing the Supplement with null in the PeerConnectionDependencyFactory default ctor. =========================================== Attempt #3 description: (crrev.com/c/2793204) =========================================== Changes from the previous attempt include: - P2PSocketDispatcher uses weak references to itself to post tasks. - IpcPacketSocketFactory keeps a weak reference to the P2PSocketDispatcher, and DCHECKs it before use. - WebRtcMediaStreamTrackAdapterMap keeps a weak reference to the PeerConnectionDependencyFactory. The pointer's validity is already DCHECKed. - RTCPeerConnectionHandler resets its PeerConnectionDependencyFactory pointer when it is StopAndUnregister()-ed, and DCHECKs the pointer before use. =========================================== Attempt #4 description: (crrev.com/c/2805110) =========================================== This is attempt #4 to land this CL, attempting to address leaks found by "WebKit Linux Leak" and a number of ClusterFuzz bugs. Changes from previous attempt: ClusterFuzz issues crbug.com/1195372, crbug.com/1195801 - Cache PeerConnectionDependencyFactory on ProcessedLocalAudioSource (see crrev.com/c/2804937 for more details). WebKit Linux Leak layout tests: - Change the CrossThreadPersistent on WebRtcMediaStreamTrackAdapter to CrossThreadWeakPersistent, so the adapter doesn't prevent the factory from being GC'd. - Cache the WebRTC signaling thread task runner in the track adapter, for use when disposing of remote audio track. - Remove thread check in WebRtcAudioDeviceImpl dtor - since the audio device is ref-counted, and some of the references are held (and released) by WebRTC, it is no longer guaranteed that it will be destroyed on the main thread. On the other hand, it does not appear to be doing anything that requires the main thread either. Additional "anti-leak" changes (PS9-10): - IpcNetworkManager and P2PSocketClientImpl's references to P2PSocketDispatcher were changed to CrossThreadWeakPersistent. - P2PAsyncAddressResolver resets its P2PSocketDispatcher after it is used in Start(). =========================================== Change-Id: I4ed70c44f4cbc300754c00b1bdbe3dac9d31018d Bug: 1178670 Bug: 1085022 Bug: 1067592 Cq-Include-Trybots: luci.chromium.try:layout_test_leak_detection Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2882778 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Owners-Override: Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#882476}
pull bot
pushed a commit
that referenced
this pull request
May 20, 2021
CL Chain -------- This is the 4th CL in a chain. The expected length of the *core* of the chain is 6-7 CLs. Extensions likely to follow. The first CL has a full explanation of the feature and an outline of the chain: https://chromium-review.googlesource.com/c/chromium/src/+/2887150/ Contents of this CL ------------------- In the browser process capture handles are observed. A captured tab can have its capture handle changed by: a. Captured application calls setCaptureHandleConfig(). b. Captured application's top-level frame is navigated to another document. c. User clicks the [share-this-tab-instead] button. When the capture handle of a captured application X changes, for each capturing application Y, calculate the new observable capture handle and send it to the capturer's render process. The next CLs deal with handling this message. Clarification: CaptureHandleConfigs set permitted-origins. By "observable capture handle" we mean the capture handle as-is for allowlisted capturers, and the empty capture handle for non-allowlisted capturers. Bug: 1200910 Change-Id: I1a160d01ba21618fbf0dd0e99b7969a316836684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2897153 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#884467}
pull bot
pushed a commit
that referenced
this pull request
May 25, 2021
This CL addresses an issue where the map of View objects to AXNodeIDs in the AXAuraObjectCache gets populated with stale elements. When a View is destructed, we remove it from this cache, but if the View was focused, we incorrectly add a new entry back (see stack traces below). This causes issues if later on a View is created at the same address at this deleted view (manifesting as a flaky test failure on the linked bug). We fix this by having the AXViewObjWrapper remove the cache entry when the View is destroyed (OnViewIsDeleting). Stack trace for removing AXAuraObjCache entry #0 views::AXAuraObjCache::Remove() #1 views::AXAuraObjCache::RemoveViewSubtree() #2 views::Widget::NotifyWillRemoveView() #3 views::View::DoRemoveChildView() #4 views::View::~View() Stack trace for re-adding AXAuraObjCache entry #0 views::AXAuraObjCache::GetOrCreate() #1 AutomationManagerAura::OnViewEvent() #2 views::AXEventManager::NotifyViewEvent() #3 views::View::NotifyAccessibilityEvent() #4 views::View::SetVisible() #5 views::FocusRing::RefreshLayer() #6 views::View::Blur() #7 views::FocusManager::SetFocusedViewWithReason() #8 views::Widget::ViewHierarchyChanged() #9 views::internal::RootView::ViewHierarchyChanged() #10 views::View::ViewHierarchyChangedImpl() #11 views::View::PropagateRemoveNotifications() #12 views::View::DoRemoveChildView() #13 views::View::~View() AX-Relnotes: n/a. Bug: b/159074662 Change-Id: Iaf787af321da7de5448e88c036a556a3fc4e1032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2912232 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#886102}
pull bot
pushed a commit
that referenced
this pull request
Jun 11, 2021
…03 commits) https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator.git/+log/732a76d9d3c7..f67d7fa397e8 $ git log 732a76d9d..f67d7fa39 --date=short --no-merges --format='%ad %ae %s' 2021-06-10 pkasting Update Chromium-side files for upstream roll 2021-06-09 adam.sawicki Fixing Linux build on TravisCI (1) 2021-06-09 adam.sawicki Fix .gitignore to include binaries at new locations 2021-06-09 adam.sawicki Delete shader files 2021-06-09 adam.sawicki Delete binaries from old path 2021-06-09 adam.sawicki Deleted Premake 2021-06-09 adam.sawicki Regenerated documentation 2021-06-09 adam.sawicki Fixed link to include/vk_mem_alloc.h in README.md and Doxyfile 2021-06-09 adam.sawicki Moving Doxyfile to main directory 2021-06-09 adam.sawicki Added VmaVector::shrink_to_fit instead of freeMemory parameter in resize, clear, to fix compilation with VMA_USE_STL_CONTAINERS 2021-06-08 pkasting Fix clang -Wdeprecated-copy. 2021-06-02 johannesschneider Update README 2021-06-02 johannesschneider Add VMA_STATIC_VULKAN_FUNCTIONS and set VMA_DYNAMIC_VULKAN_FUNCTIONS to ON by default 2021-06-02 johannesschneider Remove macros which can be configured through CMake from VmaUsage.h 2021-06-02 johannesschneider Enable compiling with multiple processes for VmaReplay 2021-06-02 johannesschneider Add documentation of CMake options to README 2021-06-02 johannesschneider Correct README 2021-06-02 johannesschneider Link VulkanMemoryAllocator to Vulkan only if static linking is enabled 2021-06-02 johannesschneider Expose important VMA settings macros as CMake options 2021-05-31 johannesschneider Improve consistency in naming of targets and options 2021-05-31 johannesschneider Replace add_definitions with add_compile_definitions 2021-05-31 johannesschneider Move add_subdirectory for shaders and VmaReplay to the end of the file 2021-05-31 johannesschneider Only set VMA_EXAMPLE_SOURCE_FILES when building sample app 2021-05-31 johannesschneider Make target_include_directories a one line instruction 2021-05-31 johannesschneider Remove CMAKE_DISABLE_IN_SOURCE_BUILD 2021-05-31 johannesschneider Rename VmaShaders to VmaBuildExampleShaders 2021-05-31 johannesschneider Remove source_group instructions 2021-05-31 johannesschneider Show default values for CMake options in README's table 2021-05-31 johannesschneider Replace Ninja with Make as default build instruction on Linux 2021-05-28 johannesschneider Rename replay app target and shaders target 2021-05-28 johannesschneider Fix VmaReplay build 2021-05-28 adam.sawicki Fixed link in documentation 2021-05-28 johannesschneider Minor typo fixes in code comments 2021-05-28 johannesschneider Add CMake build instructions 2021-05-28 johannesschneider Fix VMA_BUILD_EXAMPLE_APP_SHADERS being ignored on Linux 2021-05-28 johannesschneider Fix missing Vulkan dependency of VmaExample 2021-05-28 johannesschneider Do not set CMAKE_RUNTIME_OUTPUT_DIRECTORY 2021-05-28 johannesschneider Make building shaders, VMA example application and VMA replay app optional 2021-05-28 johannesschneider Remove reference to MoltenVK issue 175 which is fixed now 2021-05-25 johannesschneider Add CMake support 2021-05-17 devnexen clang build warning fixes proposal 2021-05-06 petr_kraus Docs typo 2021-04-19 adam.sawicki Moved main file vk_mem_alloc.h to subdirectory include/ 2021-04-06 cwallez BUILD.gn: Make the vulkan-headers directory overridable. 2021-03-11 adam.sawicki Rebuilt binaries, regenerated documentation 2021-03-11 adam.sawicki Added parsing of command line parameters and GPU selection 2021-03-11 adam.sawicki Improved macros TEST, ERR_GUARD_VULKAN 2021-03-03 adam.sawicki Optimization: custom pools are on an intrusive double linked list not sorted vector 2021-03-03 adam.sawicki Fix for compilation on Linux 2021-03-03 adam.sawicki Optimization: dedicated allocations are on an intrusive double linked list not sorted vector (...) 2021-02-26 adam.sawicki Removed deprecated function vmaResizeAllocation 2021-02-26 adam.sawicki Sample app: Added printing information about available memory heaps nad types 2021-02-23 adam.sawicki Fixed budget management in VmaBlockVector::Allocate for cases when some of multi-page allocations fail 2021-02-23 adam.sawicki Fix in tests for AMD APU with DEVICE_LOCAL heap of only 256 MB 2021-02-22 adam.sawicki Fix for build on Linux #6 2021-02-22 adam.sawicki Fix for build on Linux #5 2021-02-22 adam.sawicki Fix for build on Linux #4 2021-02-22 adam.sawicki Fix for build on Linux #3 2021-02-22 adam.sawicki Fix for build on Linux #2 2021-02-22 adam.sawicki Fix for build on Linux 2021-02-19 adam.sawicki Internal improvement: Added counting total number of VkDeviceMemory blocks. 2021-02-19 adam.sawicki Trying to fix Travis-CI build 2021-02-18 adam.sawicki A fix in TestPool_Benchmark for GPUs with only 256 MB of DEVICE_LOCAL memory 2021-02-16 adam.sawicki Migrated Linux CI build from travis-ci.org to travis-ci.com - updated status icon in README.md 2021-02-16 adam.sawicki Updated copyright header to year 2021. 2021-02-16 adam.sawicki Minor update in README.md 2021-02-16 adam.sawicki Rebuilt binaries using Visual Studio 2019 2021-02-16 adam.sawicki Updated README.md - added RPCS3 to the list of known usages. 2021-02-15 karokidii mem_alloc: Optimize allocation conflict checking 2021-01-11 adam.sawicki Added support for VK_EXT_memory_priority 2020-12-02 ashkanaliabadi Refer to std string and stream with their fully qualified names. 2020-11-03 adam.sawicki Further improvements in documentation. 2020-11-03 adam.sawicki Improvements in documentation. 2020-11-03 adam.sawicki Fixes and clarifications in documentation 2020-10-28 rbarnes Drop trailing whitespace. 2020-10-28 rbarnes Make binary search overflow safe. 2020-10-15 adam.sawicki Minor formatting fix in documentation 2020-09-30 adam.sawicki Added Detroit: Become Human to the list of known software using this library 2020-09-30 adam.sawicki Fix std::min in VmaBlockVector::ProcessDefragmentations 2020-08-24 frank.richter Let VMA_SYSTEM_ALIGNED_FREE fall back to VMA_SYSTEM_FREE, if defined 2020-08-24 frank.richter Add vma_aligned_free() for symmetry 2020-08-24 frank.richter Make vma_aligned_alloc() functions static 2020-08-23 frank.richter Move preprocessor directives that may influence user code into implementation block 2020-08-21 ashkanaliabadi Fix misspellings. 2020-08-18 adam.sawicki Add test and documentation for resource aliasing (overlap). 2020-08-18 adam.sawicki Fix in documentation chapter "Finding out if memory is mappable" 2020-08-18 adam.sawicki Add "Atypical Games - proprietary game engine" to the list of software using this library 2020-08-10 stricmp Fix VMA_DYNAMIC_VULKAN_FUNCTIONS compilation errors when VK_NO_PROTOTYPES is defined 2020-07-27 d.korkmazturk Fix a typo in the explanation of VMA_ALLOCATION_CREATE_MAPPED_BIT 2020-07-16 adam.sawicki Fix compilation errors 2020-07-15 adam.sawicki Replace usage of old VK_LAYER_LUNARG_standard_validation and extension VK_EXT_debug_report with new VK_LAYER_KHRONOS_validation and extension VK_EXT_debug_utils also in VmaReplay 2020-07-15 adam.sawicki Replace usage of old layer VK_LAYER_LUNARG_standard_validation and extension VK_EXT_debug_report with new layer VK_LAYER_KHRONOS_validation and extension VK_EXT_debug_utils 2020-06-25 thakis mac: Only call system aligned_alloc() with the 11.0+ SDK. 2020-06-25 thakis Only use system aligned_alloc on mac/ios if the SDK has them. 2020-06-25 thakis Fix argument order for aligned_alloc on mac. 2020-06-25 thakis Make vulkan_memory_allocator build with the MacOSX11.0 SDK. 2020-07-06 adam.sawicki Improvement in VmaAlignUp, VmaAlignDown 2020-07-03 greenfoxlight.42 Correct if in mapping example 2020-06-24 adam.sawicki Clarify documentation of VmaAllocationInfo::size 2020-06-24 adam.sawicki Add assert to check success of a CPU memory allocation Created with: roll-dep src/third_party/vulkan_memory_allocator Bug: 1213098 Change-Id: I5b8041c7286a84b1d298fd7c583bd6ec273f73e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2952854 Reviewed-by: Evgenii Stepanov <eugenis@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#891671}
pull bot
pushed a commit
that referenced
this pull request
Jun 19, 2021
This will make compile step faster. Previously symbol_level=0 means no symbol. But llvm changed the behavior. Now it contains function names, which in general is fine for developers. This is the result for linux-lacros-rel: symbol_level=0: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel/247920? The browser_tests shard 0 contains: ../../chrome/browser/profiles/profile_manager_browsertest.cc:616: Failure Expected equality of these values: 2U Which is: 2 chrome::GetTotalBrowserCount() Which is: 1 Stack trace: #0 0x56441415eea1 ProfileManagerBrowserTest_PRE_AddMultipleProfiles_Test::RunTestOnMainThread() #1 0x56441a1d278c content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x564413970763 chrome_service_worker_browser_test::ChromeServiceWorkerLinkFetchTest::ManifestCallbackAndRun() #3 0x5644199f3cce ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #4 0x5644199f3024 ChromeBrowserMainParts::PreMainMessageLoopRun() #5 0x564416e69bef content::BrowserMainLoop::PreMainMessageLoopRun() #6 0x56441740a676 content::StartupTaskRunner::RunAllTasksNow() #7 0x564416e69855 content::BrowserMainLoop::CreateStartupTasks() #8 0x564416e6c10b content::BrowserMainRunnerImpl::Initialize() #9 0x564416e67dd7 content::BrowserMain() #10 0x564417d95478 content::ContentMainRunnerImpl::RunBrowser() #11 0x564417d94ec0 content::ContentMainRunnerImpl::Run() #12 0x564417d92d1c content::RunContentProcess() #13 0x564417d92ded content::ContentMain() #14 0x56441a1d1a78 content::BrowserTestBase::SetUp() #15 0x5644197edc5e InProcessBrowserTest::SetUp() symbol_level=1: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel/248772 The browser_tests shard 0 contains: ../../chrome/browser/profiles/profile_manager_browsertest.cc:616: Failure Expected equality of these values: 2U Which is: 2 chrome::GetTotalBrowserCount() Which is: 1 Stack trace: #0 0x5565d9f0f621 ProfileManagerBrowserTest_PRE_AddMultipleProfiles_Test::RunTestOnMainThread() #1 0x5565dff88ebc content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x5565d971fe93 chrome_service_worker_browser_test::ChromeServiceWorkerLinkFetchTest::ManifestCallbackAndRun() #3 0x5565df7aa9ce ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #4 0x5565df7a9d24 ChromeBrowserMainParts::PreMainMessageLoopRun() #5 0x5565dcc1fbdf content::BrowserMainLoop::PreMainMessageLoopRun() #6 0x5565dd1c09c6 content::StartupTaskRunner::RunAllTasksNow() #7 0x5565dcc1f845 content::BrowserMainLoop::CreateStartupTasks() #8 0x5565dcc220fb content::BrowserMainRunnerImpl::Initialize() #9 0x5565dcc1ddc7 content::BrowserMain() #10 0x5565ddb4ce78 content::ContentMainRunnerImpl::RunBrowser() #11 0x5565ddb4c8c0 content::ContentMainRunnerImpl::Run() #12 0x5565ddb4a71c content::RunContentProcess() #13 0x5565ddb4a7ed content::ContentMain() #14 0x5565dff881a8 content::BrowserTestBase::SetUp() #15 0x5565df5a494e InProcessBrowserTest::SetUp() It's the same debug information. Bug: 1221324 Change-Id: I96a0768508cf9bd073a5522e792a4120606bddb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965870 Reviewed-by: Erik Staab <estaab@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#893997}
pull bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
…API support." This reverts commit 97e3106. Reason for revert: Crashing on DUT. Here's the stack trace: #0 0x5b1fdc2d8989 base::debug::CollectStackTrace() #1 0x5b1fdc1e9d53 base::debug::StackTrace::StackTrace() #2 0x5b1fdc2d84e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7a7b96fd29f0 (/lib64/libpthread-2.32.so+0x129ef) #4 0x5b1fdef55c2b _sys_cr_finisheddevice::UsbDeviceLinux::Open() #5 0x5b1fdef50b0f device::UsbServiceLinux::OnDeviceAdded() #6 0x5b1fdef52570 base::internal::FunctorTraits<>::Invoke<>() #7 0x5b1fdc263e50 base::TaskAnnotator::RunTask() #8 0x5b1fdc289291 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #9 0x5b1fdc28ace2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #10 0x5b1fdc36060b base::MessagePumpLibevent::Run() #11 0x5b1fdc28b226 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #12 0x5b1fdc2427b0 base::RunLoop::Run() #13 0x5b1fd94e4ce6 content::BrowserMainLoop::RunMainMessageLoop() #14 0x5b1fd94e6b92 content::BrowserMainRunnerImpl::Run() #15 0x5b1fd94e1df8 content::BrowserMain() #16 0x5b1fdc1b6810 content::ContentMainRunnerImpl::RunBrowser() #17 0x5b1fdc1b6173 content::ContentMainRunnerImpl::Run() #18 0x5b1fdc1b3d94 content::RunContentProcess() #19 0x5b1fdc1b3e6c content::ContentMain() #20 0x5b1fd7dafa1f ChromeMain #21 0x7a7b96861e05 __libc_start_main #22 0x5b1fd7daf8aa _start r8: 00007fffb9571db0 r9: 00007fffb9571dd8 r10: 0000000000000058 r11: 0000000000000293 r12: 00001de68aaf7460 r13: 00007fffb9571dd8 r14: 00007fffb9571db0 r15: 00007fffb9571d88 di: 0000000000000000 si: 00005b1fddf84260 bp: 00007fffb9571f50 bx: 00001de689a4ad20 dx: 00005b1fddf84210 ax: 00001de689f0cb00 cx: 00001de689f0cfc0 sp: 00007fffb9571d60 ip: 00005b1fdef55c2b efl: 0000000000010202 cgf: 002b000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000 Original change's description: > [Lacros] Enable WebUSB, WebSerial, chrome.usb, chrome.serial API support. > > This CL enables USB and Serial related API on Lacros, by applying the > broad stroke of switching Lacros to use code that was previously > Ash-only. More work might be needed later to iron out details. > > Bug: 1195247, 1195248 > Change-Id: I04579cf60ca263907407abdc12cf7a9d5f9d10c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2939830 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#893539} Bug: 1195247, 1195248 Change-Id: I57c7a0dabb64c1ac25a4569fea5559778fe3e547 Owners-Override: Theodore Olsauskas-Warren <sauski@google.com> Owners-Override: Tom Sepez <tsepez@chromium.org> Owners-Override: Reilly Grant <reillyg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972361 Reviewed-by: Samuel Huang <huangs@chromium.org> Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#894279}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
This reverts commit 4b7834e. Reason for revert: Linux MSAN reports a consisten use-of-uninitialized-value failure: HeapProfilingProtoExporterTest.TraceFormat ==23751==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x56504e3f8ad2 in assign ./../../buildtools/third_party/libc++/trunk/include/__string:320:73 #1 0x56504e3f8ad2 in __init ./../../buildtools/third_party/libc++/trunk/include/string:1865:5 #2 0x56504e3f8ad2 in basic_string<nullptr_t> ./../../buildtools/third_party/libc++/trunk/include/string:835:7 #3 0x56504e3f8ad2 in heap_profiling::HeapProfilingTraceSource::AddToTraceIfEnabled(std::__1::vector<base::SamplingHeapProfiler::Sample, std::__1::allocator<base::SamplingHeapProfiler::Sample> > const&) ./../../components/services/heap_profiling/public/cpp/heap_profiling_trace_source.cc:112:33 #4 0x56501e6c908e in heap_profiling::(anonymous namespace)::HeapProfilingProtoExporterTest_TraceFormat_Test::TestBody() ./../../components/services/heap_profiling/public/cpp/heap_profiling_trace_source_unittest.cc:88:44 [...] First full failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/29231/test-results Original change's description: > Add an option to write native heap profiles to trace protos > > The heap profile format is same as the sampling profiler. The heap > profiler reuses code from sampling profiler to write heap profiles. > Adds a proto exporter for heap profiler. The heap profiler writes JSON > profiles to traces currently. If the new command line param is passed, > the proto exporter will additionally add heap profile as protos to > traces. So, in this case it will write the profiles to traces in both > format. In the future changes the heap profiler will stop writing JSON. > > BUG=1228548 > > Change-Id: I9929c20479229c9f14e39f1841d4e0adb50160b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018727 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#902872} Bug: 1228548 Change-Id: Iff29ef031147625fc20bfeacc26749b255213eec No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3038504 Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#902988}
pull bot
pushed a commit
that referenced
this pull request
Jul 25, 2021
This reverts commit d6eb63f. Reason for revert: Fix test to initialize allocator type in test samples. This was being used by the code. Original change's description: > Revert "Add an option to write native heap profiles to trace protos" > > This reverts commit 4b7834e. > > Reason for revert: Linux MSAN reports a consisten use-of-uninitialized-value failure: > > HeapProfilingProtoExporterTest.TraceFormat > ==23751==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x56504e3f8ad2 in assign ./../../buildtools/third_party/libc++/trunk/include/__string:320:73 > #1 0x56504e3f8ad2 in __init ./../../buildtools/third_party/libc++/trunk/include/string:1865:5 > #2 0x56504e3f8ad2 in basic_string<nullptr_t> ./../../buildtools/third_party/libc++/trunk/include/string:835:7 > #3 0x56504e3f8ad2 in heap_profiling::HeapProfilingTraceSource::AddToTraceIfEnabled(std::__1::vector<base::SamplingHeapProfiler::Sample, std::__1::allocator<base::SamplingHeapProfiler::Sample> > const&) ./../../components/services/heap_profiling/public/cpp/heap_profiling_trace_source.cc:112:33 > #4 0x56501e6c908e in heap_profiling::(anonymous namespace)::HeapProfilingProtoExporterTest_TraceFormat_Test::TestBody() ./../../components/services/heap_profiling/public/cpp/heap_profiling_trace_source_unittest.cc:88:44 > [...] > > First full failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/29231/test-results > > > Original change's description: > > Add an option to write native heap profiles to trace protos > > > > The heap profile format is same as the sampling profiler. The heap > > profiler reuses code from sampling profiler to write heap profiles. > > Adds a proto exporter for heap profiler. The heap profiler writes JSON > > profiles to traces currently. If the new command line param is passed, > > the proto exporter will additionally add heap profile as protos to > > traces. So, in this case it will write the profiles to traces in both > > format. In the future changes the heap profiler will stop writing JSON. > > > > BUG=1228548 > > > > Change-Id: I9929c20479229c9f14e39f1841d4e0adb50160b2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018727 > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Commit-Queue: ssid <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#902872} > > Bug: 1228548 > Change-Id: Iff29ef031147625fc20bfeacc26749b255213eec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3038504 > Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#902988} Bug: 1228548 Change-Id: I2a48ca4d47123499cb79bd8efb2458ea51aac95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3038868 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#905065}
pull bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
This reverts commit 0d437e0. Reason for revert: Breaks Lacros. [343589:343589:0726/205512.291579:FATAL:sandbox_seccomp_bpf_linux.cc(239)] Check failed: BPFBasePolicy::GetFSDeniedErrno() == (*__errno_location ()) (1 vs. 13) #0 0x7fa2e2e3a8af base::debug::CollectStackTrace() #1 0x7fa2e2baee0a base::debug::StackTrace::StackTrace() #2 0x7fa2e2baedc5 base::debug::StackTrace::StackTrace() #3 0x7fa2e2bfe239 logging::LogMessage::~LogMessage() #4 0x7fa2e2bfe959 logging::LogMessage::~LogMessage() #5 0x7fa2e2b6e5eb logging::CheckError::~CheckError() #6 0x7fa2cc927b2f sandbox::policy::SandboxSeccompBPF::RunSandboxSanityChecks() #7 0x7fa2cc91fc71 sandbox::policy::SandboxLinux::StartSeccompBPF() #8 0x7fa2cc9206fd sandbox::policy::SandboxLinux::InitializeSandbox() #9 0x7fa2d83e65a3 content::(anonymous namespace)::StartSandboxLinux() #10 0x7fa2d83e62b9 content::(anonymous namespace)::ContentSandboxHelper::EnsureSandboxInitialized() #11 0x7fa2a32de13e gpu::GpuInit::InitializeAndStartSandbox() #12 0x7fa2d83e5ca0 content::GpuMain() #13 0x7fa2dbd8a5ad content::RunZygote() #14 0x7fa2dbd8aa3a content::RunOtherNamedProcessTypeMain() #15 0x7fa2dbd8b7b4 content::ContentMainRunnerImpl::Run() #16 0x7fa2dbd889ae content::RunContentProcess() #17 0x7fa2dbd892fd content::ContentMain() #18 0x5588c3250966 ChromeMain #19 0x5588c3250812 main #20 0x7fa2a56aed0a __libc_start_main #21 0x5588c325072a _start To repro the failure, follow go/lacros-build and build linux Lacros. Lacros can't be launched with the failure above. Original change's description: > Use EACCES over EPERM for broker process denied errno > > When dlopen is called without an absolute path, it looks in a number > of search paths for the requested library (e.g. /lib64/libfoo.so, > /usr/lib/libfoo.so). Often, these files don't exist and the > corresponding openat syscall should return ENOENT, but because of > the GPU sandbox, the syscall returns EPERM instead [1]. glibc's > implementation of dlopen, however, early-exits when it sees an > unexpected errno [2] and terminates without attempting the remaining > search paths. Thus, even if the library *is* allowlisted in a later > path, dlopen will still exit with a failure. > > This CL fixes this issue by changing the denied errno to EACCES for > the broker process. > > Bug: 1233028 > Change-Id: I192098eb072f2ee6fb18aa7da3d1998f8328149f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3054490 > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Brian Ho <hob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#905330} Bug: 1233028 Change-Id: I111ff2bf802615e1299aee7feb88471d49a238e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3055402 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Owners-Override: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#905685}
pull bot
pushed a commit
that referenced
this pull request
Aug 15, 2021
Update UserSessionInitializer::PreStartSession() to take bool is_primary_session and only call NetworkCertLoader::MarkUserNSSDBWillBeInitialized() when true. Fixes crash: 2021-08-08T22:59:06.505936Z FATAL chrome[21728:21728]: [network_cert_loader.cc(148)] Check failed: state_ == State::kNotInitialized || state_ == State::kMarkedWillBeInitialized. #0 0x57e49567eb89 base::debug::CollectStackTrace() #1 0x57e4955c5c93 base::debug::StackTrace::StackTrace() #2 0x57e48fd06890 logging::LogMessage::~LogMessage() #3 0x57e4955d904e logging::LogMessage::~LogMessage() #4 0x57e497827697 chromeos::NetworkCertLoader::CertCache::MarkWillBeInitialized() #5 0x57e4978277d2 chromeos::NetworkCertLoader::MarkUserNSSDBWillBeInitialized() #6 0x57e4937607ac ash::UserSessionManager::StartSession() #7 0x57e493712814 chromeos::ExistingUserController::OnAuthSuccess() #8 0x57e498a7a9e5 chromeos::LoginPerformer::OnAuthSuccess() #9 0x57e498a72c39 chromeos::CryptohomeAuthenticator::OnAuthSuccess() #10 0x57e490df73f4 base::TaskAnnotator::RunTask() #11 0x57e48fe5bc9d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #12 0x57e4956477c2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x57e4909e2445 base::MessagePumpLibevent::Run() #14 0x57e495647a83 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #15 0x57e49560bb56 base::RunLoop::Run() #16 0x57e4924d69f1 content::BrowserMainLoop::RunMainMessageLoop() #17 0x57e4924d8840 content::BrowserMainRunnerImpl::Run() #18 0x57e4924d3ce8 content::BrowserMain() #19 0x57e495082b38 content::RunBrowserProcessMain() #20 0x57e495083e3b content::ContentMainRunnerImpl::RunBrowser() #21 0x57e4950838c6 content::ContentMainRunnerImpl::Run() #22 0x57e49508123e content::RunContentProcess() #23 0x57e495081c40 content::ContentMain() #24 0x57e4910cf23e ChromeMain #25 0x789c45710e05 __libc_start_main #26 0x57e4910cf0da _start Task trace: #0 0x57e498a73fcc chromeos::CryptohomeAuthenticator::Resolve() #1 0x57e496c95be1 dbus::ObjectProxy::OnPendingCallIsComplete() #2 0x57e496c91b91 dbus::Bus::OnDispatchStatusChanged() #3 0x57e49567fa66 base::FileDescriptorWatcher::Controller::Watcher::OnFileCanReadWithoutBlocking() Change-Id: I4b250f807ca8f3fff35cb380b3a47ce98b7ade09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3080039 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#910647}
pull bot
pushed a commit
that referenced
this pull request
Aug 15, 2021
Converts LayoutObject and all its subclasses to GarbageCollected. LayoutObjects will be freed by GC, but owners will still need to call Destroy() on them for lifecycle state management. This is enforced by CheckIsNotDestroyed(). Clang plugin which forces to call it will be added by https://crrev.com/c/2681354. LayoutObject's owners such as Node and PaintLayerScrollableArea need to use Member/Persistent. But other references from non GCed classes use UntracedMember in this CL. The UntracedMember will be replaced to Members as we make their owner classes GCed in followup CLs. Original CL by keishi@: https://crrev.com/c/2306506 The CLs to be landed in chain in reland #4: LayoutObject crrev.com/c/2465602 InlineBox crrev.com/c/2470040 FlexItem crrev.com/c/2413713 HitTestRequest crrev.com/c/2517238 NGOffsetMapping crrev.com/c/2500966 NGEarlyBreak crrev.com/c/2546352 NGExclusionShapeData crrev.com/c/2546510 NGUnpositionedListMarker crrev.com/c/2546311 NGBreakToken crrev.com/c/2576965 PaintLayer crrev.com/c/2440003 Bug: 1030176 Binary-Size: Size increase is unavoidable (see above). Change-Id: Icfba679d6eedd72135a8d010ff61c1c232190fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465602 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#911647}
pull bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
Design-doc: https://docs.google.com/document/d/1LHJRt-ry9hwzFTbPxKrmD0VvtEFEU6lvqsD7k6wwGKM Background: Conditional Focus allows a called to getDisplayMedia() to decide whether the captured display surface (tab/window) should be focused. There is a window of 1s during which focus can be triggered or suppressed. If the application does not explicitly decide within the allotted time, the captured display surface IS focused, in line with previous behavior. This CL: Introduces browser-tests that verify the feature, then remove the browser-side gating for the feature. (The feature is still gated in Blink.) Next CLs, in order: 1. Change the Blink feature-gating to OT-gating. Bug: 1215480 Change-Id: I8808dcd32df527d3361756b8621494a843e06779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3114943 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/main@{#916351}
pull bot
pushed a commit
that referenced
this pull request
Sep 13, 2021
OnAppTypeInitialized could call observer's OnAppTypeInitialized.
Observer's OnAppTypeInitialized might have complex operation to call
OnApps, then call OnAppTypeInitialized again, which might cause the
dead loop. For example:
OnAppTypeInitialized(kWeb)
--> FullRestoreAppLaunchHandler::OnAppTypeInitialized(kWeb)
--> LaunchBrowser
...
-->ExtensionAppsBase::OnExtensionLastLaunchTimeChanged
// To change the launch time for Chrome
-> OnApps
-> OnAppTypeInitialized
// in_progress_initialized_app_types_ is not clear yet,
// which causes dead loop!
-> FullRestoreAppLaunchHandler::OnAppTypeInitialized
(kWeb)
.....
#3 0x55c927c6c90f apps::ExtensionAppsBase::OnExtensionLastLaunchTimeChanged()
#4 0x55c9254a2712 extensions::ExtensionPrefs::SetLastLaunchTime()
#5 0x55c92b2a97e4 BrowserShortcutShelfItemController::OnBrowserAdded()
Modify OnAppTypeInitialized to clear in_progress_initialized_app_types_
before calling the observer's OnAppTypeInitialized, to prevent
observer's OnAppTypeInitialized called again and again.
BUG=1237267
Change-Id: Ide98fd1f31afabd5678c6c3c0734913f8d7785bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3156647
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920619}
pull bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
This reverts commit 4f0f07d. Reason for revert: This is causing failures on the asan/lsan bot. https://bugs.chromium.org/p/chromium/issues/detail?id=1250054 ==7374==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55b1cff1c2ce in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/ranges/algorithm.h:31:10)> ./../../buildtools/third_party/libc++/trunk/include/algorithm:942:5 #1 0x55b1cff1c2ce in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/observer_list.h:284:21), base::identity, std::__1::random_access_iterator_tag> ./../../base/ranges/algorithm.h:465:10 #2 0x55b1cff1c2ce in find_if<std::__1::vector<base::internal::UncheckedObserverAdapter, std::__1::allocator<base::internal::UncheckedObserverAdapter> > &, (lambda at ../../base/observer_list.h:284:21), base::identity, std::__1::random_access_iterator_tag> ./../../base/ranges/algorithm.h:483:10 #3 0x55b1cff1c2ce in base::ObserverList<aura::EnvObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(aura::EnvObserver const*) ./../../base/observer_list.h:283:21 #4 0x55b1b16a5284 in Reset ./../../base/scoped_observation.h:69:7 #5 0x55b1b16a5284 in base::ScopedObservation<aura::Env, aura::EnvObserver, &(aura::Env::AddObserver(aura::EnvObserver*)), &(aura::Env::RemoveObserver(aura::EnvObserver*))>::~ScopedObservation() ./../../base/scoped_observation.h:53:26 #6 0x55b1c95200e4 in ash::ArcOverlayManager::~ArcOverlayManager() ./../../ash/public/cpp/external_arc/overlay/arc_overlay_manager.cc:52:1 #7 0x55b1c9520174 in ash::ArcOverlayManager::~ArcOverlayManager() arc_overlay_manager.cc:0:0 #8 0x55b1b0a0deea in operator() ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:54:5 #9 0x55b1b0a0deea in reset ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:315:7 #10 0x55b1b0a0deea in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:269:19 #11 0x55b1b0a0deea in payments::(anonymous namespace)::AndroidPaymentAppFactoryTest::~AndroidPaymentAppFactoryTest() ./../../chrome/browser/payments/android_payment_app_factory_browsertest.cc:29:52 #12 0x55b1b0a10f5c in payments::(anonymous Original change's description: > [Web Payment] App store billing never shows browser UI. > > Before this patch, immediately resolving the promise passed into > PaymentRequest.show() (the so-called "show() promise"), e.g., by calling > PaymentRequest.show(Promise.resolve({})), would have the possibility of > both showing the browser payment sheet and invoking the payment app, > because the code did not expect that the promise would be resolved > faster than enumerating the locally installed payment apps. > > This patch prevents invoking a payment app or showing the browser > payment sheet when the show() promise resolves before the locally > installed payment apps have been enumerated. > > After this patch, immediately resolving the show() promise will not > result in both showing the browser payment sheet and invoking the > payment app at the same time. > > Bug: 1237921 > Change-Id: I132700146d6f9334a5c56d136f80fcdc62873313 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160759 > Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#921617} Bug: 1237921 Change-Id: I8a1e6c7c6080b175d180d4c37d2fbc3d7eb77af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163453 Auto-Submit: Scott Violet <sky@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/main@{#921917}
pull bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
(CFFU is short for "Conditional Focus Follow-Ups") When getDisplayMedia() is called, it returns a Promise. That Promise is eventually settled. focus() may only be called before it is settled. Previously, we just ignored late calls to focus(). Now we also raise an exception. Bug: 1215480 Change-Id: Ia0a91619c483c653c828d1f81d0110eba467a450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3165138 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#923304}
pull bot
pushed a commit
that referenced
this pull request
Sep 25, 2021
This reverts commit 77e9679. Reason for revert: Likely cause of failure Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" The failure is a crash in browser_tests. This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. Here is the first failure as an example: Retrying 1 test (retry #0) [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x556151f72449 base::debug::CollectStackTrace() #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() #9 0x5561502b8919 content::Navigator::DidNavigate() #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x5561530201e0 mojo::MessageDispatcher::Accept() #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x55615301e323 base::internal::Invoker<>::RunOnce() #20 0x556151f35f23 base::TaskAnnotator::RunTask() #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x556151fa9c4b base::MessagePumpLibevent::Run() #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x556151f18c1b base::RunLoop::Run() #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() #38 0x556150036912 content::BrowserMain() #39 0x556150bf6aed content::RunBrowserProcessMain() #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() #41 0x556150bf752e content::ContentMainRunnerImpl::Run() #42 0x556150bf5b38 content::RunContentProcess() #43 0x556150bf5c08 content::ContentMain() #44 0x5561525e3543 content::BrowserTestBase::SetUp() #45 0x556151ec12c1 InProcessBrowserTest::SetUp() #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x55614f308e8f testing::Test::Run() #48 0x55614f3097c5 testing::TestInfo::Run() #49 0x55614f309f21 testing::TestSuite::Run() #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() #51 0x55614f31338b testing::UnitTest::Run() #52 0x556151fd7ff2 base::TestSuite::Run() #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x556152613c1f content::LaunchTests() #55 0x556151e98224 LaunchChromeTests() #56 0x556151e9638b main #57 0x7f7dd56c4bf7 __libc_start_main #58 0x55614cca11ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 Here is the fourth: (different test in the same suite, different stack trace): [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x564f24b8af29 base::debug::CollectStackTrace() #1 0x564f24af2843 base::debug::StackTrace::StackTrace() #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() #9 0x564f22ed15f9 content::Navigator::DidNavigate() #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x564f24bc28cb base::MessagePumpLibevent::Run() #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x564f24b316fb base::RunLoop::Run() #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() #28 0x564f2522df45 content::RunAllPendingInMessageLoop() #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() #38 0x564f22c4f832 content::BrowserMain() #39 0x564f2380f5bd content::RunBrowserProcessMain() #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() #42 0x564f2380e608 content::RunContentProcess() #43 0x564f2380e6d8 content::ContentMain() #44 0x564f251fc233 content::BrowserTestBase::SetUp() #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x564f21f21e4f testing::Test::Run() #48 0x564f21f22785 testing::TestInfo::Run() #49 0x564f21f22ee1 testing::TestSuite::Run() #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() #51 0x564f21f2c34b testing::UnitTest::Run() #52 0x564f24bf0c72 base::TestSuite::Run() #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x564f2522c62f content::LaunchTests() #55 0x564f24ab0cf4 LaunchChromeTests() #56 0x564f24aaee5b main #57 0x7f03d336fbf7 __libc_start_main #58 0x564f1f8b94ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 Original change's description: > Privatise unnecessarily public current_input_method in > InputMethodManagerImpl::StateImpl. > > This involves replacing some direct pokes of current_input_method > with public GetCurrentInputMethod() that employs a fallback onto > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > blank. This should be more reasonable and consistent. > > Bug: 1134465 > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924702} Bug: 1134465 Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 Auto-Submit: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#924810}
pull bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
… CrosState" This reverts commit 3895114. Reason for revert: likely cause of failures Step "chromeos_components_unittests on Ubuntu-18.04" failing on builder "Linux Chromium OS ASan LSan Tests (1)" The first run with the relevant failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/40730/overview The following tests consistently fail starting after this first run: CrosStateSenderTest.NotificationFeatureStateChanged CrosStateSenderTest.PerformUpdateCrosStateRetrySequence The first fails with this stack trace: --- [ RUN ] CrosStateSenderTest.NotificationFeatureStateChanged ================================================================= ==4136==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700004b31c at pc 0x5559c16fed11 bp 0x7fffb87b9250 sp 0x7fffb87b9248 READ of size 4 at 0x60700004b31c thread T0 #0 0x5559c16fed10 in chromeos::multidevice_setup::MultiDeviceSetupClient::GetFeatureState(chromeos::multidevice_setup::mojom::Feature) const ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:51:44 #1 0x5559ce6da0ed in chromeos::phonehub::CrosStateSender::PerformUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:93:34 #2 0x5559ce6d9e1d in chromeos::phonehub::CrosStateSender::AttemptUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:85:3 #3 0x5559c17102b7 in chromeos::secure_channel::ConnectionManager::NotifyStatusChanged() ./../../chromeos/services/secure_channel/public/cpp/client/connection_manager.cc:23:14 #4 0x5559ba7314dc in chromeos::phonehub::CrosStateSenderTest_NotificationFeatureStateChanged_Test::TestBody() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:146:29 #5 0x5559baf612a1 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x5559baf612a1 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2706:5 #7 0x5559baf62ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #8 0x5559baf647b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #9 0x5559baf87628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #10 0x5559baf86d49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x5559baf86d49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #12 0x5559c6e8422f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #13 0x5559c6e8422f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #14 0x5559bd07db0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #15 0x5559c6e8a853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #16 0x5559c6e8a4d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #17 0x5559ba482d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #18 0x7f002b751bf6 in __libc_start_main ??:0:0 0x60700004b31c is located 4 bytes to the right of 72-byte region [0x60700004b2d0,0x60700004b318) allocated by thread T0 here: #0 0x5559ba47faed in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 #1 0x5559c14ad498 in __libcpp_operator_new<unsigned long> ./../../buildtools/third_party/libc++/trunk/include/new:235:10 #2 0x5559c14ad498 in __libcpp_allocate ./../../buildtools/third_party/libc++/trunk/include/new:261:10 #3 0x5559c14ad498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator.h:82:38 #4 0x5559c14ad498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator_traits.h:261:20 #5 0x5559c14ad498 in std::__1::vector<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState>, std::__1::allocator<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> > >::__vallocate(unsigned long) ./../../buildtools/third_party/libc++/trunk/include/vector:994:37 #6 0x5559c16fdfe3 in vector<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../buildtools/third_party/libc++/trunk/include/vector:1224:9 #7 0x5559c16fdfe3 in flat_tree<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../base/containers/flat_tree.h:571:20 #8 0x5559c16fdfe3 in flat_tree ./../../base/containers/flat_tree.h:595:7 #9 0x5559c16fdfe3 in flat_tree ./../../base/containers/flat_map.h:211:15 #10 0x5559c16fdfe3 in chromeos::multidevice_setup::MultiDeviceSetupClient::GenerateDefaultFeatureStatesMap() ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:21:10 #11 0x5559d736b57e in chromeos::multidevice_setup::FakeMultiDeviceSetupClient::FakeMultiDeviceSetupClient() ./../../chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup_client.cc:13:27 #12 0x5559ba733ad7 in make_unique<chromeos::multidevice_setup::FakeMultiDeviceSetupClient> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725:32 #13 0x5559ba733ad7 in chromeos::phonehub::CrosStateSenderTest::SetUp() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:40:9 #14 0x5559baf6118e in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #15 0x5559baf6118e in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2701:3 #16 0x5559baf62ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #17 0x5559baf647b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #18 0x5559baf87628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #19 0x5559baf86d49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x5559baf86d49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #21 0x5559c6e8422f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #22 0x5559c6e8422f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #23 0x5559bd07db0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #24 0x5559c6e8a853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #25 0x5559c6e8a4d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #26 0x5559ba482d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #27 0x7f002b751bf6 in __libc_start_main ??:0:0 SUMMARY: AddressSanitizer: heap-buffer-overflow (/b/s/w/ir/out/Release/chromeos_components_unittests+0x15f40d10) Shadow bytes around the buggy address: 0x0c0e80001610: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fa fa 0x0c0e80001620: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c0e80001630: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fd fd 0x0c0e80001640: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0e80001650: fd fd fd fd fd fd fa fa fa fa 00 00 00 00 00 00 =>0x0c0e80001660: 00 00 00[fa]fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0e80001670: fd fa fa fa fa fa fd fd fd fd fd fd fd fd fd fd 0x0c0e80001680: fa fa fa fa 00 00 00 00 00 00 00 00 00 00 fa fa 0x0c0e80001690: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c0e800016a0: fd fd fd fd fd fd fd fd fd fd fa fa fa fa 00 00 0x0c0e800016b0: 00 00 00 00 00 00 00 00 fa fa fa fa 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==4136==ABORTING --- The second fails with this one: --- [ RUN ] CrosStateSenderTest.PerformUpdateCrosStateRetrySequence ================================================================= ==3811==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700005f9ec at pc 0x5579c6175d11 bp 0x7ffd5e6a0e10 sp 0x7ffd5e6a0e08 READ of size 4 at 0x60700005f9ec thread T0 #0 0x5579c6175d10 in chromeos::multidevice_setup::MultiDeviceSetupClient::GetFeatureState(chromeos::multidevice_setup::mojom::Feature) const ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:51:44 #1 0x5579d31510ed in chromeos::phonehub::CrosStateSender::PerformUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:93:34 #2 0x5579d3150e1d in chromeos::phonehub::CrosStateSender::AttemptUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:85:3 #3 0x5579c61872b7 in chromeos::secure_channel::ConnectionManager::NotifyStatusChanged() ./../../chromeos/services/secure_channel/public/cpp/client/connection_manager.cc:23:14 #4 0x5579bf1a3085 in chromeos::phonehub::CrosStateSenderTest_PerformUpdateCrosStateRetrySequence_Test::TestBody() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:63:29 #5 0x5579bf9d82a1 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x5579bf9d82a1 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2706:5 #7 0x5579bf9d9ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #8 0x5579bf9db7b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #9 0x5579bf9fe628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #10 0x5579bf9fdd49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x5579bf9fdd49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #12 0x5579cb8fb22f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #13 0x5579cb8fb22f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #14 0x5579c1af4b0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #15 0x5579cb901853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #16 0x5579cb9014d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #17 0x5579beef9d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #18 0x7fc58b24bbf6 in __libc_start_main ??:0:0 0x60700005f9ec is located 4 bytes to the right of 72-byte region [0x60700005f9a0,0x60700005f9e8) allocated by thread T0 here: #0 0x5579beef6aed in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 #1 0x5579c5f24498 in __libcpp_operator_new<unsigned long> ./../../buildtools/third_party/libc++/trunk/include/new:235:10 #2 0x5579c5f24498 in __libcpp_allocate ./../../buildtools/third_party/libc++/trunk/include/new:261:10 #3 0x5579c5f24498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator.h:82:38 #4 0x5579c5f24498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator_traits.h:261:20 #5 0x5579c5f24498 in std::__1::vector<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState>, std::__1::allocator<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> > >::__vallocate(unsigned long) ./../../buildtools/third_party/libc++/trunk/include/vector:994:37 #6 0x5579c6174fe3 in vector<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../buildtools/third_party/libc++/trunk/include/vector:1224:9 #7 0x5579c6174fe3 in flat_tree<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../base/containers/flat_tree.h:571:20 #8 0x5579c6174fe3 in flat_tree ./../../base/containers/flat_tree.h:595:7 #9 0x5579c6174fe3 in flat_tree ./../../base/containers/flat_map.h:211:15 #10 0x5579c6174fe3 in chromeos::multidevice_setup::MultiDeviceSetupClient::GenerateDefaultFeatureStatesMap() ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:21:10 #11 0x5579dbde257e in chromeos::multidevice_setup::FakeMultiDeviceSetupClient::FakeMultiDeviceSetupClient() ./../../chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup_client.cc:13:27 #12 0x5579bf1aaad7 in make_unique<chromeos::multidevice_setup::FakeMultiDeviceSetupClient> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725:32 #13 0x5579bf1aaad7 in chromeos::phonehub::CrosStateSenderTest::SetUp() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:40:9 #14 0x5579bf9d818e in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #15 0x5579bf9d818e in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2701:3 #16 0x5579bf9d9ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #17 0x5579bf9db7b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #18 0x5579bf9fe628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #19 0x5579bf9fdd49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x5579bf9fdd49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #21 0x5579cb8fb22f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #22 0x5579cb8fb22f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #23 0x5579c1af4b0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #24 0x5579cb901853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #25 0x5579cb9014d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #26 0x5579beef9d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #27 0x7fc58b24bbf6 in __libc_start_main ??:0:0 SUMMARY: AddressSanitizer: heap-buffer-overflow (/b/s/w/ir/out/Release/chromeos_components_unittests+0x15f40d10) Shadow bytes around the buggy address: 0x0c0e80003ee0: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fd fd 0x0c0e80003ef0: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0e80003f00: fd fd fd fd fd fd fa fa fa fa fd fd fd fd fd fd 0x0c0e80003f10: fd fd fd fd fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0e80003f20: fd fd fa fa fa fa fd fd fd fd fd fd fd fd fd fd =>0x0c0e80003f30: fa fa fa fa 00 00 00 00 00 00 00 00 00[fa]fa fa 0x0c0e80003f40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==3811==ABORTING --- Original change's description: > [CameraRoll]Send camera roll setting to the Android device in CrosState > > Include camera roll setting state as part of CrosState, > so connected mobile device would be able to get update > when setting value is toggled. > > Change-Id: I04d0ed3872d5adeff5e8f8dc76c6eb6df3a50b9c > Bug: https://crbug.com/1221297 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173740 > Commit-Queue: Jianbing Wu <jianbing@google.com> > Auto-Submit: Jianbing Wu <jianbing@google.com> > Reviewed-by: Jon Mann <jonmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924995} Bug: https://crbug.com/1221297 Change-Id: Ic87d96786b4244b27b1e284f801df8799911b1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184482 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Mark Pearson <mpearson@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#925118}
pull bot
pushed a commit
that referenced
this pull request
Sep 28, 2021
This reverts commit 37ea471. Reason for revert: Reverted CL is unrelated to the cited "reason for revert". Original change's description: > Revert "Privatise unnecessarily public current_input_method in" > > This reverts commit 77e9679. > > Reason for revert: > Likely cause of failure > Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" > > The failure is a crash in browser_tests. > > This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. > > Here is the first failure as an example: > Retrying 1 test (retry #0) > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed > 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als > 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x556151f72449 base::debug::CollectStackTrace() > #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() > #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() > #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() > #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() > #9 0x5561502b8919 content::Navigator::DidNavigate() > #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() > #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() > #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x5561530201e0 mojo::MessageDispatcher::Accept() > #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x55615301e323 base::internal::Invoker<>::RunOnce() > #20 0x556151f35f23 base::TaskAnnotator::RunTask() > #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x556151fa9c4b base::MessagePumpLibevent::Run() > #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x556151f18c1b base::RunLoop::Run() > #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() > #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() > #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() > #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() > #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() > #38 0x556150036912 content::BrowserMain() > #39 0x556150bf6aed content::RunBrowserProcessMain() > #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() > #41 0x556150bf752e content::ContentMainRunnerImpl::Run() > #42 0x556150bf5b38 content::RunContentProcess() > #43 0x556150bf5c08 content::ContentMain() > #44 0x5561525e3543 content::BrowserTestBase::SetUp() > #45 0x556151ec12c1 InProcessBrowserTest::SetUp() > #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x55614f308e8f testing::Test::Run() > #48 0x55614f3097c5 testing::TestInfo::Run() > #49 0x55614f309f21 testing::TestSuite::Run() > #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() > #51 0x55614f31338b testing::UnitTest::Run() > #52 0x556151fd7ff2 base::TestSuite::Run() > #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x556152613c1f content::LaunchTests() > #55 0x556151e98224 LaunchChromeTests() > #56 0x556151e9638b main > #57 0x7f7dd56c4bf7 __libc_start_main > #58 0x55614cca11ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 > > Here is the fourth: (different test in the same suite, different stack trace): > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff > 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB > 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als > 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x564f24b8af29 base::debug::CollectStackTrace() > #1 0x564f24af2843 base::debug::StackTrace::StackTrace() > #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() > #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() > #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() > #9 0x564f22ed15f9 content::Navigator::DidNavigate() > #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() > #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() > #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() > #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() > #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() > #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x564f24bc28cb base::MessagePumpLibevent::Run() > #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x564f24b316fb base::RunLoop::Run() > #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() > #28 0x564f2522df45 content::RunAllPendingInMessageLoop() > #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() > #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() > #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() > #38 0x564f22c4f832 content::BrowserMain() > #39 0x564f2380f5bd content::RunBrowserProcessMain() > #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() > #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() > #42 0x564f2380e608 content::RunContentProcess() > #43 0x564f2380e6d8 content::ContentMain() > #44 0x564f251fc233 content::BrowserTestBase::SetUp() > #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() > #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x564f21f21e4f testing::Test::Run() > #48 0x564f21f22785 testing::TestInfo::Run() > #49 0x564f21f22ee1 testing::TestSuite::Run() > #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() > #51 0x564f21f2c34b testing::UnitTest::Run() > #52 0x564f24bf0c72 base::TestSuite::Run() > #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x564f2522c62f content::LaunchTests() > #55 0x564f24ab0cf4 LaunchChromeTests() > #56 0x564f24aaee5b main > #57 0x7f03d336fbf7 __libc_start_main > #58 0x564f1f8b94ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 > > Original change's description: > > Privatise unnecessarily public current_input_method in > > InputMethodManagerImpl::StateImpl. > > > > This involves replacing some direct pokes of current_input_method > > with public GetCurrentInputMethod() that employs a fallback onto > > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > > blank. This should be more reasonable and consistent. > > > > Bug: 1134465 > > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > > Reviewed-by: Keith Lee <keithlee@chromium.org> > > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#924702} > > Bug: 1134465 > Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Owners-Override: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924810} Bug: 1134465 Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#925158}
pull bot
pushed a commit
that referenced
this pull request
Sep 28, 2021
Sub-classing WKNavigationResponse appear to cause crashes in the method -dealloc when running the CRWWebControllerResponseTest.* tests individually (at least on iOS 15.0 simulator). The crash looks like this when running `ios_web_unittests` with `--gest_filter=*.DownloadRendererInitiatedDataUrlResponseInMainFrame`: [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from CRWWebControllerResponseTest [ RUN ] CRWWebControllerResponseTest.DownloadRendererInitiatedDataUrlResponseInMainFrame (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x30) frame #0: 0x00007fff334ff702 JavaScriptCore`WTF::RunLoop::dispatch(WTF::Function<void ()>&&) + 34 frame #1: 0x00007fff2aa131e4 WebCore`WebCoreObjCScheduleDeallocateOnMainRunLoop(objc_class*, objc_object*) + 68 frame #2: 0x00007fff297645a9 WebKit`-[WKNavigationResponse dealloc] + 37 frame #3: 0x00007fff2019c9f7 libobjc.A.dylib`objc_object::sidetable_release(bool, bool) + 177 * frame #4: 0x000000010602060f ios_web_unittests`web::CRWWebControllerResponseTest::CallDecidePolicyForNavigationResponseWithResponse(this=0x00007fc002b06a70, response=0x000060000008ce40, for_main_frame=YES, can_show_mime_type=YES, out_policy=0x00007ffee9d27238) at crw_web_controller_unittest.mm:553:3 frame #5: 0x0000000106021041 ios_web_unittests`web::CRWWebControllerResponseTest_DownloadRendererInitiatedDataUrlResponseInMainFrame_Test::TestBody(this=0x00007fc002b06a70) at crw_web_controller_unittest.mm:613:3 frame #6: 0x0000000106539c3b ios_web_unittests`void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(object=0x00007fc002b06a70, method=21 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, location="the test body")(), char const*) at gtest.cc:2631:10 Instead use OCMock to create a mock and to stub the values returned by the WKNavigationResponse properties' accessor. This fixes the crash as no WKNavigationResponse are created and thus the destructor is no longer called). Bug: none Change-Id: I063b3d52af2b91d57f0a08d6799c08eba908a3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3186913 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/main@{#925317}
pull bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
The sequence of events:
1) Page A starts a prerender to page B
2) Page B creates an AsyncDocumentSubresourceFilter for its main RFH
3) Page B navigates a cross-origin subframe
4) Because it's cross-origin in a prerender, the
PrerenderSubframeNavigationThrottle defers the subframe navigation
at WillStartRequest.
5) The user now navigates to page B causing a prerender activation
6) The prerender activation creates a main frame, cross-document
navigation in the primary frame tree. This doesn't run navigation
throttles but the ContentSubresourceFilterThrottleManager sees this
as a regular navigation in the main frame and creates a new
AsyncDocumentSubresourceFilter for the navigation's RFH. Because
prerendering activation only moves a page from the prerender frame
tree into the primary frame tree, the RFH is preserved so this is
the same RFH as in step #2
7) CSFTM keeps track of AsyncDocumentSubresourceFilters in a
RFH->Filter map. So the new filter overwrites the one created in
step #2. This deletes the first filter since the map owns it.
8) Now that the prerendering page has entered the primary frame tree,
the subframe navigation from step #4 is resumed.
9) The subframe navigation runs the
SubframeNavigationFilteringThrottle, which was created in step #3
and has a raw pointer to the AsyncDocumentSubresourceFilter from
step #2. However, this filter was deleted in step #7 so this points
to freed memory. The throttle calls a method on this bad pointer and
we eventually crash somewhere.
This issue is fixed in https://crrev.com/c/3018307 by making each
throttle manager responsible for a single page. This CL only adds a test
for this specific situation.
A small note about the test, we changed from registering throttles in
DidStartNavigation to the ContentBrowserClient.
RegisterThrottleForTesting adds throttles to the end of the throttle
runner which meant we run a different throttle ordering in tests. In
particular, the reproduction required that the
SubframeNavigationFilteringThrottle run WillStartRequest before being
blocked on prerendering in step #4, before the filter was overwritten.
Using RegisterThrottleForTesting meant it would only be run after the
prerender was activated.
Bug: 1203614
Change-Id: I24ab77a04b9032933cfa45a167145139465c58ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033462
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926616}
pull bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
This reverts commit cc5a8ac. Reason for revert: Test crashes on Android Pie bot Sample failing test run https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/6303 Original change's description: > [MPArch] Test prerendering crash in subresource filter > > The sequence of events: > > 1) Page A starts a prerender to page B > 2) Page B creates an AsyncDocumentSubresourceFilter for its main RFH > 3) Page B navigates a cross-origin subframe > 4) Because it's cross-origin in a prerender, the > PrerenderSubframeNavigationThrottle defers the subframe navigation > at WillStartRequest. > 5) The user now navigates to page B causing a prerender activation > 6) The prerender activation creates a main frame, cross-document > navigation in the primary frame tree. This doesn't run navigation > throttles but the ContentSubresourceFilterThrottleManager sees this > as a regular navigation in the main frame and creates a new > AsyncDocumentSubresourceFilter for the navigation's RFH. Because > prerendering activation only moves a page from the prerender frame > tree into the primary frame tree, the RFH is preserved so this is > the same RFH as in step #2 > 7) CSFTM keeps track of AsyncDocumentSubresourceFilters in a > RFH->Filter map. So the new filter overwrites the one created in > step #2. This deletes the first filter since the map owns it. > 8) Now that the prerendering page has entered the primary frame tree, > the subframe navigation from step #4 is resumed. > 9) The subframe navigation runs the > SubframeNavigationFilteringThrottle, which was created in step #3 > and has a raw pointer to the AsyncDocumentSubresourceFilter from > step #2. However, this filter was deleted in step #7 so this points > to freed memory. The throttle calls a method on this bad pointer and > we eventually crash somewhere. > > This issue is fixed in https://crrev.com/c/3018307 by making each > throttle manager responsible for a single page. This CL only adds a test > for this specific situation. > > A small note about the test, we changed from registering throttles in > DidStartNavigation to the ContentBrowserClient. > RegisterThrottleForTesting adds throttles to the end of the throttle > runner which meant we run a different throttle ordering in tests. In > particular, the reproduction required that the > SubframeNavigationFilteringThrottle run WillStartRequest before being > blocked on prerendering in step #4, before the filter was overwritten. > Using RegisterThrottleForTesting meant it would only be run after the > prerender was activated. > > Bug: 1203614 > Change-Id: I24ab77a04b9032933cfa45a167145139465c58ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033462 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926616} Bug: 1203614 Change-Id: I867c0641701cde250e9c3860dc787a4c32b4a81d Owners-Override: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199971 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/main@{#927378}
pull bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
…ch providers."." This reverts commit 23f829c. Reason for revert: Breaks TranslateManagerRenderViewHostTest.BubbleUnknownLanguage on linux-chromeos-chrome [ RUN ] TranslateManagerRenderViewHostTest.BubbleUnknownLanguage Received signal 11 SEGV_MAPERR 000000000108 #0 0x56400916c589 base::debug::CollectStackTrace() #1 0x5640090da7c3 base::debug::StackTrace::StackTrace() #2 0x56400916c0df base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fc34d615980 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1297f) #4 0x56400acc1794 TemplateURLService::GetDefaultSearchProvider() #5 0x564009765d6a RenderViewContextMenu::IsRegionSearchEnabled() #6 0x564009762d17 RenderViewContextMenu::AppendPageItems() #7 0x564009762838 RenderViewContextMenu::InitMenu() #8 0x56400886430c RenderViewContextMenuBase::Init() #9 0x5640034ae263 translate::(anonymous namespace)::TranslateManagerRenderViewHostTest_BubbleUnknownLanguage_Test::TestBody() ... Original change's description: > Reland "Add region search support for non-Google default search providers.". > > This an attempted reland of the following reverted change: > https://chromium-review.googlesource.com/c/chromium/src/+/3199698 > > PS1 is identical to the original change with a few minor modifications to resolve merge conflicts. > > The changes from the original is the adding of an instance variable to LensRegionSearchController representing whether the default search engine is Google. This could not be used in the controller directly due to an include rule. This is now instead passed as part of the Start() function through render_view_context_menu. > > > Bug: 1255702,1255897, b/198833501 > Change-Id: I83c4b0a5728ab3ba122d248c05c2f27b76a05a4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203970 > Commit-Queue: Juan Mojica <juanmojica@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ben Goldberger <benwgold@google.com> > Cr-Commit-Position: refs/heads/main@{#928974} Bug: 1255702,1255897, b/198833501 Change-Id: I1bf2e732ac781a5708f4a319ecf5df960239a860 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210916 Auto-Submit: Timothy Loh <timloh@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Owners-Override: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/main@{#929066}
pull bot
pushed a commit
that referenced
this pull request
Oct 18, 2021
This reverts commit 842626c. Reason for revert: [sheriff] suspected to cause multiple failures in SafetyTipPageInfoBubbleViewBrowserTests on linux-ubsan-vptr: https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr/6970 Sample failure: [ RUN ] All/SafetyTipPageInfoBubbleViewBrowserTest.BubbleWaitsForVisible/1 [...] ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23: runtime error: downcast of address 0x180601885e00 which does not point to an object of type 'PageInfoBubbleView' 0x180601885e00: note: object is of type 'PageInfoNewBubbleView' 00 00 00 00 18 70 11 10 50 56 00 00 80 68 50 01 06 18 00 00 b8 00 00 00 30 00 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'PageInfoNewBubbleView' #0 0x564ffa77d440 in SafetyTipPageInfoBubbleViewBrowserTest::CheckPageInfoShowsSafetyTipInfo(Browser*, security_state::SafetyTipStatus, GURL const&) chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 #1 0x564ffa788397 in SafetyTipPageInfoBubbleViewBrowserTest_BubbleWaitsForVisible_Test::RunTestOnMainThread() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:837:3 #2 0x565002ae1026 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:868:7 #3 0x565001aae15a in Run base/callback.h:142:12 #4 0x565001aae15a in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1745:38 #5 0x565001aaba50 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1083:18 #6 0x564ffd8e2f00 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:957:28 #7 0x564ffe307f82 in Run base/callback.h:142:12 #8 0x564ffe307f82 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:41:29 #9 0x564ffd8e2368 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:865:25 #10 0x564ffd8e889c in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:131:15 #11 0x564ffd8dec1e in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:45:32 #12 0x564fff2a06e8 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:641:10 #13 0x564fff2a2e90 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) content/app/content_main_runner_impl.cc:1137:10 #14 0x564fff2a1f18 in content::ContentMainRunnerImpl::Run(bool) content_main_runner_impl.cc #15 0x564fff29dde0 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) content_main.cc #16 0x564fff29e7dd in content::ContentMain(content::ContentMainParams const&) content_main.cc #17 0x565002adfcff in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:712:3 #18 0x5650018271c4 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:401:20 #19 0x564ffa79d759 in SafetyTipPageInfoBubbleViewBrowserTest::SetUp() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:306:27 #20 0x564ffb8f8c7d in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2701:3 #21 0x564ffb8fa600 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2885:11 #22 0x564ffb8fc1bb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3044:30 #23 0x564ffb9115ca in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5903:44 #24 0x564ffb90fd8c in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5470:10 #25 0x565001a12e28 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #26 0x565001a12e28 in base::TestSuite::Run() base/test/test_suite.cc:445:16 #27 0x5650017d0bac in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:88:22 #28 0x5650017d0c1b in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome_test_launcher.cc #29 0x565002b8529b in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:409:31 #30 0x5650017d11b1 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:284:10 #31 0x5650017c9dcc in main chrome/test/base/browser_tests_main.cc:61:10 #32 0x7fc242b01bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6) #33 0x564ff76da7e9 in _start (/b/s/w/ir/out/Release/browser_tests+0xe8af7e9) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 in Original change's description: > Enable PageInfoV2Desktop by default > > Enable flag and remove testing config. > > Bug: 1188101 > Change-Id: Ifd839436f3d4c0127d15b449bbca84855ccd858f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217207 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Cr-Commit-Position: refs/heads/main@{#931972} Bug: 1188101 Change-Id: Ic51b9fdc730b7046e24b4d394248218b86eef09d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226638 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932067}
pull bot
pushed a commit
that referenced
this pull request
Oct 18, 2021
… off" This reverts commit 7db902d. Reason for revert: [sheriff] suspected to cause multiple AccountProfileMapperTest failures on linux-lacros-tester-rel: First failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/16078 Sample failure: [ RUN ] AccountProfileMapperTest.RemovePrimaryAccountFromPrimaryProfile Received signal 11 SEGV_MAPERR 209300000105 #0 0x5584a2716cd9 base::debug::CollectStackTrace() #1 0x5584a2684db3 base::debug::StackTrace::StackTrace() #2 0x5584a2716823 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f9750773980 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1297f) #4 0x5584a269ec4c base::internal::WeakReference::IsValid() #5 0x55849d569978 base::ObserverList<>::RemoveObserver() #6 0x5584a2edaf01 ProfileAccountManager::Shutdown() #7 0x5584a377e0bc DependencyManager::PerformInterlockedTwoPhaseShutdown() #8 0x5584a1be43ae TestingProfile::~TestingProfile() #9 0x55849cf239ae (anonymous namespace)::PermissionManagerTestingProfile::~PermissionManagerTestingProfile() #10 0x5584a2d094bf ProfileDestroyer::DestroyOriginalProfileNow() #11 0x5584a2d091ed ProfileDestroyer::DestroyProfileWhenAppropriate() #12 0x5584a2d1a886 ProfileManager::ProfileInfo::~ProfileInfo() #13 0x5584a1be6fef std::__1::__tree<>::destroy() #14 0x5584a2d1ca09 ProfileManager::~ProfileManager() #15 0x5584a1be14ae FakeProfileManager::~FakeProfileManager() #16 0x5584a1be5d12 TestingProfileManager::~TestingProfileManager() #17 0x55849dc1309b AccountProfileMapperTest_GetAccounts_Test::~AccountProfileMapperTest_GetAccounts_Test() #18 0x55849ef2f92c testing::TestInfo::Run() #19 0x55849ef30617 testing::TestSuite::Run() Original change's description: > [Lacros] Do not create AccountProfileMapper if the feature is off > > AccountProfileMapper should only be created if the > kMultiProfileAccountConsistency feature is enabled. Otherwise, it might > have negative side-effects like deleting user profiles. > > To add a DCHECK(kMultiProfileAccountConsistency) to > AccountProfileMapper, > this CL also enables kMultiProfileAccountConsistency in all related > unit tests. This appears to be a non-trivial task because ProfileManager > will now create its own instance of AccountProfileMapper that doesn't > use an AccountManagerFacade mock. > > This CL adds a TestingProfileManager::SetAccountProfileMapper() methods > to inject a fake instance for testing. > > Bug: 1226045 > Change-Id: I69f74aed3f4bd9bdb107912d5e92872d53691a07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222809 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#931942} Bug: 1226045 Change-Id: If5ee60910f6cba1aabc407dba814448f538a2d39 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227179 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932071}
pull bot
pushed a commit
that referenced
this pull request
Oct 19, 2021
Previously, these files lived in media/capture/. However, nothing that relies on them lives there; rather, everything related to them lives in third_party/blink/. We therefore move these files. This unblocks the use of WTF::CrossThreadFunction etc. by these files. Bug: 1247761 Change-Id: I625fd18ebeba20cea06f55b04463deae9f821917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222595 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#932947}
pull bot
pushed a commit
that referenced
this pull request
Oct 22, 2021
RTCPeerConnectionIceErrorEvent.hostCandidate was marked as deprecated in commit 72c1e71 "Replace hostCandidate with address and port in RTCPeerConnectionIceErrorEvent". Unfortunately the patch did not provide any deprecation message for the feature. As result of this any page using this deprecated functionality will trigger the following DCHECK: [355328:1:0721/120654.530860:9505576756:FATAL:deprecation.cc(743)] Check failed: !info.message.IsEmpty(). #0 0x55c97295dd69 base::debug::CollectStackTrace() #1 0x55c97289f6d3 base::debug::StackTrace::StackTrace() #2 0x55c9728b99d6 logging::LogMessage::~LogMessage() #3 0x55c9728ba46e logging::LogMessage::~LogMessage() #4 0x55c9740389fa blink::Deprecation::CountDeprecation() #5 0x55c97572dd1d blink::(anonymous namespace)::v8_rtc_peer_connection_ice_error_event::HostCandidateAttributeGetCallback() Change-Id: I3f992b802e54d469aaab5bfa68da32e505a48319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3041592 Auto-Submit: Piotr Tworek <ptworek@vewd.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#933993}
pull bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
Overall feature: ---------------- Region Capture is a feature allowing the cropping of self-capture video tracks to track the coordinates of an HTMLElement in the browsing context. Public design-doc: https://docs.google.com/document/d/1dULARMnMZggfWqa_Ti_GrINRNYXGIli3XK9brzAKEV8/edit?usp=sharing Spec draft (very WIP): https://eladalon1983.github.io/region-capture/ (This will be finished soon and moved to the WICG; hopefully to be eventually adopted by the W3C.) This CL: -------- This patch includes the final changes to get produceCropId working end to end, by connecting the CC changes and Viz changes landed in previous patches through the compositor frame metadata class. Instead of putting the capture bounds on individual render passes, the capture bounds now reside on the CompositorFrameMetadata class and are populated by the LayerTreeHostImpl. Next CLs: --------- No implementation patches, only bug fixes and cleanups from here on out! Bug: 1247761 Change-Id: I0a7527020e239dca0aef25c1f531179ca06cf757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229811 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/main@{#937202}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.