This repository has been archived by the owner on Jun 19, 2021. It is now read-only.
Lithium: cache chunk gen sea level #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duplexsystem
force-pushed
the
ver/1.16.5
branch
from
0f2abe7
to
372911f
Compare
Titaniumtown
force-pushed
the
lithium/cache-sea-level
branch
from
2e32852
to
2c4854b
Compare
MrIvanPlays
previously requested changes
Jan 23, 2021
Titaniumtown
dismissed
MrIvanPlays’s stale review
in this case, obfhelpers screw up everything so they shouldn't be added.
Titaniumtown
added
the
Ready for Review
…thium/cache-sea-level
…thium/cache-sea-level
|
Note: The PR to lithium was recently merged. Any more thoughts? |
ishland
previously requested changes
Jan 25, 2021
Titaniumtown
requested review from
ishland
and removed request for
MrIvanPlays
|
Seems they changed it before pushing to lithium, so I have to update the patch: CaffeineMC/lithium-fabric@a55cfd1 |
ishland
approved these changes
Jan 25, 2021
ishland
added a commit
that referenced
this pull request
Feb 1, 2021
* add config for sand duping (#352) * Lithium: cache chunk gen sea level (#349) based off: CaffeineMC/lithium-fabric@a55cfd1 * PaperPR: Inline shift fields in EnumDirection (#350) * Introducing: Yatoclip (#360) * New async nbt cache (#347) * update pom * whoops * Try to address path issue and improve Jenkins build speed * Detailed lag and crash reports (#369) Added "Suspected Plugins" to Watchdog and crash reports * Drop sand duping * Add branch specific versions * Remove copyright * Revert mysql-connector-java version bump * Small fixes * More detailed lag and crash reports * Don't use branch information when generating metadata * Fix Jenkins Builds version command * Fixup patches * Fix patch notes * Pull Request compatibility for branch detection * Fix Pull Request compatibility for branch detection * Set context classloader before launch * Inject server jar to SystemClassLoader before launch * Try fix compile in java8 * Run tests on CodeMC and Github Actions Co-authored-by: Simon Gardling <Titaniumtown@gmail.com> Co-authored-by: Zoe <duplexsys@protonmail.com> Co-authored-by: Hugo Planque <12386279+HookWoods@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the optimization from: CaffeineMC/lithium-fabric#179 (just recently merged)
Making it so the sea level chunk gen setting is cached instead of calling for it
every single time a block is placed by the generator, for a total of 65536 registry lookups per chunk. While this isn't a huge performance boost, it's still there. SuperCoder7979 said that13% of CPU time spent in populateNoise without the patch vs 10% with the patch