Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pyflakes to travis CI #268

Closed
bukzor opened this issue Jul 11, 2014 · 4 comments
Closed

add pyflakes to travis CI #268

bukzor opened this issue Jul 11, 2014 · 4 comments

Comments

@bukzor
Copy link
Contributor

bukzor commented Jul 11, 2014

Somehow we run pyflakes in jenkins but not travis.
This should not be.
@bukzor
Copy link
Contributor Author

bukzor commented Jul 11, 2014

@astephen2

@rambleraptor
Copy link
Contributor

I agree with this one hundred percent. It's messed me up several times. I can make the change if you'd like.

(I'm assuming I'm being pinged from my recent transgressions with pyflakes..?)

@bukzor
Copy link
Contributor Author

bukzor commented Jul 12, 2014

Please, feel free

--phone is hard.
On Jul 11, 2014 11:48 AM, "Alex Stephen" notifications@github.com wrote:

I agree with this one hundred percent. It's messed me up several times. I
can make the change if you'd like.

—
Reply to this email directly or view it on GitHub
#268 (comment).

@rambleraptor rambleraptor mentioned this issue Jul 14, 2014
Closed
@bukzor
Copy link
Contributor Author

bukzor commented Jul 18, 2014

pyflakes is added to travis, in the form of flake8.
Now we need tickets to clean up the ignored flake8 rules.

@bukzor bukzor closed this as completed Jul 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made makefile changes for Travis CI to use pyflakes rambleraptor/Testify
2 participants
@bukzor @rambleraptor