Skip to content

Fix typing errors from TS and the Flow codegen template #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2020
Merged

Fix typing errors from TS and the Flow codegen template #28

merged 2 commits into from
Mar 11, 2020

Conversation

ryanruanwork
Copy link
Contributor

Fix some issues about typings and build process

  1. use yarn flowgen instead of flowgen in Makefile
  2. add node version in package.json
  3. fix TS error and use @ts-ignore
  4. fix flow type error in genFlowType.ts

@ryanruanwork ryanruanwork requested a review from magicmark March 11, 2020 19:11
magicmark
magicmark reviewed Mar 11, 2020
View reviewed changes
src/genTypeFlow.ts

if (resourceConfig.isBatchResource) {
retVal = `$ElementType<${retVal}, 0>`;
retVal = resourceConfig.isResponseDictionary ? `$Values<${retVal}>` : `$ElementType<${retVal}, 0>`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch that this needs fixing :)

magicmark
magicmark approved these changes Mar 11, 2020
View reviewed changes
Copy link
Collaborator

@magicmark magicmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@ryanruanwork ryanruanwork merged commit d3a1fcf into master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmark magicmark magicmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanruanwork @magicmark