Review fixes

detect_secrets/plugins/core/yaml_file_parser.py

@@ -113,6 +113,17 @@ def _create_key_value_pair_for_mapping_node_value(key, value, tag):
         )
 
     def get_ignored_lines(self):
+        """
+        Return a set of integers that refer to line numbers that were
+        whitelisted by the user and should be ignored.
+
+        We need to parse the file separately from PyYAML parsing because
+        the parser drops the comments (at least up to version 3.13):
+        https://github.com/yaml/pyyaml/blob/a2d481b8dbd2b352cb001f07091ccf669227290f/lib3/yaml/scanner.py#L749
+
+        :return: set
+        """
+
         ignored_lines = set()
 
         for line_number, line in enumerate(self.content.split('\n'), 1):

detect_secrets/plugins/high_entropy_strings.py

@@ -160,15 +160,16 @@ def _analyze_yaml_file(self, file, filename):
                 item = to_search.pop()
 
                 try:
+                    if '__line__' in item and not item['__line__'] in ignored_lines:
+                        potential_secrets.update(
+                            self.analyze_string(
+                                item['__value__'],
+                                item['__line__'],
+                                filename,
+                            ),
+                        )
+
                     if '__line__' in item:
-                        if not item['__line__'] in ignored_lines:
-                            potential_secrets.update(
-                                self.analyze_string(
-                                    item['__value__'],
-                                    item['__line__'],
-                                    filename,
-                                ),
-                            )
                         continue
 
                     for key in item: