Merge pull request #125 from killuazhu/contribute-relax-whitelist-token

feat: relax check on whitelist string
Yelp · Feb 7, 2019 · 8e4190f · 8e4190f
2 parents 8a14e43 + 7e43b91
commit 8e4190f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/detect_secrets/plugins/common/constants.py b/detect_secrets/plugins/common/constants.py
@@ -4,11 +4,11 @@
 WHITELIST_REGEXES = [
     re.compile(r)
     for r in [
-        r'[ \t]+{} ?pragma: ?whitelist[ -]secret{}[ \t]*$'.format(start, end)
+        r'[ \t]+{} *pragma: ?whitelist[ -]secret{}[ \t]*$'.format(start, end)
         for start, end in (
             ('#', ''),              # e.g. python or yaml
             ('//', ''),             # e.g. golang
-            (r'/\*', r' ?\*/'),     # e.g. c
+            (r'/\*', r' *\*/'),     # e.g. c
             ('\'', ''),             # e.g. visual basic .net
             ('--', ''),             # e.g. sql
             # many other inline comment syntaxes are not included,

diff --git a/tests/plugins/high_entropy_strings_test.py b/tests/plugins/high_entropy_strings_test.py
@@ -98,10 +98,15 @@ def test_analyze_multiple_strings_same_line(self, content_to_format, expected_re
         [
             # Test inline annotation for whitelisting
             "'{secret}'  # pragma: whitelist secret",
+            "'{secret}' #  pragma: whitelist secret",
             "'{secret}'  // pragma: whitelist secret",
+            "'{secret}' //  pragma: whitelist secret",
             "'{secret}'  /* pragma: whitelist secret */",
+            "'{secret}' /*  pragma: whitelist secret  */",
             "'{secret}'  ' pragma: whitelist secret",
+            "'{secret}' '  pragma: whitelist secret",
             "'{secret}'  -- pragma: whitelist secret",
+            "'{secret}' --  pragma: whitelist secret",
             # Test high entropy exclude regex
             '"CanonicalUser": "{secret}"',
             # Not a string