↪️ Merge pull request #228 from OiCMudkips/fix_audit_highlight_valuee…

…rror_crash Don't crash audit when highlighter fails in audit
Yelp · Aug 21, 2019 · cba0446 · cba0446
2 parents 17918d8 + 49256ff
commit cba0446
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/detect_secrets/core/audit.py b/detect_secrets/core/audit.py
@@ -614,7 +614,10 @@ def _get_secret_with_context(
             filename,
         )
 
-        snippet.highlight_line(raw_secret_value)
+        try:
+            snippet.highlight_line(raw_secret_value)
+        except ValueError:
+            raise SecretNotFoundOnSpecifiedLineError(secret['line_number'])
     except SecretNotFoundOnSpecifiedLineError:
         if not force:
             raise

diff --git a/detect_secrets/pre_commit_hook.py b/detect_secrets/pre_commit_hook.py
@@ -141,7 +141,7 @@ def raise_exception_if_baseline_file_is_unstaged(filename):
                 '--name-only',
             ],
         ).split()
-    except subprocess.CalledProcessError:
+    except subprocess.CalledProcessError:  # pragma: no cover
         # Since we don't pipe stderr, we get free logging through git.
         raise ValueError