Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent detect-secrets from reordering the dicts in baseline #24

Closed
KevinHock opened this issue Jun 14, 2018 · 1 comment
Closed

Prevent detect-secrets from reordering the dicts in baseline #24

KevinHock opened this issue Jun 14, 2018 · 1 comment
Assignees
@KevinHock

Comments

@KevinHock
Copy link
Collaborator

This prevents unnecessary baseline modifications.

So we json.dumps a dictionary, not an ordered dictionary, so doing sort_keys=True in the json.dumps here should fix it.
@KevinHock KevinHock self-assigned this Jun 14, 2018
@KevinHock
Copy link
Collaborator Author

Fixed in #25

@KevinHock KevinHock added the bug label May 16, 2019
jimmyhlee94 added a commit to jimmyhlee94/detect-secrets that referenced this issue Aug 25, 2021
@jimmyhlee94
Merge pull request Yelp#24 from jimmyhlee94/port-square-oauth-detector
53b296b 
porting square oauth detector from yelp's upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinHock KevinHock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KevinHock