keyword plugin can hang on very long lines #372
Labels
pending
The issue still needs to be reviewed by one of the maintainers.
Comments
jimmyhlee94
pushed a commit
to jimmyhlee94/detect-secrets
that referenced
this issue
Aug 19, 2021
Co-authored-by: detect-secrets-updater <detect-secrets-updater@ibm.com> Co-authored-by: Justin D Eyster <Justin.Eyster@ibm.com>
lorenzodb1
added
the
pending
|
This has been fixed with #373. I tested the above file and this runs in 0:00.42. I will consider this resolved. If you have any other questions or you do not consider this resolved - please re-open an issue and the team will be happy to assist. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Scanning a very long line causes a hang at denylist_regex.search(string) in keyword.py for the FOLLOWED_BY_QUOTES_AND_SEMICOLON_REGEX regex.
The attached file VeryLongLine.zip has a 100,000 character line and hangs for at least 15 minutes before I kill it. That file is derived from a real source file.
I'll make a PR for the pre-v1-launch branch. The problem also happens with the master branch.
The text was updated successfully, but these errors were encountered: