Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make excluding whitelisted lines part of the base plugin #93

Closed
KevinHock opened this issue Nov 5, 2018 · 0 comments
Closed

Make excluding whitelisted lines part of the base plugin #93

KevinHock opened this issue Nov 5, 2018 · 0 comments
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.

Comments

@KevinHock
Copy link
Collaborator

So that we do not have to repeat

if WHITELIST_REGEX.search(string):
            return output

in each plugin

If possible
@KevinHock KevinHock added help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. good first issue The issue can be tackled by someone who has little to no knowledge about the project. labels Nov 5, 2018
@calvinli calvinli mentioned this issue Dec 6, 2018
Merged
calvinli added a commit that referenced this issue Dec 7, 2018
@calvinli
Merge pull request #99 from Yelp/whitelist_in_base_plugin
564615f 
check the whitelist regex in the base plugin class  (for #93)
@calvinli calvinli closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevinHock @calvinli