Fix 'no plugins found' bug on python > 3.7 #482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the 'no plugins found' bug on python > 3.7 by explicitly passing the current settings object to an initialization function that runs before the multiprocessing job is started. This initialization creates a new settings object for that process and sets its properties equal to that of the settings object passed from the parent process.
benjivesterby
approved these changes
Oct 29, 2021
domanchi
reviewed
Nov 9, 2021
Comment on lines
+95
to
+96
| initializer=initialize_settings, | ||
| initargs=(get_settings(),), |
There was a problem hiding this comment.
Suggested change
| initializer=initialize_settings, | |
| initargs=(get_settings(),), | |
| initializer=configure_settings_from_baseline, | |
| initargs=(get_settings().json(),), |
Instead of passing around Python objects (and repeating the logic found in detect_secrets.settings.configure_settings_from_baseline), does this work instead?
Or, if we wanted to optimize it even more, we can create the JSON representation once, and pass it into initargs.
|
Closing as this was merged as part of #505 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the 'no plugins found' bug on python > 3.7 by explicitly passing
the current settings object to an initialization function that runs
before the multiprocessing job is started. This initialization creates a
new settings object for that process and sets its properties equal to
that of the settings object passed from the parent process.