-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for audit #83
Merged
Merged
Fixes for audit #83
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5c99790
Fix keyword plugin failing to find the secret in audit mode
02e93b8
Fix handling of files without \n at end of file
081f3d8
Simplify the keyword plugin
191bbb5
Simplify and improve performance of the keyword plugin
01cde91
Add a test case for uppercase keyword
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ def analyze_string(self, string, line_num, filename): | |
if WHITELIST_REGEX.search(string): | ||
return output | ||
|
||
for identifier in self.secret_generator(string.lower()): | ||
for identifier in self.secret_generator(string): | ||
secret = PotentialSecret( | ||
self.secret_type, | ||
filename, | ||
|
@@ -68,5 +68,5 @@ def analyze_string(self, string, line_num, filename): | |
|
||
def secret_generator(self, string): | ||
for line in BLACKLIST: | ||
if line in string: | ||
if line.lower() in string.lower(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not just change |
||
yield line |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably more performant to make the string lowered once here, and passed into
secret_generator
, than to make it.lower()
every time.