Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HPA for paasta services(k8s deployments) #2362

Merged
merged 9 commits into from
Aug 29, 2019
Merged

Add HPA for paasta services(k8s deployments) #2362

merged 9 commits into from
Aug 29, 2019

Conversation

mzq592
Copy link
Contributor

@mzq592 mzq592 commented Aug 9, 2019 •
edited
Loading

Summary

  • HPA is only created for deployments.
  • Whenever setup_kubernetes_job runs, HPA is synced to the lastest autoscaling setting. It is created, updated, or deleted based on yelpsoa_config setting.
  • existing number of replicas in deployment objects do not change when the service is updated if autoscaling is enabled.
  • I assume when instance keyword exists in yelpsoa_config, autoscaling is disabled.

Tested on kubestage.
https://fluffy.yelpcorp.com/i/rcMS6M9r6jVP8ncJ557z6lQb5RRFsDzq.html

@mzq592 mzq592 requested review from qui and solarkennedy August 9, 2019 01:06
@mzq592 mzq592 changed the title Add HPA for paasta services(k8s deployments) (WIP)Add HPA for paasta services(k8s deployments) Aug 9, 2019
@mzq592 mzq592 changed the title (WIP)Add HPA for paasta services(k8s deployments) Add HPA for paasta services(k8s deployments) Aug 12, 2019
@mzq592 mzq592 requested a review from mattmb August 12, 2019 23:04
vkhromov
vkhromov suggested changes Aug 13, 2019
View reviewed changes
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes_tools.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes_tools.py Show resolved Hide resolved
@mzq592 mzq592 requested review from vkhromov and mattmb August 14, 2019 19:55
qui
qui suggested changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@qui qui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did not mean to approve just now.

@mzq592 mzq592 requested a review from qui August 16, 2019 20:05
qui
qui reviewed Aug 22, 2019
View reviewed changes
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes_tools.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes_tools.py Show resolved Hide resolved
paasta_tools/kubernetes_tools.py Outdated Show resolved Hide resolved
tests/kubernetes/application/test_controller_wrapper.py Outdated Show resolved Hide resolved
tests/kubernetes/application/test_controller_wrapper.py Show resolved Hide resolved
tests/kubernetes/application/test_controller_wrapper.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes/application/controller_wrappers.py Show resolved Hide resolved
paasta_tools/kubernetes_tools.py Outdated Show resolved Hide resolved
@mzq592 mzq592 requested a review from qui August 29, 2019 18:03
@mzq592 mzq592 merged commit e55bf81 into master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qui qui qui approved these changes

@solarkennedy solarkennedy Awaiting requested review from solarkennedy

@vkhromov vkhromov Awaiting requested review from vkhromov

@mattmb mattmb Awaiting requested review from mattmb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzq592 @vkhromov @qui @mattmb