Migrate from docker-py to docker #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHA has forced our hand by updating the version of Docker in their Ubuntu runners :p
nemacysts
requested review from
EvanKrall,
jfongatyelp,
cuza,
EmanElsaban and
KaspariK
nemacysts
commented
Jun 13, 2024
| # Don't update this unless you have confirmed the client works with | ||
| # the Docker version deployed on PaaSTA servers | ||
| docker-py >= 1.2.3 | ||
| docker |
There was a problem hiding this comment.
none of
- https://github.com/docker/docker-py/releases/tag/2.0.0
- https://github.com/docker/docker-py/releases/tag/3.0.0
- https://github.com/docker/docker-py/releases/tag/4.0.0
- https://github.com/docker/docker-py/releases/tag/5.0.0
appear to mention being incompatible with our current docker version
There was a problem hiding this comment.
that said, i can also run this on some infrastage boxes before merging this to make sure that we're not being misled by the tests passing on devboxes/GHA
There was a problem hiding this comment.
fwiw: docker the library not working wouldn't cause an outage - it would just break oom logging and some cleanup cronjobs.
this was a lot scarier in the mesos days :)
There was a problem hiding this comment.
as far as i can tell with my manual testing on an infrastage box/my devbox, this works as expected :)
jfongatyelp
approved these changes
Jun 14, 2024
cuza
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHA has forced our hand by updating the version of Docker in their Ubuntu runners :p