Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrtyler rejigger status #69

Merged
merged 3 commits into from
Nov 20, 2015
Merged

Mrtyler rejigger status #69

merged 3 commits into from
Nov 20, 2015

Conversation

mrtyler
Copy link
Contributor

@mrtyler mrtyler commented Nov 20, 2015

This addresses some concerns brought up by carroux way back in review:115197:

  • paasta level "started/stopped" (i.e. the result of "paasta stop/start") is only accurate at the instance level. It is wrong and misleading to display it for each config
  • "enabled/disabled" is not very clear

After some thinking and some consultation with mfield, here's what I did:

  • paasta level "started/stopped" is reported only at the top level (parallel with git sha), and no longer as part of individual configs
  • Change "enabled/disabled" to "scheduled/not scheduled"
    -- mfield noticed that there are sort of three states here: enabled, disabled because the whole service is disabled, disabled because this is an old version that we're keeping around for history. We couldn't think of a great way to communicate those three states and differentiating between the latter two would require additional refactoring, so I just went with "scheduled/not scheduled".

Screenshot:
5850345041297408

@mrtyler
Copy link
Contributor Author

mrtyler commented Nov 20, 2015

I have a small window left before I'm out of here, so I'm merging this early to build it and try it out tonight. Please still review and comment.

mrtyler added a commit that referenced this pull request Nov 20, 2015
@mrtyler mrtyler merged commit 5630fad into master Nov 20, 2015
@mrtyler mrtyler deleted the mrtyler_rejigger_status branch November 20, 2015 03:33
@solarkennedy
Copy link
Contributor

This is good, thank you for continuing to improve the output of this. Lots of people (eventually) will be running this command a lot I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants