Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some python3 changes #997

Merged
merged 4 commits into from
Feb 2, 2017
Merged

Some python3 changes #997

merged 4 commits into from
Feb 2, 2017

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Feb 1, 2017

Just some quick changes before I had to run off to other things:

  • Adds a py3 tox env, it doesn't pass yet but it can at least be attempted
  • Change basepython to use /usr/bin/... syntax, this allows environments to be recreated while active
  • The py3 environment can successfully build, but not yet pass the tests (before it wasn't even installing correctly)
  • Remove dep on importlib, paasta wasn't actually using anything that wasn't in python2.7 anyway (and it also wasn't necessary, __import__ sufficed)
  • Change a single unicode -> six.text_type: started to fix tests
  • Upgrade python-daemon to get python3 support
  • Remove wsgiref, this has been in the stdlib since python2.5
  • Remove argparse, this has been in the stdlib since python2.7
  • Remove functools32, this isn't imported
  • Use str('') for native string literals in setup.py to appease setuptools

@asottile
Copy link
Contributor Author

asottile commented Feb 2, 2017

make itest_lucid passes

$ make itest_lucid
Everything worked!
Everything worked!
make[1]: Leaving directory `/nail/home/asottile/trees/paasta/yelp_package'

@solarkennedy
Copy link
Contributor

This is massive. Thank you very much! Especially for the contextlib.nested and stringio stuff :(

@solarkennedy solarkennedy merged commit 90ed81c into master Feb 2, 2017
@solarkennedy solarkennedy deleted the some_py3 branch February 2, 2017 21:30
@asottile asottile removed their assignment Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants