-
Notifications
You must be signed in to change notification settings - Fork 10
dry run mode for --jira-ticket parmeter in paasta spark-run #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good to me on the implementation side, will let @nemacysts to confirm the repo setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(i'm just requesting changes since i want to make sure we don't merge this with the requirements/dependencies as-is)
@nemacysts Can you review these changes please? |
tox.ini
Outdated
-rrequirements-dev.txt | ||
-rrequirements.txt | ||
commands= | ||
- pip install yelp-clog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would probably be nice to have a comment here about why this is being installed - but since this is temporary i won't be too picky :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the comment.
What this change does
jira_ticket
handling to a separate private method. We still run all tests through the public interfaceget_spark_conf()
yelp-clog
requirement to tox that is conditionally installed.spark.yelp.jira_ticket.enabled
is false in srv-configs, it logs a warning to monk with the user param passed to get_spark_conf(). Ensures thatpaasta validate
andpaasta m-f-d
work as usual.jenkins
to allowed users list (Proof that this user is indeed calledjenkins
)Testing
When flag is disabled
When flag is enabled