Response 255 for Garry's Mod Servers

[berkbuzcu]

Hello, I don't see a format so here we go:

I get the parse error for Garry's Mod servers when I call the players() method with the code 255.

I have managed to work around this problem by disabling the check and reading the first uint32, then all the players were retrieved.

Below you can find the hack, I don't know how to fix this issue permanently.

    #if response_type != A2S_PLAYER_RESPONSE:
    #    raise BrokenMessageError(
    #        "Invalid response type: " + str(response_type))

    reader.read_uint32()

Right at L:48 of players.py

[Yepoleb]

Great report, I'll look into it as soon as possible.

[Yepoleb]

Hm, I've managed to reproduce the issue, but the official Steam client complains about such servers as well. Not sure how to deal with this, the response is most likely corrupted and should be fixed on the server side.

[berkbuzcu]

Seems to be that way, but the corrupt message can be cleaned by reading the first bytes, I have no idea why.

And sometimes the error persists despite reading the bytes, so I guess a solution could be to read bytes until the message works?

Well of course I mean as a hack, not as a permanent solution. Something people can use meanwhile.

[Yepoleb]

A special branch just for this issue? I guess that would work.

[Yepoleb]

I've tried to reproduce this issue now on two separate days and can no longer find servers with this bug. Do you have an address for me that's still broken?

[berkbuzcu]

Sorry for the late response,

Unfortunately I stopped using the API since the need is over but it occured to me today that it might have been related to large servers with unusual player counts, ie nebulous cloud.

Good luck!

[Yepoleb]

Thanks for your response, sorry I wasn't able to help in time 😦. Best of luck to you as well!