Skip to content
This repository has been archived by the owner on Jul 29, 2023. It is now read-only.

Fix unexpected feature enabling by AutoResetWidth #311

Merged
merged 1 commit into from
May 29, 2020
Merged

Fix unexpected feature enabling by AutoResetWidth #311

merged 1 commit into from
May 29, 2020

Conversation

mnishz
Copy link
Contributor

@mnishz mnishz commented May 27, 2020

First, thank you for your great plugin. It's very helpful.

I found that this feature is unexpectedly enabled on help file by AutoResetWidth. This is caused because help files have modeline that sets shiftwidth or tabstop buffer locally, and AutoResetWidth just refers to b:indentLine_enabled and g:indentLine_enabled, but not filter settings. In other cases, just typing :set shiftwidth=4 can cause the same issue. And this probably be the same issue as #306.

I've created my fix. Could you merge this if it looks good?

How to fix: When b:indentLine_enabled doesn't exist and g:indentLine_enabled == 1, refer to s:Filter() instead of the value itself.

CC: @matveyt, @mike325

@mnishz
Copy link
Contributor Author

mnishz commented May 27, 2020

Ahh, #297, #298 and #301 might be the same issues.

@Yggdroot Yggdroot merged commit 43dbd70 into Yggdroot:master May 29, 2020
@Yggdroot
Copy link
Owner

Thanks.

@mnishz mnishz deleted the fix_AutoResetWidth branch May 29, 2020 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants