Skip to content

Prevent json_decode on responseItem details which is array #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Prevent json_decode on responseItem details which is array #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef0f37
fix: prevent json_decode on responseItem details which is array
dtangdev Nov 14, 2023
0d5fc1d
style: pint
dtangdev Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Dto/ExpoMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* @author David Tang<david@yieldstudio.fr>
* @author James Hemery<james@yieldstudio.fr>
*/
final class ExpoMessage implements Jsonable, Arrayable
final class ExpoMessage implements Arrayable, Jsonable
{
public array $to;

Expand Down
2 changes: 1 addition & 1 deletion src/ExpoNotificationsService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public function receipts(Collection|array $tokenIds): Collection
if ($responseItem['status'] === ExpoResponseStatus::ERROR->value) {
$data
->message($responseItem['message'])
->details(json_decode($responseItem['details'], true));
->details($responseItem['details']);
}

return $data;
Expand Down
2 changes: 1 addition & 1 deletion src/Jobs/CheckTickets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
class CheckTickets
{
use Dispatchable;
use SerializesModels;
use Queueable;
use SerializesModels;

public function handle(
ExpoNotificationsService $expoNotificationsService,
Expand Down
2 changes: 1 addition & 1 deletion src/Jobs/SendPendingNotifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
class SendPendingNotifications
{
use Dispatchable;
use SerializesModels;
use Queueable;
use SerializesModels;

public function handle(
ExpoNotificationsService $expoNotificationsService,
Expand Down