bugfix: adds tests and fix bug sending more than 100 not batched notifications #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…po API If you were sending more than 100 notifications (not batchable), it would failed because of the Expo Push limitation. This fix will chunk by 100 the notifications. For example, if there is 120 notifications, 2 chunks will be created and 2 requests will be sent to Expo API. There was no test suite set up, so I had to set this first then I just wrote the test to cover the bugfix. This package is missing tests, feel free to add more :)
`fake()` function does not exists on Laravel 9
joemugen
force-pushed
the
bugfix/avoid-sending-more-than-push-notif-limit-no-batched-notifications
branch
from
3457c03 to
1e967f2
Compare
JamesHemery
requested changes
Feb 15, 2024
joemugen
force-pushed
the
bugfix/avoid-sending-more-than-push-notif-limit-no-batched-notifications
branch
from
fbe16ec to
bf9760b
Compare
joemugen
deleted the
bugfix/avoid-sending-more-than-push-notif-limit-no-batched-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you were sending more than 100 notifications (not batchable), it would failed because of the Expo Push limitation. This fix will chunk by 100 the notifications. For example, if there is 120 notifications, 2 chunks will be created and 2 requests will be sent to Expo API.
There was no test suite set up, so I had to set this first then I just wrote the test to cover the bugfix. This package is missing tests, feel free to add more :)