This repository was archived by the owner on Oct 4, 2022. It is now read-only.
Adds exceptions (indeclinable and exceptions with full forms) #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t into 371-exceptions-full-forms
agnieszkaszuba
suggested changes
Dec 17, 2019
packages/yoastseo/src/morphology/dutch/generateExceptionsFullForms.js
Outdated
Show resolved
Hide resolved
…avascript into 371-exceptions-full-forms
…avascript into 371-exceptions-full-forms
Restores a function that was accidentally deleted
…t into 371-exceptions-full-forms
…pt into 371-exceptions-full-forms
agnieszkaszuba
suggested changes
Feb 6, 2020
There was a problem hiding this comment.
CR: needs changes
I have added an extra spec to test that when the preceding lexical material is shorter than 2, null is returned.
I have also added some comments about naming and descriptions, as well as a line of code which I think needs to be removed.
Could you also make sure the the PR description and testing instructions are up to date when submitting an issue for code review? :)
packages/yoastseo/src/morphology/morphoHelpers/checkExceptionsWithFullForms.js
Outdated
Show resolved
Hide resolved
packages/yoastseo/spec/morphology/morphoHelpers/checkExceptionsWithFullFormsSpec.js
Outdated
Show resolved
Hide resolved
packages/yoastseo/src/morphology/morphoHelpers/checkExceptionsWithFullForms.js
Outdated
Show resolved
Hide resolved
packages/yoastseo/src/morphology/morphoHelpers/checkExceptionsWithFullForms.js
Outdated
Show resolved
Hide resolved
…avascript into 371-exceptions-full-forms
…javascript into 371-exceptions-full-forms
…WithFullForms.js Co-Authored-By: agnieszkaszuba <32479012+agnieszkaszuba@users.noreply.github.com>
…sWithFullFormsSpec.js Co-Authored-By: agnieszkaszuba <32479012+agnieszkaszuba@users.noreply.github.com>
…avascript into 371-exceptions-full-forms
…javascript into 371-exceptions-full-forms
nataliashitova
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
The words can be taken from stemmingExceptionStemsWithFullForms list in the morphology data file. E.g. "zijden" from this list.
["zij", ["zij", "zijde", "zijden", "zijdes", "zitje", "zijtjes"]]
The expected result of the test: the stem (i.e. "zij")
Quality assurance
Fixes #371
Fixes https://yoast.atlassian.net/browse/LIN-103