Whip_Requirement: be explicit about all expected methods #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Whip_RequirementsChecker::requirementIsFulfilled()` method makes unconditional calls to the `version()` and `operator()` methods on an object implementing `Whip_Requirement`, so these methods ought to be made explicitly required for classes implementing the `Whip_Requirement` interface. Fixed now. Includes updating some tests to match. Note: this change may warrant a new major release!
Pull Request Test Coverage Report for Build 6312667804
💛 - Coveralls |
enricobattocchi
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Whip_RequirementsChecker::requirementIsFulfilled()method makes unconditional calls to theversion()andoperator()methods on an object implementingWhip_Requirement, so these methods ought to be made explicitly required for classes implementing theWhip_Requirementinterface.Fixed now.
Includes updating some tests to match.
Note: this change may warrant a new major release!