Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA/Docs: minor fixes #160

Merged
merged 2 commits into from
Dec 22, 2023
Merged

QA/Docs: minor fixes #160

merged 2 commits into from
Dec 22, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Dec 22, 2023

Docs: improve types

RequirementsCheckerTest: pass the correct type

Not that it really matters in this case as strict types is not being used, so an int will juggle to a string just fine, but still.

Not that it really matters in this case as strict types is not being used, so an int will juggle to a string just fine, but still.
@jrfnl jrfnl added this to the 2.0 milestone Dec 22, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7301497232

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.683%

Totals Coverage Status
Change from base Build 7301110253: 0.0%
Covered Lines: 96
Relevant Lines: 303

💛 - Coveralls

@enricobattocchi enricobattocchi merged commit a645c87 into main Dec 22, 2023
17 checks passed
@enricobattocchi enricobattocchi deleted the JRF/minor-fixes branch December 22, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants