Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates old AI introduction and fixes deprecation messages #21465

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

leonidasmi
Copy link
Contributor

@leonidasmi leonidasmi commented Jul 5, 2024

Context

  • We want to remove deprecation message from admin pages. To do that we need to properly deprecate the whole introduction upsell class and replace it with the new one.

Summary

This PR can be summarized in the following changelog entry:

  • Deprecates the Ai_Generate_Titles_And_Descriptions_Introduction_Upsell class.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to one of yoast admin pages with Premium disabled
  • Check you do not see the deprecation message for the Ai_Generate_Titles_And_Descriptions_Introduction::should_show() method
  • Also smoke test the new upsell appearing properly.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build 00daaffe85770fac9c0e14aab51af5abd9809843

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.3%) to 52.952%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/introductions/application/ai-fix-assessments-upsell.php 3 4 75.0%
Totals Coverage Status
Change from base Build 2197c662f24ce4fe327abf36f49732b2eb02db08: 4.3%
Covered Lines: 28455
Relevant Lines: 54346

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build fd4a3478b824a55230d50a14e028cce43fb83762

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.3%) to 52.952%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/introductions/application/ai-fix-assessments-upsell.php 3 4 75.0%
Totals Coverage Status
Change from base Build 2197c662f24ce4fe327abf36f49732b2eb02db08: 4.3%
Covered Lines: 28455
Relevant Lines: 54346

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build 3f0fd9ea1fe44f261ca35a8ae0b56b6f7f446ba7

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.3%) to 52.954%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/introductions/application/ai-fix-assessments-upsell.php 3 4 75.0%
Totals Coverage Status
Change from base Build 2197c662f24ce4fe327abf36f49732b2eb02db08: 4.3%
Covered Lines: 28455
Relevant Lines: 54343

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build faa34822d3147685b1ce806aab18ee8b6cfc95ce

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.3%) to 52.952%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/introductions/application/ai-fix-assessments-upsell.php 3 4 75.0%
Totals Coverage Status
Change from base Build 2197c662f24ce4fe327abf36f49732b2eb02db08: 4.3%
Covered Lines: 28455
Relevant Lines: 54346

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build 2d39894bdd9a5c32a0a6c3d8302d1bdb5e05f109

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.3%) to 52.952%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/introductions/application/ai-fix-assessments-upsell.php 3 4 75.0%
Totals Coverage Status
Change from base Build 2197c662f24ce4fe327abf36f49732b2eb02db08: 4.3%
Covered Lines: 28455
Relevant Lines: 54346

💛 - Coveralls

@vraja-pro
Copy link
Contributor

CR & AC ✅

@vraja-pro vraja-pro modified the milestones: 23.2, feature/fix-assessments Jul 8, 2024
@vraja-pro vraja-pro merged commit e5483f9 into feature/fix-assessments Jul 8, 2024
23 checks passed
@vraja-pro vraja-pro deleted the 1667-fix-deprecation branch July 8, 2024 08:51
@mhkuu mhkuu added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 16, 2024
@mhkuu mhkuu changed the title Deprecate old introduction and fix deprecation messages Deprecates old introduction and fixes deprecation messages Jul 16, 2024
@mhkuu mhkuu modified the milestones: feature/fix-assessments, 23.2 Jul 16, 2024
@mhkuu mhkuu added changelog: other Needs to be included in the 'Other' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Jul 16, 2024
@mhkuu mhkuu changed the title Deprecates old introduction and fixes deprecation messages Deprecates old AI introduction and fixes deprecation messages Jul 16, 2024
@mhkuu mhkuu added the innovation Innovative issue. Relating to performance, memory or data-flow. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: other Needs to be included in the 'Other' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants