Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unneeded functions. #21515

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Aug 1, 2024

Context

  • We want to deprecate/ remove old code

Summary

This PR can be summarized in the following changelog entry:

  • Deprecates some functions in the Yoast_Input_Validation class.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test the settings of the add-ons since they still use the validation code.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 1, 2024
@thijsoo thijsoo linked an issue Aug 1, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 27528b2bafd79a62d6bb2930c1383079eddec39d

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 54.105%

Changes Missing Coverage Covered Lines Changed/Added Lines %
admin/class-yoast-form.php 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
admin/class-yoast-form.php 1 2.64%
admin/class-yoast-input-validation.php 6 33.33%
Totals Coverage Status
Change from base Build 1ea5f00970ae19ed6cde6c1fa36c5226b4f005c0: 0.02%
Covered Lines: 29381
Relevant Lines: 54610

💛 - Coveralls

@enricobattocchi enricobattocchi added changelog: other Needs to be included in the 'Other' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Aug 2, 2024
@enricobattocchi enricobattocchi added this to the feature/plugin-fixes milestone Aug 2, 2024
@enricobattocchi enricobattocchi merged commit 0669aba into feature/plugin-fixes Aug 2, 2024
22 checks passed
@enricobattocchi enricobattocchi deleted the 21250-deprecate-stuff-in-yoast_input_validation branch August 2, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: other Needs to be included in the 'Other' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate stuff in Yoast_Input_Validation
3 participants