Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: use PHPUnit annotations #362

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Nov 20, 2023

Summary

This PR can be summarized in the following changelog entry:

  • Test tweak

Relevant technical choices:

Use PHPUnit annotations instead of properties.

Apparently this must have worked in some way, but the preserveGlobalState for the DependencyYoastSEOTest was definitely not correct (and probably not working either).

Test instructions

This PR can be tested by following these steps:

  • N/A If the builds pass, we're good.

... instead of properties.

Apparently this must have worked in some way, but the `preserveGlobalState` for the `DependencyYoastSEOTest` was definitely not correct (and probably not working either).
@jrfnl jrfnl added yoast cs/qa changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Nov 20, 2023
@jrfnl jrfnl added this to the 3.2 milestone Nov 20, 2023
@jrfnl jrfnl merged commit 47f9162 into develop Nov 20, 2023
15 checks passed
@jrfnl jrfnl deleted the JRF/tests-use-phpunit-annotations branch November 20, 2023 05:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6925892474

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.274%

Totals Coverage Status
Change from base Build 6925868219: 0.0%
Covered Lines: 148
Relevant Lines: 263

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog yoast cs/qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants