Composer: use PHPCS 3.3.1 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from it being a new release with lots of bug fixes, there are also a few specific changes in PHPCS 3.3.1 which benefit YoastCS and necessitate updating the minimum version: > * Generic.Commenting.DocComment no longer generates the SpacingBeforeTags error if tags are the first content in the docblock > - The sniff will still generate a MissingShort error if there is no short comment > -This allows the MissingShort error to be suppressed in a ruleset to make short descriptions optional As a lot of plugins still have issues with missing short descriptions, the `SpacingBeforeTags` error was also being thrown and had to be forcibly excluded. These exclusions can now be removed. > * Squiz.WhiteSpace.FunctionSpacing no longer checks spacing of functions at the top of an embedded PHP block > - Fixes a conflict between this sniff and the Squiz.PHP.EmbeddedPHP sniff This bug was discovered via one of the Yoast plugins, so having this fix prevents needing a work-around. Ref: https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from it being a new release with lots of bug fixes, there are also a few specific changes in PHPCS 3.3.1 which benefit YoastCS and necessitate updating the minimum version:
As a lot of plugins still have issues with missing short descriptions, the
SpacingBeforeTagserror was also being thrown and had to be forcibly excluded. These exclusions can now be removed.This bug was discovered via one of the Yoast plugins, so having this fix prevents needing a work-around.
Ref: https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.3.1