Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests file have executable permissions #2

Merged
merged 1 commit into from
Jan 12, 2015
Merged

Conversation

bartbes
Copy link
Contributor

@bartbes bartbes commented Jan 12, 2015

Hopefully fixes the error you're getting with CI.

@Yonaba
Copy link
Owner

Yonaba commented Jan 12, 2015

Awesome. Thanks, @bartbes,

Actually, It works fine, as you can see here. Though, the tests fails with Lua 5.2, because setfenv (line 121) is deprecated.
Well, I can either updated the .travis.yml to skip building for Lua 5.2.
Or are you willing to update Class-Commons tests specification to support Lua 5.2 ? In that case, you might need a replacement for setfenv... Maybe this might help.

@bartbes
Copy link
Contributor Author

bartbes commented Jan 12, 2015

It probably makes sense to revise the tests in general and possibly move to a well-known (but small?) testing library. That said, I think setfenv isn't strictly necessary in the current codebase.

@Yonaba
Copy link
Owner

Yonaba commented Jan 12, 2015

Hmm, I see.
Concerning a possible test library, I am very used to Telescope. It is really fine, and light enough, to me. There's also busted, which has much more features, and also easy to use. But I'd go with Telescope. I can rewrite Class-Commons codebase with Telescope and send a PR.
Maybe this should be discussed in a separate issue on Class-Commons repository itself, since it will affect everyone using Class-Commons (I mean @kikito's MiddleClass, @vrld's Hump.class and Slither).

Yonaba added a commit that referenced this pull request Jan 12, 2015
Make tests file have executable permissions
@Yonaba Yonaba merged commit efef9f2 into Yonaba:master Jan 12, 2015
@bartbes
Copy link
Contributor Author

bartbes commented Jan 12, 2015

Class Commons Tests repo ticket opened: bartbes/Class-Commons-Tests#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants