Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Option for non-vmapped get_local_sample_representation #12

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

justjhong
Copy link
Collaborator

Useful if vmap causes OOM on GPU.

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we can also remove the mc_samples in this linear gaussian setup

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #12 (b6c26a4) into main (72e1a5e) will decrease coverage by 0.29%.
The diff coverage is 90.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   98.68%   98.38%   -0.30%     
==========================================
  Files           6        6              
  Lines         304      310       +6     
==========================================
+ Hits          300      305       +5     
- Misses          4        5       +1     
Flag Coverage Δ
unittests 98.38% <90.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/scvi_v2/_model.py 98.96% <90.00%> (-1.04%) ⬇️

@justjhong justjhong merged commit 1eced8f into main Nov 17, 2022
@justjhong justjhong deleted the jhong/nonvmappedlocal branch November 17, 2022 04:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants