Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Rm deprecated #88

Merged
merged 15 commits into from
Feb 20, 2024
Merged

Rm deprecated #88

merged 15 commits into from
Feb 20, 2024

Conversation

PierreBoyeau
Copy link
Collaborator

@PierreBoyeau PierreBoyeau commented Feb 16, 2024

Removals:

Visualization utils

  • Remove distance visualization method explore_stratifications. It wrapped scipy.cluster.hierarchy. It also relied on convert_pandas_to_colors, which converted a pandas dataframe of scalars/categoricals into a pandas of hex colors, used to visualize covariates along with heat maps.

Model architectures

  • All encoders/decoders that were not attention-based.
  • Module classes FactorizedEmbedding and MLP, which were not used in the main flavor of MrVI.

Distance matrices & other

  • Normalized distance matrix option in compute_local_statistics and all components that were used for normalizing distance matrices.
  • Remove all alternative outlier detections heuristics in get_outlier_cell_sample_pairs except ap.
  • compute_cell_scores, which only seemed to be used to visualize some cells statistics (Geary C or nearest-neighbors-based).
  • Components to compute Geary C, permutation-based p-values.

TL;DR Removals in _model.py

  • Any option to consider something else than attention-based encoders and decoders
  • Any option to remove outliers other than with ball option
  • _compute_local_baseline_dists
  • compute_cell_scores
  • explore_stratifications

@justjhong justjhong changed the title Rm depreciated Rm deprecated Feb 18, 2024
Copy link
Collaborator

@justjhong justjhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is a line of 167 of model.py for a hack to loading old models. We should remove this now.
  • on line 907 in model.py we commented out the jax.jit decorator? why? lets make a decision.
  • Nit: let's move the property original_donor_key to below the init function in model.py
  • Nit: in module.py we have names like EncoderUZ2Attention, etc. Let's make them all the most basic version now like EncoderUZ.

tests/test_model.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@justjhong justjhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thank you!

@justjhong justjhong merged commit 64807ea into main Feb 20, 2024
2 of 6 checks passed
@justjhong justjhong deleted the rm_depreciated branch February 20, 2024 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants