This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjhong
reviewed
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There is a line of 167 of model.py for a hack to loading old models. We should remove this now.
- on line 907 in model.py we commented out the jax.jit decorator? why? lets make a decision.
- Nit: let's move the property original_donor_key to below the init function in model.py
- Nit: in module.py we have names like EncoderUZ2Attention, etc. Let's make them all the most basic version now like EncoderUZ.
justjhong
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removals:
Visualization utils
explore_stratifications
. It wrappedscipy.cluster.hierarchy
. It also relied onconvert_pandas_to_colors
, which converted a pandas dataframe of scalars/categoricals into a pandas of hex colors, used to visualize covariates along with heat maps.Model architectures
FactorizedEmbedding
andMLP
, which were not used in the main flavor of MrVI.Distance matrices & other
compute_local_statistics
and all components that were used for normalizing distance matrices.get_outlier_cell_sample_pairs
exceptap
.compute_cell_scores
, which only seemed to be used to visualize some cells statistics (Geary C or nearest-neighbors-based).TL;DR Removals in
_model.py
ball
option_compute_local_baseline_dists
compute_cell_scores
explore_stratifications