Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synth_ice40: split map_gates off fine #723

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

whitequark
Copy link
Member

I am currently looking at some optimizations to be done on iCE40 that would run on the coarse-grain cells. In this case it is very useful to me to be able to stop synthesis before all arch-dependent transformations, but after all arch-independent optimizations have already been done. I.e. see and affect the state just before techmapping, and restart afterwards.

Feel free to close this PR if this is not something desirable, or tell me to also implement this for other synth_* commands.

@cliffordwolf cliffordwolf merged commit 9522eee into YosysHQ:master Dec 16, 2018
@cliffordwolf
Copy link
Collaborator

Feel free to close this PR if this is not something desirable, or tell me to also implement this for other synth_* commands.

LGTM.

The only thing I'm unsure about is re keeping the name fine for the last pre-map block. For the generic synth command it makes sense to have a corase and fine block. But for the others most of fine has been converted into various map_* blocks and now for them fine is just just the things run between the coarse synthesis stuff an mapping.

Now the name fine is essentially a copy&paste artifact, not a reasonable name for most synth_* commands.

What do you think about renaming fine to something like premap, or maybe simply map as it is the start of the mapping phase?

@whitequark
Copy link
Member Author

What do you think about renaming fine to something like premap, or maybe simply map as it is the start of the mapping phase?

I think map sounds good! I assume you'll make that change?

@whitequark whitequark deleted the synth_ice40_map_gates branch December 16, 2018 14:51
@cliffordwolf
Copy link
Collaborator

Renamed synch_ice40 fine to map in 5fa5dbb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants