Handle recursive types #324

[darkowic]

Please:

• Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.
• Provide a test case & update the documentation in the Readme.md

Fixes #324, #339, #246 -> Hopefully ;) Tested on examples from this repository https://github.com/Guidewire/ts-to-json-schema-tests (The ExampleProps).

Feedback appreciated.

[darkowic]

CI fails on TS 3.7:

    typeof globalThis
      1) type-globalThis should create correct schema

Tips appreciated ;)

[domoritz]

Awesome. Thank you so muchy. What's the diff for the globalThis test?

[darkowic]

Well, type error...

  1 failing
  1) schema
       typeof globalThis
         type-globalThis should create correct schema:
     TypeError: Cannot read property '0' of undefined
      at JsonSchemaGenerator.getClassDefinition (typescript-json-schema.ts:890:63)
      at JsonSchemaGenerator.getTypeDefinition (typescript-json-schema.ts:1247:26)
      at JsonSchemaGenerator.getSchemaForSymbol (typescript-json-schema.ts:1288:26)
      at Object.generateSchema (typescript-json-schema.ts:1515:26)
      at Context.<anonymous> (test/schema.test.ts:27:28)
      at processImmediate (internal/timers.js:443:21)

I will try to fix it on Monday...

[domoritz]

🤦‍♂️ right, the stacktrace.

[darkowic]

Well @domoritz, you solved my problem by removing typescript 3.7 from tests :P Ready to merge 🚀

[domoritz]

Thank you

[domoritz]

Should the type still be here? We already have a $ref property so I think this is wrong.