Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #1

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Testing #1

wants to merge 65 commits into from

Conversation

ericgaspar
Copy link
Member

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link

Meow 🐈
Test Badge

@csolisr
Copy link
Collaborator

csolisr commented Jun 28, 2023

!testme

@yunohost-bot
Copy link

Fingers crossed!
Test Badge

@csolisr
Copy link
Collaborator

csolisr commented Jun 28, 2023

!testme

@yunohost-bot
Copy link

✌️
Test Badge

@csolisr
Copy link
Collaborator

csolisr commented Jun 30, 2023

Bingo:

WARNING Invalid argument dump-env prod. Use "composer require dump-env prod" instead to add packages to your composer.json.

scripts/install Outdated

#ynh_install_composer_as_user --phpversion=$phpversion --install_args="--prefer-dist --no-autoloader --no-scripts --no-progress"
#ynh_install_composer_as_user --phpversion=$phpversion --install_args="dump-env prod"
ynh_install_composer_asuser --phpversion=$phpversion
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing this for fun, in case you're interested, the install failed here at ynh_install_composer_asuser --phpversion=$phpversion with "command not found", I notice that the lines above have the command spelled with an underscore like "...as_user", perhaps that's the reason? I'll try to figure out a way to modify that line and run the installer again. Thanks for your efforts so far.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey you're right about that one! It had somehow slipped out of my eyes, gonna try correcting that line at home

@csolisr
Copy link
Collaborator

csolisr commented Jul 19, 2023

!testme

@yunohost-bot
Copy link

🚀
Test Badge

@csolisr
Copy link
Collaborator

csolisr commented Nov 25, 2023

To confirm - is this pull request still in progress? @ericgaspar

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link

😜
Test Badge

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link

Fingers crossed!
Test Badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants