upgrade: attempt to restore backup only if it was correctly saved #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state, an upgrade may end up removing the app.
This is because the new upgrade script backups the app before upgrading – and attempts to restore the backup in case of upgrade failure. This is a great safety feature provided by Yunohost, which really makes upgrades safer.
However, if an app is upgraded from a previous version where it did support backup but not restore, Yunohost will happily:
To fix this, the script now checks if the backup went successfully. When an error occurs, it attempts to restore the backup only if the backup process was successful.
Ref #90