Fix new picture permissions (post v0.11.5 issue) + update to 0.11.7 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!testme |
|
🚀 |
Revert c8672ad
|
!testme |
|
🎠 |
|
!testme |
|
Meow 🐈 |
|
!testme |
|
Meow 🐈 |
|
I tried it, and |
|
CI upgrade will fail because there is not picture uploaded. I need to had a check for this. |
|
!testme |
|
😜 |
|
!testme |
|
Fingers crossed! |
|
CI is buggy, result is irrelevant. I wonder if I should merge this already, as it's only a partial fix (broken pictures will work again, now new ones), or wait for a complete solution… |
It doesn't work within quotes
|
!testme |
|
Fingers crossed! |
|
!testme |
|
Meow 🐈 |
|
!testme |
|
😜 |
Upgrade to version 0.11.7
lapineige
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related discussion #211
This should partly fix the issue introduced in #209 for newly created files.
Old ones, but created after upgrade to v0.11.5 (or .6) will not be fixed.Those files should be fixed too.The only missing thing is that it doesn't work on Mastodon and so on…
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)