Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package upgrade #52

Merged
merged 7 commits into from
Mar 12, 2019
Merged

Package upgrade #52

merged 7 commits into from
Mar 12, 2019

Conversation

maniackcrudelis
Copy link
Contributor

@maniackcrudelis maniackcrudelis commented Mar 3, 2019 •
edited by JimboJoe
Loading

Problem

  • Global upgrade of the package.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team March 3, 2019 17:16
@maniackcrudelis maniackcrudelis changed the base branch from master to testing March 3, 2019 19:34
kay0u
kay0u approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it. But LGTM

scripts/install Outdated Show resolved Hide resolved
scripts/upgrade Outdated Show resolved Hide resolved
kay0u
kay0u requested changes Mar 4, 2019
View reviewed changes
manifest.json Outdated Show resolved Hide resolved
kay0u
kay0u reviewed Mar 4, 2019
View reviewed changes
scripts/install Outdated Show resolved Hide resolved
kay0u
kay0u previously approved these changes Mar 4, 2019
View reviewed changes
@kay0u
Copy link
Member

kay0u commented Mar 4, 2019

You can merge my PR on this branch to fix the nextcloud conf

@maniackcrudelis
Merge pull request #53 from YunoHost-Apps/fix-nextcloud
9727331 
Add nextcloud support, and remove sed -i
kay0u
kay0u previously approved these changes Mar 5, 2019
View reviewed changes
@maniackcrudelis maniackcrudelis mentioned this pull request Mar 9, 2019
Merged
8 tasks
JimboJoe
JimboJoe approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review OK 👍

@JimboJoe
Copy link
Contributor

JimboJoe commented Mar 9, 2019

Will be merged in 3 days.

@maniackcrudelis maniackcrudelis merged commit 762b0a9 into testing Mar 12, 2019
@maniackcrudelis maniackcrudelis deleted the package_upgrade branch March 12, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maniackcrudelis @kay0u @JimboJoe