New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MSYS2 #908
Conversation
Hi @Uni-, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Our scripts already supported mingw, see |
It's MSYS2, MinTTY subsystem running MinGW-w64 toolchain, based on recent Cygwin fork. It's different from traditional cmd.exe running MinGW toolchain. When I run
What I got with
You're right, we may not want |
aa60efc
to
094fef2
Compare
@wintersteiger My conclusion is, in short, it's good to set |
This is not about the appropriateness of the macro name. On the MSYS2 platform we are not supposed to behave like we do on the Cygwin platform (adding -D_CYGWIN changes the behavior of Z3). Also, we already had support for mingw/msys, we just didn't recognize that particular version string yet. I'm trying to add another commit to this PR/branch, but GitHub is acting up. |
With this patch, Z3 is compiled via MSYS shell and toolchain of MSYS2. (MINGW32 shell and MINGW64 shell is not yet cared.)