Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict parsing and turning on/off per command line option #15

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Enable strict parsing and turning on/off per command line option #15

merged 11 commits into from
Jun 25, 2024

Conversation

sdierg
Copy link
Contributor

@sdierg sdierg commented Jun 24, 2024 •
edited by ptahmose
Loading

Description

Added command line argument to enable strict parsing.
Use strict parsing when opening the file if command line argument says to.

Fixes #14

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe the tests that you ran to verify your changes.
Provide instructions to reproduce.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Jun 24, 2024
@ptahmose
Copy link
Contributor

Yes, something like this, LGTM.

Bumping the version-number, adding a line to the history are missing of course, but then it should be good to go from my perspective.

@ptahmose
Copy link
Contributor

Would be nice to update this documentation page https://github.com/ZEISS/czicheck/blob/main/documentation/usage.md with the now-extended synopsis.

@sdierg sdierg self-assigned this Jun 24, 2024
@sdierg sdierg marked this pull request as ready for review June 24, 2024 12:46
@sdierg sdierg marked this pull request as draft June 24, 2024 12:47
@sdierg sdierg changed the title initial commit. Enable strict parsing and turning on/off per command line option Jun 24, 2024
@sdierg sdierg marked this pull request as ready for review June 24, 2024 14:33
ptahmose
ptahmose previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@ptahmose ptahmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdierg sdierg requested a review from ptahmose June 24, 2024 16:12
ptahmose
ptahmose reviewed Jun 24, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
ptahmose
ptahmose approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ptahmose ptahmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sdierg sdierg merged commit f27d2ca into main Jun 25, 2024
7 checks passed
@ptahmose ptahmose deleted the issue14-make-strict-parsing-available branch June 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptahmose ptahmose ptahmose approved these changes

@DaveyJonesBitPail DaveyJonesBitPail Awaiting requested review from DaveyJonesBitPail

Assignees

@sdierg sdierg

Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make libCzi's strict parsing available with a command line argument.
2 participants
@sdierg @ptahmose