Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for "not pixel exact result with scaling-accessor if zoom is exactly 1" #52

Closed
wants to merge 4 commits into from

Conversation

zeissmicroscopy
Copy link
Contributor

STOP - Read this First!

Reporting a security vulnerability?
Check out the project's security policy.

Fill out and Adjust this Template

Description

When using the scaling-accessor, in some cases not pixel-accurate compositions have been found.
This PR avoids using the scaling-blit-operation if zoom is exactly 1, and therefore is giving pixel-accurate results in this case.
A unit-test which exercises on of the problematic cases is added.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

running unit-tests locally, testing with CZIcmd

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants