Cannot get a name and parameters for RoleProviderPluginManager #373

[ashatrov]

#373

[coveralls]

Coverage increased (+0.01%) to 92.954% when pulling 312c054 on ashatrov:373_Cannot_get_a_name_and_parameters_for_RoleProviderPluginManager into 2ce24f1 on ZF-Commons:master.

[coveralls]

Coverage increased (+0.01%) to 92.954% when pulling 312c054 on ashatrov:373_Cannot_get_a_name_and_parameters_for_RoleProviderPluginManager into 2ce24f1 on ZF-Commons:master.

[coveralls]

Coverage increased (+0.01%) to 92.954% when pulling cf1c8ec on ashatrov:373_Cannot_get_a_name_and_parameters_for_RoleProviderPluginManager into 2ce24f1 on ZF-Commons:master.

[coveralls]

Coverage increased (+0.01%) to 92.954% when pulling cf1c8ec on ashatrov:373_Cannot_get_a_name_and_parameters_for_RoleProviderPluginManager into 2ce24f1 on ZF-Commons:master.

[prolic]

Please add a test case that fails without this addition.

[ashatrov]

@prolic I have no idea how to simulate it.

Anyway, it is the correct way to get firsts key of Array, because the internal pointer can point beyond the end of the elements list.

http://php.net/manual/en/function.key.php

Return Values

The key() function simply returns the key of the array element that's currently being pointed to by the internal pointer. It does not move the pointer in any way. If the internal pointer points beyond the end of the elements list or the array is empty, key() returns NULL.

If we need to have the first key, it must be with reset(), because we cannot know where is pointer now.

[ashatrov]

e.g.

<?php
$arr = ['foo' => 1];

echo key($arr); // foo

next($arr);
echo key($arr); // Null

reset($arr);
echo key($arr); // foo

Maybe there is while(next($config)) { // do something } somewhere in ZF.

[coveralls]

Coverage increased (+0.01%) to 92.954% when pulling 9204991 on ashatrov:373_Cannot_get_a_name_and_parameters_for_RoleProviderPluginManager into 2ce24f1 on ZF-Commons:master.

[coveralls]

Coverage increased (+0.01%) to 92.954% when pulling 9204991 on ashatrov:373_Cannot_get_a_name_and_parameters_for_RoleProviderPluginManager into 2ce24f1 on ZF-Commons:master.

[prolic]

LGTM, what do you think @basz?

[coveralls]

Coverage increased (+0.01%) to 92.954% when pulling 6dea80b on ashatrov:373_Cannot_get_a_name_and_parameters_for_RoleProviderPluginManager into 2ce24f1 on ZF-Commons:master.

[coveralls]

Coverage increased (+0.01%) to 92.954% when pulling 6dea80b on ashatrov:373_Cannot_get_a_name_and_parameters_for_RoleProviderPluginManager into 2ce24f1 on ZF-Commons:master.

[humayunjamal]

Hi Guys waiting for this pr to be merged

[ghost]

@prolic What is the policy for releases? Will you create a minor release 2.6.3 with this changes to be able to use it in composer from packagist?

[prolic]

@ashatrov-propertyfinder done with https://github.com/ZF-Commons/zfc-rbac/releases/tag/v2.6.3