Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LICENSE? #4

Closed
zvezdochiot opened this issue Apr 4, 2020 · 4 comments · Fixed by #7
Closed

LICENSE? #4

zvezdochiot opened this issue Apr 4, 2020 · 4 comments · Fixed by #7

Comments

@zvezdochiot
Copy link
Collaborator

Maybe https://github.com/ImageProcessing-ElectronicPublications/gimp-plugin-colors-bimod/blob/master/LICENSE ?

PS: Just asked
@ZQPei
Copy link
Owner

ZQPei commented Apr 4, 2020

How about you make a pull request?

@zvezdochiot
Copy link
Collaborator Author

zvezdochiot commented Apr 4, 2020 •
edited
Loading

First need to know the preferences. Is there a need for PR? Detail breakdown by commits?

@ZQPei
Copy link
Owner

ZQPei commented Apr 4, 2020

In fact this code has a hidden bug. If process one image at a time, it is fine.
However, if you change the main function to process hundreds of images in a folder at the same time with a for loop, it will run out of memory, which means there are somewhere that forget to free memory after alloc and this bug is negligible when processing one image.
I tried to find this bug, but failed. That is why I do image inpainting one by one.
How about you have a try to go?

@zvezdochiot
Copy link
Collaborator Author

Memory alloc? We will see.

But why not use the "simple" cli? And to work with an array through bash? And the total log is not needed, it is about nothing.

zvezdochiot added a commit to ImageProcessing-ElectronicPublications/patchmatch_inpainting that referenced this issue Apr 4, 2020
@zvezdochiot
fix ZQPei#4: LICENSE question
3ca7cae
zvezdochiot added a commit to ImageProcessing-ElectronicPublications/patchmatch_inpainting that referenced this issue Apr 4, 2020
@zvezdochiot
fix ZQPei#4: LICENSE question
5104a51
@zvezdochiot zvezdochiot mentioned this issue Apr 4, 2020
Merged
@ZQPei ZQPei closed this as completed in #7 Apr 4, 2020
@zvezdochiot zvezdochiot mentioned this issue Apr 4, 2020
Closed
zvezdochiot added a commit to ImageProcessing-ElectronicPublications/patchmatch_inpainting that referenced this issue Dec 24, 2022
@zvezdochiot
fix ZQPei#4: LICENSE question
ab0d410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LICENSE question ImageProcessing-ElectronicPublications/patchmatch_inpainting
2 participants
@zvezdochiot @ZQPei