Matrix binary power #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteBlackGoose
commented
Jul 26, 2020
| @@ -1134,68 +1135,120 @@ public Matrix<T> Divide(T b) | |||
|
|
|||
| #region Power (Matrix ^ Scalar) | |||
|
|
|||
| private class SquareMatrixFactory | |||
| { | |||
| private List<Matrix<T>> cache = new List<Matrix<T>>(); | |||
There was a problem hiding this comment.
It is probably better to replace List with your type to keep the "ecosystem"
WhiteBlackGoose
commented
Jul 26, 2020
| Multiply(mp2, dest, ref tmp); | ||
| mp2 = tmp; | ||
| } | ||
| destination = mp2; |
There was a problem hiding this comment.
Oof that was supposed to be .Clone I guess
| { | ||
| if (!(c is null) && c._matrix.Length == a._matrix.Length) | ||
| if (!(destination is null) && destination.IsSquare) |
There was a problem hiding this comment.
Better use IsSquare to keep the code readable, the power operation is extremely pricy, 1-2 ns isn't worth saving
| if (power == 1) | ||
| return; | ||
| if (squareMatrixFactory is null || squareMatrixFactory.DiagonalLength != a._rows) | ||
| squareMatrixFactory = new SquareMatrixFactory(a._rows); |
There was a problem hiding this comment.
If you already have a square matrix factory, this should be replaced with your type. Also my factory won't work if we change matrix' size after each operation, e. g.
Power(A, 3);
Power(A, 4);
Power(A, -13);
Is fast because we pull square matrices from the factory, while
Power(A, 3);
Power(B, 4);
Power(A, -13);
Because we re-create the factory in the second and third lines
|
oof not to merge now, I discovered a few bugs |
|
Now it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A^13 = A^6 * A^6 * A...