Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(db): Disable unused rocksdb compression features #4082

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

We're not using most of the compression methods supported by rocksdb, so there's no point compiling them into Zebra.

This should speed up compilation slightly.

Specifications

By default, support for the Snappy, LZ4, Zstd, Zlib, and Bzip2 compression is enabled through crate features. If support for all of these compression algorithms is not needed, default features can be disabled and specific compression algorithms can be enabled.

https://github.com/rust-rocksdb/rust-rocksdb#compression-support

Solution

  • enable lz4 compression, and disable all the other compression types

We've had a state version increment since we changed the compression type, so this doesn't need another one.

Review

Anyone can review this low priority PR.

Reviewer Checklist

  • Existing build and tests works

@teor2345 teor2345 added A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup P-Low ❄️ A-state Area: State / database changes labels Apr 11, 2022
@teor2345 teor2345 self-assigned this Apr 11, 2022
@teor2345 teor2345 requested a review from a team as a code owner April 11, 2022 00:35
@teor2345 teor2345 requested review from jvff and removed request for a team April 11, 2022 00:35
mergify bot added a commit that referenced this pull request Apr 11, 2022
@teor2345
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Apr 12, 2022
@mergify mergify bot merged commit b7f6fdc into main Apr 12, 2022
@mergify mergify bot deleted the rocksdb-unused-deps branch April 12, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-state Area: State / database changes C-cleanup Category: This is a cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants