Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add self hosted runner for long tests #7520

Merged
merged 13 commits into from
Sep 13, 2023
Merged

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Sep 11, 2023

Motivation

We've been creating several jobs to workaround GitHub's 6 hour time limit for hosted runners, but this approach has been hard to maintain, created several edge cases (issues) with SSH connections and made the workflow way too verbose.

Closes: #5572
Depends-On: #7507

Specifications

Complex Code or Requirements

  • We need to confirm the regex in the test-result job works for all tests

Solution

  • Use self-hosted runner instead of GitHub Hosted runner
  • Remove all intermediate jobs which were meant to extend the run of the test over the 6 hours limit
  • Move the startup validation and test run steps into a single job
  • Combine setup and launch jobs in a single job (2 jobs total)

Review

  • This should execute over 6 hours for a Zebra and LWD sync
  • The sync should end successfully

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-usability Zebra is hard to understand or use C-feature Category: New features labels Sep 11, 2023
@gustavovalverde gustavovalverde requested a review from a team as a code owner September 11, 2023 10:10
@gustavovalverde gustavovalverde self-assigned this Sep 11, 2023
@gustavovalverde gustavovalverde requested review from teor2345 and removed request for a team September 11, 2023 10:10
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Sep 11, 2023
@gustavovalverde
Copy link
Member Author

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much for simplifying this. I have a bunch of questions, but I think the most important one is about the long test setting and timeouts.

Everything else should still work the way it is, or if it doesn't work, we'll pick it up in the tests.

Would you mind delaying merging this PR until after #7507 merges?
@oxarbitrage and I are working on a complicated cached state rebuild, which needs to finish before the scheduled jobs run on Friday. So I'd like to get it done first.
#7507 (comment)

(And if you have any ideas for making that easier, feel free to comment on that PR, or open a ticket to make rebuilds work better.)

.github/workflows/deploy-gcp-tests.yml Show resolved Hide resolved
.github/workflows/deploy-gcp-tests.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-gcp-tests.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-gcp-tests.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-gcp-tests.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-gcp-tests.yml Show resolved Hide resolved
.github/workflows/deploy-gcp-tests.yml Show resolved Hide resolved
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and for the quick changes! I have just approved the dependent PR, so this one will hopefully merge before tomorrow.

(I love deleting complicated code that isn't needed any more.)

mergify bot added a commit that referenced this pull request Sep 13, 2023
@mergify mergify bot merged commit d60e23a into main Sep 13, 2023
114 checks passed
@mergify mergify bot deleted the self-hosted-runner branch September 13, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: use self-hosted runners for CI pipelines
2 participants