-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add self hosted runner for long tests #7520
Conversation
…nner This step was mostly required as we did SSH several times during PR, Queue and Push to `main`, but this hasn been reduced considerably.
…osted runner" This reverts commit 5b5d546.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you so much for simplifying this. I have a bunch of questions, but I think the most important one is about the long test setting and timeouts.
Everything else should still work the way it is, or if it doesn't work, we'll pick it up in the tests.
Would you mind delaying merging this PR until after #7507 merges?
@oxarbitrage and I are working on a complicated cached state rebuild, which needs to finish before the scheduled jobs run on Friday. So I'd like to get it done first.
#7507 (comment)
(And if you have any ideas for making that easier, feel free to comment on that PR, or open a ticket to make rebuilds work better.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, and for the quick changes! I have just approved the dependent PR, so this one will hopefully merge before tomorrow.
(I love deleting complicated code that isn't needed any more.)
Motivation
We've been creating several jobs to workaround GitHub's 6 hour time limit for hosted runners, but this approach has been hard to maintain, created several edge cases (issues) with SSH connections and made the workflow way too verbose.
Closes: #5572
Depends-On: #7507
Specifications
Complex Code or Requirements
test-result
job works for all testsSolution
Review
Reviewer Checklist
Follow Up Work