Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Zebra RFCs from CONTRIBUTING.md #8304

Merged
merged 1 commit into from Feb 22, 2024
Merged

Conversation

mpguerra
Copy link
Contributor

@mpguerra mpguerra commented Feb 21, 2024

We have deprecated the RFC process

Motivation

What are the most important goals of the ticket or PR?

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Specifications

Complex Code or Requirements

Solution

Testing

Review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

We have deprecated the RFC process
@mpguerra mpguerra requested a review from a team as a code owner February 21, 2024 09:32
@mpguerra mpguerra requested review from oxarbitrage and removed request for a team February 21, 2024 09:32
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Feb 21, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the RFC process is deprecated but i think we might want to replace it with something as:

Large changes:

When adding a large change or a series of pull requests into Zebra please make sure the whole context is written in a ticket and link each piece is linking to it. Sometimes, it might be useful to request a meeting or discuss in chat channels with the Zebra team to agree in the process to be taken.

@mpguerra
Copy link
Contributor Author

I understand the RFC process is deprecated but i think we might want to replace it with something as:

Large changes:

When adding a large change or a series of pull requests into Zebra please make sure the whole context is written in a ticket and link each piece is linking to it. Sometimes, it might be useful to request a meeting or discuss in chat channels with the Zebra team to agree in the process to be taken.

I think this can be done in a separate PR. Right now I think it's important that people don't spend time on a process that we no longer follow :)

mergify bot added a commit that referenced this pull request Feb 22, 2024
@mergify mergify bot merged commit 9167093 into main Feb 22, 2024
93 checks passed
@mergify mergify bot deleted the mpguerra-remove-rfc branch February 22, 2024 10:52
@upbqdn upbqdn changed the title Update CONTRIBUTING.md chore: Remove Zebra RFCs from CONTRIBUTING.md Feb 22, 2024
@upbqdn upbqdn added the A-docs Area: Documentation label Feb 22, 2024
idky137 pushed a commit to idky137/zebra that referenced this pull request Feb 28, 2024
We have deprecated the RFC process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation extra-reviews This PR needs at least 2 reviews to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants