Skip to content

Conversation

thelukewalton
Copy link
Collaborator

This is done so that we can pass 'melos test' from the zeta_flutter monorepo

… pass 'melos test' from the zeta_flutter monorepo
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/scripts/runTests.ts:13

  • Consider using a consistent name for the coverage directory parameter across the codebase (e.g., 'coverageDir' vs 'coverageDirectory' vs 'COVERAGE_DIR') to improve clarity.
export const getTest = async (coverageDir: string, testCommand: string): Promise<stepResponse> => {

README.md:45

  • [nitpick] The documentation note regarding 'coverageDir' might be confusing. Consider clarifying that when a custom test-command is provided, the default coverage path is not automatically applied and users should ensure the test command handles coverage accordingly.
Test command is empty by default, and the command used is: `flutter test --coverage --reporter json --coverage-path ${coverageDir}/lcov.info`. This whole string is replaced with the content of test-command, so it is important to consider that `coverageDir` is not provided.

deps: Move to yarn for package management
ci: Update pull request for new changes
@thelukewalton thelukewalton merged commit 65582bb into main Apr 11, 2025
6 checks passed
@thelukewalton thelukewalton deleted the change-test-command branch April 11, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants