Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #419: update 2.1.x maintenance branch to 2.1.2 #420

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

elder4p
Copy link
Collaborator

@elder4p elder4p commented Aug 9, 2022

Setup up 2.1.2 builds on streams/v2.1.x-maintenance branch.

@elder4p elder4p changed the title Issue #418: update 2.1.x maintenance branch to 2.1.2 Issue #419: update 2.1.x maintenance branch to 2.1.2 Aug 9, 2022
@elder4p elder4p requested a review from ysroh August 9, 2022 00:11
@J17359
Copy link
Collaborator

J17359 commented Aug 11, 2022

Is there no automated build associated with this PR? It would be nice to see the artifacts produced with the new versions as a double check that nothing breaks :)

@elder4p
Copy link
Collaborator Author

elder4p commented Aug 11, 2022

Is there no automated build associated with this PR? It would be nice to see the artifacts produced with the new versions as a double check that nothing breaks :)

@17359: Just checked. There isn't. I'll update the rules to include the maintenance branches.

@elder4p
Copy link
Collaborator Author

elder4p commented Aug 11, 2022

@J17359 : There we go. Build has started. Once you've confirmed all the artifacts are OK, I'll make a similar change on the 'papyrus' branch so that this behaviour will carry forward when we next create a maintenance branch.

@elder4p elder4p requested a review from J17359 August 11, 2022 14:07
@elder4p
Copy link
Collaborator Author

elder4p commented Aug 11, 2022

@J17359 : Also adding you as an official reviewer of this pull request. Once you are satisfied, please give your +1. Thanks.

Copy link
Collaborator

@J17359 J17359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Build logs showed no occurrences of old 2.1.1 version and artifacts produced with new 2.1.2 version.

@elder4p
Copy link
Collaborator Author

elder4p commented Aug 11, 2022

@J17359 : I notice the papyrus 4.4.0 patch feature is still 2.1.0. Do we care? There has, of course, been no change there. Have you checked the RPM? I know I changed the version, but I do not trust myself on anything RPM.

@J17359
Copy link
Collaborator

J17359 commented Aug 11, 2022

@J17359 : I notice the papyrus 4.4.0 patch feature is still 2.1.0. Do we care? There has, of course, been no change there. Have you checked the RPM? I know I changed the version, but I do not trust myself on anything RPM.

Yes the RPM looks good!

As for the papyrus patch, I don't have a personal preference really. If it's not too much work, maybe roll it to 2.1.2 for consistency's sake? We must have missed rolling it to 2.1.1 when we did the initial version bump on that streams branch.

Copy link
Collaborator

@ysroh ysroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elder4p
Copy link
Collaborator Author

elder4p commented Aug 23, 2022

@J17359 , @ysroh : I have updated the pull papyrus patch version to 2.1.2. Build runs successfully, so I will merge.

@elder4p elder4p merged commit 9a0f44c into streams/v2.1.x-maintenance Aug 23, 2022
@elder4p elder4p deleted the papyrus_setup_2.1.2 branch August 23, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants