-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #419: update 2.1.x maintenance branch to 2.1.2 #420
Conversation
Is there no automated build associated with this PR? It would be nice to see the artifacts produced with the new versions as a double check that nothing breaks :) |
@17359: Just checked. There isn't. I'll update the rules to include the maintenance branches. |
@J17359 : There we go. Build has started. Once you've confirmed all the artifacts are OK, I'll make a similar change on the 'papyrus' branch so that this behaviour will carry forward when we next create a maintenance branch. |
@J17359 : Also adding you as an official reviewer of this pull request. Once you are satisfied, please give your +1. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Build logs showed no occurrences of old 2.1.1
version and artifacts produced with new 2.1.2
version.
@J17359 : I notice the papyrus 4.4.0 patch feature is still 2.1.0. Do we care? There has, of course, been no change there. Have you checked the RPM? I know I changed the version, but I do not trust myself on anything RPM. |
Yes the RPM looks good! As for the papyrus patch, I don't have a personal preference really. If it's not too much work, maybe roll it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Setup up 2.1.2 builds on streams/v2.1.x-maintenance branch.