Make the commitments generic over the hash function and remove deprecated hashing traits #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
survived
reviewed
Aug 9, 2021
src/cryptographic_primitives/proofs/sigma_correct_homomorphic_elgamal_enc.rs
Outdated
Show resolved
Hide resolved
src/cryptographic_primitives/proofs/sigma_correct_homomorphic_elgamal_enc.rs
Outdated
Show resolved
Hide resolved
survived
force-pushed
the
try-and-increment
branch
3 times, most recently
from
11c8420
to
d973d16
Compare
elichai
force-pushed
the
refactor-hashing
branch
from
faeb7da
to
3289218
Compare
elichai
force-pushed
the
refactor-hashing
branch
from
3289218
to
22507ef
Compare
survived
reviewed
Sep 1, 2021
| @@ -209,9 +207,9 @@ mod tests { | |||
|
|
|||
| let statement = LdeiStatement::new(&witness, alpha, g, d).unwrap(); | |||
|
|
|||
| let proof = LdeiProof::prove::<Sha256>(&witness, &statement).expect("failed to prove"); | |||
| let proof = LdeiProof::prove::<H>(&witness, &statement).expect("failed to prove"); | |||
There was a problem hiding this comment.
Should we make LdeiProof generic over choice of hash, instead of making its functions generic over H? Ie. I'm suggesting to replace LdeiProof::prove::<H>(..) with LdeiProof::<H>::prove(..). Just to match syntax that all other proofs have.
There was a problem hiding this comment.
Hmm yeah, I guess it also makes sense because the proof is correct only over a specific hash function
This was referenced Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was specified in: #128 (comment)
This will allow the user to choose their own hash function when using our hash and related commitments,
it also removes deprecated hashing traits that are no longer in use.
I added a macro to run all the related tests over multiple hash functions (right now: sha256, sha512, sha3_256, sha3_512, blake2b, blake2s)
This is based on #128 so for now I made try-and-increment the base branch but will change that if and when #128 will get merged.
Things that still use explicit hash funciton: